Always dispose of WebResponse

mythz · mythz · commit e90c635719fb · 2014-10-28T15:25:38.000-04:00
diff --git a/src/ServiceStack.Text/HttpUtils.cs b/src/ServiceStack.Text/HttpUtils.cs
@@ -609,9 +609,11 @@ public static HttpWebResponse GetErrorResponse(this string url)
             try
             {
                 var webReq = WebRequest.Create(url);
-                var webRes = PclExport.Instance.GetResponse(webReq);
-                var strRes = webRes.ReadToEnd();
-                return null;
+                using (var webRes = PclExport.Instance.GetResponse(webReq))
+                {
+                    var strRes = webRes.ReadToEnd();
+                    return null;
+                }
             }
             catch (WebException webEx)
             {

Original file line number	Diff line number	Diff line change
`@@ -609,9 +609,11 @@ public static HttpWebResponse GetErrorResponse(this string url)`
`609`	`609`	`try`
`610`	`610`	`{`
`611`	`611`	`var webReq = WebRequest.Create(url);`
`612`		`- var webRes = PclExport.Instance.GetResponse(webReq);`
`613`		`- var strRes = webRes.ReadToEnd();`
`614`		`- return null;`
	`612`	`+ using (var webRes = PclExport.Instance.GetResponse(webReq))`
	`613`	`+ {`
	`614`	`+ var strRes = webRes.ReadToEnd();`
	`615`	`+ return null;`
	`616`	`+ }`
`615`	`617`	`}`
`616`	`618`	`catch (WebException webEx)`
`617`	`619`	`{`