fix static code analysis issues

Author: Sesu8642

lib/widgets/collection_page.dart

@@ -17,7 +17,7 @@ import 'package:package_info_plus/package_info_plus.dart';
 import 'package:share_plus/share_plus.dart';
 
 class CollectionPage extends StatefulWidget {
-  const CollectionPage({Key? key}) : super(key: key);
+  const CollectionPage({super.key});
 
   @override
   CollectionPageState createState() => CollectionPageState();
@@ -62,7 +62,7 @@ class CollectionPageState extends State<CollectionPage> {
 
     if (!kIsWeb && Platform.isAndroid) {
       FlutterBackground.hasPermissions.then((hasPermissions) {
-        if (!hasPermissions) {
+        if (!hasPermissions && mounted) {
           showDialog<String>(
             context: context,
             builder: (BuildContext context) => AlertDialog(
@@ -230,7 +230,9 @@ class CollectionPageState extends State<CollectionPage> {
                         },
                       );
                     }
-                    await _transitionToTimerPage(context, tea);
+                    if (context.mounted) {
+                      await _transitionToTimerPage(context, tea);
+                    }
                   },
                   (tea) => {
                     showModalBottomSheet(
@@ -255,8 +257,10 @@ class CollectionPageState extends State<CollectionPage> {
                               (tea) {
                                 PersistenceService.updateTea(tea).then((value) {
                                   setState(() {});
-                                  Navigator.of(context).pop();
-                                  Navigator.of(context).pop();
+                                  if (context.mounted) {
+                                    Navigator.of(context).pop();
+                                    Navigator.of(context).pop();
+                                  }
                                 });
                               },
                               (tea) {
@@ -275,8 +279,10 @@ class CollectionPageState extends State<CollectionPage> {
                               (tea) {
                                 PersistenceService.addTea(tea).then((value) {
                                   setState(() {});
-                                  Navigator.of(context).pop();
-                                  Navigator.of(context).pop();
+                                  if (context.mounted) {
+                                    Navigator.of(context).pop();
+                                    Navigator.of(context).pop();
+                                  }
                                 });
                               },
                               (tea) {

lib/widgets/data_restore_dialog.dart

@@ -56,12 +56,18 @@ class DataRestoreDialog extends StatelessWidget {
                     jsonDecode(textController.text),
                   );
                   PersistenceService.restoreFomBackup(backup)
-                      .then((value) => Navigator.of(context).pop())
-                      .onError(
-                        (e, stackTrace) => ScaffoldMessenger.of(
-                          context,
-                        ).showSnackBar(SnackBar(content: Text(e.toString()))),
-                      );
+                      .then((value) {
+                        if (context.mounted) {
+                          return Navigator.of(context).pop();
+                        }
+                      })
+                      .onError((e, stackTrace) {
+                        if (context.mounted) {
+                          ScaffoldMessenger.of(
+                            context,
+                          ).showSnackBar(SnackBar(content: Text(e.toString())));
+                        }
+                      });
                 } catch (e) {
                   ScaffoldMessenger.of(
                     context,

lib/widgets/notes_page.dart

@@ -9,7 +9,7 @@ import 'package:infusion_timer/tea.dart';
 class NotesPage extends StatefulWidget {
   final Tea tea;
 
-  const NotesPage({Key? key, required this.tea}) : super(key: key);
+  const NotesPage({super.key, required this.tea});
 
   @override
   NotesPageState createState() => NotesPageState();
@@ -19,7 +19,7 @@ class NotesPageState extends State<NotesPage> {
   final _formKey = GlobalKey<FormState>();
   bool _hasUnsavedChanges = false;
 
-  Future<void> _onPopInvoked(bool didPop) async {
+  Future<void> _onPopInvoked(bool didPop, dynamic result) async {
     // confirm cancelling infusion if going back to collection page
     if (didPop) {
       return;
@@ -53,12 +53,12 @@ class NotesPageState extends State<NotesPage> {
       case 0:
         _formKey.currentState!.save();
         PersistenceService.updateTea(widget.tea);
-        if (context.mounted) {
+        if (mounted) {
           Navigator.pop(context);
         }
         break;
       case 1:
-        if (context.mounted) {
+        if (mounted) {
           Navigator.pop(context);
         }
         break;
@@ -72,7 +72,7 @@ class NotesPageState extends State<NotesPage> {
   Widget build(BuildContext context) {
     return PopScope(
       canPop: !_hasUnsavedChanges,
-      onPopInvoked: _onPopInvoked,
+      onPopInvokedWithResult: _onPopInvoked,
       child: Scaffold(
         appBar: AppBar(title: const Text("Notes")),
         body: Form(

lib/widgets/preferences_page.dart

@@ -7,7 +7,7 @@ import 'package:infusion_timer/widgets/data_backup_dialog.dart';
 import 'package:infusion_timer/widgets/data_restore_dialog.dart';
 
 class PreferencesPage extends StatefulWidget {
-  const PreferencesPage({Key? key}) : super(key: key);
+  const PreferencesPage({super.key});
 
   @override
   PreferencesPageState createState() => PreferencesPageState();

lib/widgets/star_rating_form_field.dart

@@ -5,14 +5,11 @@ import 'package:flutter/material.dart';
 class StarRatingFormField extends FormField<int> {
   StarRatingFormField({
     super.key,
-    FormFieldSetter<int>? onSaved,
-    FormFieldValidator<int>? validator,
-    int initialValue = 0,
+    super.onSaved,
+    super.validator,
+    int super.initialValue = 0,
     AutovalidateMode autovalidate = AutovalidateMode.disabled,
   }) : super(
-         onSaved: onSaved,
-         validator: validator,
-         initialValue: initialValue,
          autovalidateMode: autovalidate,
          builder: (FormFieldState<int> state) {
            return Row(

lib/widgets/timer_page.dart

@@ -30,7 +30,7 @@ const String sessionSavePrefix = "session:";
 class TimerPage extends StatefulWidget {
   final Tea tea;
 
-  const TimerPage({Key? key, required this.tea}) : super(key: key);
+  const TimerPage({super.key, required this.tea});
 
   @override
   TimerPageState createState() => TimerPageState();
@@ -253,7 +253,7 @@ class TimerPageState extends State<TimerPage>
             }
             if (!kIsWeb) {
               FlutterVolumeController.getVolume().then((value) {
-                if (value == 0) {
+                if (value == 0 && mounted) {
                   ScaffoldMessenger.of(context).showSnackBar(
                     const SnackBar(
                       content: Text("Device is muted and won't ring!"),
@@ -285,7 +285,7 @@ class TimerPageState extends State<TimerPage>
     });
   }
 
-  Future<void> _onPopInvoked(bool didPop) async {
+  Future<void> _onPopInvoked(bool didPop, dynamic result) async {
     // confirm cancelling infusion if going back to collection page
     if (didPop) {
       return;
@@ -313,7 +313,7 @@ class TimerPageState extends State<TimerPage>
         );
       },
     );
-    if ((shouldDiscard ?? false) && context.mounted) {
+    if ((shouldDiscard ?? false) && mounted) {
       Navigator.pop(context);
     }
   }
@@ -344,7 +344,7 @@ class TimerPageState extends State<TimerPage>
     return PopScope(
       canPop:
           _animationController.isCompleted || _animationController.value == 0,
-      onPopInvoked: _onPopInvoked,
+      onPopInvokedWithResult: _onPopInvoked,
       child: Scaffold(
         appBar: AppBar(title: const Text("Tea Timer")),
         body: Align(
@@ -423,7 +423,7 @@ class TimerPageState extends State<TimerPage>
                                       return Icons.play_arrow;
                                     }
                                   }()),
-                                  color: Colors.white.withOpacity(0.5),
+                                  color: Colors.white.withValues(alpha: 0.5),
                                   onPressed: _startPauseNext,
                                   iconSize: progressIndicatorDiameter * 0.65,
                                 ),