Skip to content

Commit 5c15336

Browse files
committed
bump set-v2-strategies package to v0.0.11, include ZeroExApiAdapterV5 as valid BatchTradeExtension integration
1 parent f250851 commit 5c15336

File tree

8 files changed

+38
-8
lines changed

8 files changed

+38
-8
lines changed

ethereum/deploy/003_batch_trade_extension.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ const func: DeployFunction = trackFinishedStage(CURRENT_STAGE, async function (b
4141
async function deployBatchTradeExtension(): Promise<void> {
4242
const checkBatchTradeExtensionAddress = await getContractAddress(CONTRACT_NAMES.BATCH_TRADE_EXTENSION);
4343
if (checkBatchTradeExtensionAddress === "") {
44-
const constructorArgs = [managerCoreAddress, tradeModuleAddress];
44+
const constructorArgs = [managerCoreAddress, tradeModuleAddress, ["ZeroExApiAdapterV5"]];
4545
const batchTradeExtensionDeploy = await deploy(
4646
CONTRACT_NAMES.BATCH_TRADE_EXTENSION,
4747
{ from: deployer, args: constructorArgs, log: true }

ethereum/test/deploys/003_batch_trade_extension.spec.ts

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,5 +61,15 @@ describe("Batch Trade Extension", () => {
6161
const validBatchTradeExtension = await managerCoreInstance.isExtension(batchTradeExtensionInstance.address);
6262
expect(validBatchTradeExtension).to.eq(true);
6363
});
64+
65+
it("should have set the correct integrations length of 1", async () => {
66+
const integrations = await batchTradeExtensionInstance.getIntegrations();
67+
expect(integrations.length).to.eq(1);
68+
});
69+
70+
it("should have ZeroExApiAdapterV5 as a valid integration", async () => {
71+
const validZeroExApiAdapterV5 = await batchTradeExtensionInstance.isIntegration("ZeroExApiAdapterV5");
72+
expect(validZeroExApiAdapterV5).to.eq(true);
73+
});
6474
});
6575
});

optimism/deploy/006_batch_trade_extension.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ const func: DeployFunction = trackFinishedStage(CURRENT_STAGE, async function (b
4141
async function deployBatchTradeExtension(): Promise<void> {
4242
const checkBatchTradeExtensionAddress = await getContractAddress(CONTRACT_NAMES.BATCH_TRADE_EXTENSION);
4343
if (checkBatchTradeExtensionAddress === "") {
44-
const constructorArgs = [managerCoreAddress, tradeModuleAddress];
44+
const constructorArgs = [managerCoreAddress, tradeModuleAddress, ["ZeroExApiAdapterV5"]];
4545
const batchTradeExtensionDeploy = await deploy(
4646
CONTRACT_NAMES.BATCH_TRADE_EXTENSION,
4747
{ from: deployer, args: constructorArgs, log: true }

optimism/test/deploys/006_batch_trade_extension.spec.ts

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,5 +61,15 @@ describe("Batch Trade Extension", () => {
6161
const validBatchTradeExtension = await managerCoreInstance.isExtension(batchTradeExtensionInstance.address);
6262
expect(validBatchTradeExtension).to.eq(true);
6363
});
64+
65+
it("should have set the correct integrations length of 1", async () => {
66+
const integrations = await batchTradeExtensionInstance.getIntegrations();
67+
expect(integrations.length).to.eq(1);
68+
});
69+
70+
it("should have ZeroExApiAdapterV5 as a valid integration", async () => {
71+
const validZeroExApiAdapterV5 = await batchTradeExtensionInstance.isIntegration("ZeroExApiAdapterV5");
72+
expect(validZeroExApiAdapterV5).to.eq(true);
73+
});
6474
});
6575
});

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@
8686
"@indexcoop/index-coop-smart-contracts": "^0.2.0",
8787
"@perp/curie-contract": "^0.14.0-staging",
8888
"@setprotocol/set-protocol-v2": "^0.10.1",
89-
"@setprotocol/set-v2-strategies": "0.0.10",
89+
"@setprotocol/set-v2-strategies": "0.0.11",
9090
"ethers": "5.5.2",
9191
"fs-extra": "^5.0.0",
9292
"module-alias": "^2.2.2",

polygon/deploy/003_batch_trade_extension.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ const func: DeployFunction = trackFinishedStage(CURRENT_STAGE, async function (b
4141
async function deployBatchTradeExtension(): Promise<void> {
4242
const checkBatchTradeExtensionAddress = await getContractAddress(CONTRACT_NAMES.BATCH_TRADE_EXTENSION);
4343
if (checkBatchTradeExtensionAddress === "") {
44-
const constructorArgs = [managerCoreAddress, tradeModuleAddress];
44+
const constructorArgs = [managerCoreAddress, tradeModuleAddress, ["ZeroExApiAdapterV5"]];
4545
const batchTradeExtensionDeploy = await deploy(
4646
CONTRACT_NAMES.BATCH_TRADE_EXTENSION,
4747
{ from: deployer, args: constructorArgs, log: true }

polygon/test/deploys/003_batch_trade_extension.spec.ts

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,5 +61,15 @@ describe("Batch Trade Extension", () => {
6161
const validBatchTradeExtension = await managerCoreInstance.isExtension(batchTradeExtensionInstance.address);
6262
expect(validBatchTradeExtension).to.eq(true);
6363
});
64+
65+
it("should have set the correct integrations length of 1", async () => {
66+
const integrations = await batchTradeExtensionInstance.getIntegrations();
67+
expect(integrations.length).to.eq(1);
68+
});
69+
70+
it("should have ZeroExApiAdapterV5 as a valid integration", async () => {
71+
const validZeroExApiAdapterV5 = await batchTradeExtensionInstance.isIntegration("ZeroExApiAdapterV5");
72+
expect(validZeroExApiAdapterV5).to.eq(true);
73+
});
6474
});
6575
});

yarn.lock

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1626,10 +1626,10 @@
16261626
module-alias "^2.2.2"
16271627
replace-in-file "^6.1.0"
16281628

1629-
"@setprotocol/[email protected].10":
1630-
version "0.0.10"
1631-
resolved "https://registry.yarnpkg.com/@setprotocol/set-v2-strategies/-/set-v2-strategies-0.0.10.tgz#eab1bc4001c7a0d5dac61b82ff991d413daf5fde"
1632-
integrity sha512-Jca6tLOadDSF0hRw65ML6Sf69Z3lwUJFYta4jn08iaKnGZMgRlDiRo8KvpWolmyznnCLTdFOPtz/woJKqkc09w==
1629+
"@setprotocol/[email protected].11":
1630+
version "0.0.11"
1631+
resolved "https://registry.yarnpkg.com/@setprotocol/set-v2-strategies/-/set-v2-strategies-0.0.11.tgz#d8243f44f1ec0761051163cbfe091aef27278820"
1632+
integrity sha512-0CeLtoI88nuBgo9rGmUtt2lE+kZ2taPtzFPFVSFz5fftCESyfaKxDY9H1IVivtP5ACSbdknnR6TUFsDZJpE5UQ==
16331633
dependencies:
16341634
"@setprotocol/set-protocol-v2" "0.10.0-hhat.1"
16351635
"@uniswap/v3-sdk" "^3.5.1"

0 commit comments

Comments
 (0)