Restore req that there is at least 1 element in extensions[] param when creating

Author: cgewecke

contracts/factories/DelegatedManagerFactory.sol

@@ -134,6 +134,8 @@ contract DelegatedManagerFactory {
         external
         returns (ISetToken, address)
     {
+        require(_extensions.length > 0, "Must have at least 1 extension");
+
         if (_assets.length != 0) {
             _validateComponentsIncludedInAssetsList(_components, _assets);
         }
@@ -188,6 +190,8 @@ contract DelegatedManagerFactory {
         external
         returns (address)
     {
+        require(_extensions.length > 0, "Must have at least 1 extension");
+
         if (_assets.length != 0) {
             _validateComponentsIncludedInAssetsList(_setToken.getComponents(), _assets);
         }

test/factories/delegatedManagerFactory.spec.ts

@@ -291,6 +291,16 @@ describe("DelegatedManagerFactory", () => {
         expect(await delegatedManager.useAssetAllowlist()).eq(false);
       });
     });
+
+    describe("when the extensions array is empty", async() => {
+      beforeEach(async() => {
+        subjectExtensions = [];
+      });
+
+      it("should revert", async() => {
+        await expect(subject()).to.be.revertedWith("Must have at least 1 extension");
+      });
+    });
   });
 
   describe("#createManager", () => {
@@ -448,6 +458,16 @@ describe("DelegatedManagerFactory", () => {
         expect(await delegatedManager.useAssetAllowlist()).eq(false);
       });
     });
+
+    describe("when the extensions array is empty", async() => {
+      beforeEach(async() => {
+        subjectExtensions = [];
+      });
+
+      it("should revert", async() => {
+        await expect(subject()).to.be.revertedWith("Must have at least 1 extension");
+      });
+    });
   });
 
   describe("initialize", () => {