Pranav/global extensions emit events (#19)

pblivin0x · web-flow · commit 6d5237862931 · 2022-03-14T14:09:30.000-04:00
* use emit keyword in global extension events

* bump package version v0.0.6
diff --git a/contracts/extensions/IssuanceExtension.sol b/contracts/extensions/IssuanceExtension.sol
@@ -148,7 +148,7 @@ contract IssuanceExtension is BaseGlobalExtension {
 
         _initializeExtension(setToken, _delegatedManager);
 
-        IssuanceExtensionInitialized(address(setToken), address(_delegatedManager));
+        emit IssuanceExtensionInitialized(address(setToken), address(_delegatedManager));
     }
 
     /**
@@ -187,7 +187,7 @@ contract IssuanceExtension is BaseGlobalExtension {
             _managerIssuanceHook
         );
 
-        IssuanceExtensionInitialized(address(setToken), address(_delegatedManager));
+        emit IssuanceExtensionInitialized(address(setToken), address(_delegatedManager));
     }
 
     /**
diff --git a/contracts/extensions/StreamingFeeSplitExtension.sol b/contracts/extensions/StreamingFeeSplitExtension.sol
@@ -135,7 +135,7 @@ contract StreamingFeeSplitExtension is BaseGlobalExtension {
 
         _initializeExtension(setToken, _delegatedManager);
 
-        StreamingFeeSplitExtensionInitialized(address(setToken), address(_delegatedManager));
+        emit StreamingFeeSplitExtensionInitialized(address(setToken), address(_delegatedManager));
     }
 
     /**
@@ -158,7 +158,7 @@ contract StreamingFeeSplitExtension is BaseGlobalExtension {
         _initializeExtension(setToken, _delegatedManager);
         _initializeModule(setToken, _delegatedManager, _settings);
 
-        StreamingFeeSplitExtensionInitialized(address(setToken), address(_delegatedManager));
+        emit StreamingFeeSplitExtensionInitialized(address(setToken), address(_delegatedManager));
     }
 
     /**
diff --git a/contracts/extensions/TradeExtension.sol b/contracts/extensions/TradeExtension.sol
@@ -79,7 +79,7 @@ contract TradeExtension is BaseGlobalExtension {
 
         _initializeExtension(setToken, _delegatedManager);
 
-        TradeExtensionInitialized(address(setToken), address(_delegatedManager));
+        emit TradeExtensionInitialized(address(setToken), address(_delegatedManager));
     }
 
     /**
@@ -95,7 +95,7 @@ contract TradeExtension is BaseGlobalExtension {
         _initializeExtension(setToken, _delegatedManager);
         _initializeModule(setToken, _delegatedManager);
 
-        TradeExtensionInitialized(address(setToken), address(_delegatedManager));
+        emit TradeExtensionInitialized(address(setToken), address(_delegatedManager));
     }
 
     /**
diff --git a/contracts/lib/BaseGlobalExtension.sol b/contracts/lib/BaseGlobalExtension.sol
@@ -155,6 +155,6 @@ abstract contract BaseGlobalExtension {
 
         delete setManagers[setToken];
 
-        ExtensionRemoved(address(setToken), address(delegatedManager));
+        emit ExtensionRemoved(address(setToken), address(delegatedManager));
     }
 }
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@setprotocol/set-v2-strategies",
-  "version": "0.0.5",
+  "version": "0.0.6",
   "description": "",
   "main": "dist",
   "types": "dist/types",

Original file line number	Diff line number	Diff line change
`@@ -148,7 +148,7 @@ contract IssuanceExtension is BaseGlobalExtension {`
`148`	`148`
`149`	`149`	`_initializeExtension(setToken, _delegatedManager);`
`150`	`150`
`151`		`- IssuanceExtensionInitialized(address(setToken), address(_delegatedManager));`
	`151`	`+ emit IssuanceExtensionInitialized(address(setToken), address(_delegatedManager));`
`152`	`152`	`}`
`153`	`153`
`154`	`154`	`/**`
`@@ -187,7 +187,7 @@ contract IssuanceExtension is BaseGlobalExtension {`
`187`	`187`	`_managerIssuanceHook`
`188`	`188`	`);`
`189`	`189`
`190`		`- IssuanceExtensionInitialized(address(setToken), address(_delegatedManager));`
	`190`	`+ emit IssuanceExtensionInitialized(address(setToken), address(_delegatedManager));`
`191`	`191`	`}`
`192`	`192`
`193`	`193`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -135,7 +135,7 @@ contract StreamingFeeSplitExtension is BaseGlobalExtension {`
`135`	`135`
`136`	`136`	`_initializeExtension(setToken, _delegatedManager);`
`137`	`137`
`138`		`- StreamingFeeSplitExtensionInitialized(address(setToken), address(_delegatedManager));`
	`138`	`+ emit StreamingFeeSplitExtensionInitialized(address(setToken), address(_delegatedManager));`
`139`	`139`	`}`
`140`	`140`
`141`	`141`	`/**`
`@@ -158,7 +158,7 @@ contract StreamingFeeSplitExtension is BaseGlobalExtension {`
`158`	`158`	`_initializeExtension(setToken, _delegatedManager);`
`159`	`159`	`_initializeModule(setToken, _delegatedManager, _settings);`
`160`	`160`
`161`		`- StreamingFeeSplitExtensionInitialized(address(setToken), address(_delegatedManager));`
	`161`	`+ emit StreamingFeeSplitExtensionInitialized(address(setToken), address(_delegatedManager));`
`162`	`162`	`}`
`163`	`163`
`164`	`164`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -79,7 +79,7 @@ contract TradeExtension is BaseGlobalExtension {`
`79`	`79`
`80`	`80`	`_initializeExtension(setToken, _delegatedManager);`
`81`	`81`
`82`		`- TradeExtensionInitialized(address(setToken), address(_delegatedManager));`
	`82`	`+ emit TradeExtensionInitialized(address(setToken), address(_delegatedManager));`
`83`	`83`	`}`
`84`	`84`
`85`	`85`	`/**`
`@@ -95,7 +95,7 @@ contract TradeExtension is BaseGlobalExtension {`
`95`	`95`	`_initializeExtension(setToken, _delegatedManager);`
`96`	`96`	`_initializeModule(setToken, _delegatedManager);`
`97`	`97`
`98`		`- TradeExtensionInitialized(address(setToken), address(_delegatedManager));`
	`98`	`+ emit TradeExtensionInitialized(address(setToken), address(_delegatedManager));`
`99`	`99`	`}`
`100`	`100`
`101`	`101`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -155,6 +155,6 @@ abstract contract BaseGlobalExtension {`
`155`	`155`
`156`	`156`	`delete setManagers[setToken];`
`157`	`157`
`158`		`- ExtensionRemoved(address(setToken), address(delegatedManager));`
	`158`	`+ emit ExtensionRemoved(address(setToken), address(delegatedManager));`
`159`	`159`	`}`
`160`	`160`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@setprotocol/set-v2-strategies",`
`3`		`- "version": "0.0.5",`
	`3`	`+ "version": "0.0.6",`
`4`	`4`	`"description": "",`
`5`	`5`	`"main": "dist",`
`6`	`6`	`"types": "dist/types",`