Skip to content

Commit 75dbcf0

Browse files
author
Sachin
authored
PerpV2 manager extension internal audit fixes (#10)
* Fix: _calculateCurrentLeverageRatio * Fix failing tests * Replace all .mul(-1) with .neg() * Fix _trade javadocs * Fix rebalance() javadoc * Remove .only() from tests * Fix ripcord() javadocs * Fix: engage treats dust amounts as zero * Add functions to IAccountBalance interface * Add TWAP cooldown period in disengage * Add warning to to disengage javadoc * Fix PreciseUnitMath tests * Engage: Check base position unit instead of balance * Remove PreciseUnitMath lib and import from setprotocol package instead * Update setprotocol dependency to 0.11.0 * Fix compile bugs * Update yarn.lock file * Fix yarn.lock
1 parent 6b06438 commit 75dbcf0

File tree

10 files changed

+189
-918
lines changed

10 files changed

+189
-918
lines changed

contracts/extensions/FeeSplitExtension.sol

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,12 +22,13 @@ pragma experimental ABIEncoderV2;
2222
import { Address } from "@openzeppelin/contracts/utils/Address.sol";
2323
import { SafeMath } from "@openzeppelin/contracts/math/SafeMath.sol";
2424

25+
import { PreciseUnitMath } from "@setprotocol/set-protocol-v2/contracts/lib/PreciseUnitMath.sol";
26+
2527
import { BaseExtension } from "../lib/BaseExtension.sol";
2628
import { IIssuanceModule } from "../interfaces/IIssuanceModule.sol";
2729
import { IBaseManager } from "../interfaces/IBaseManager.sol";
2830
import { ISetToken } from "../interfaces/ISetToken.sol";
2931
import { IStreamingFeeModule } from "../interfaces/IStreamingFeeModule.sol";
30-
import { PreciseUnitMath } from "../lib/PreciseUnitMath.sol";
3132
import { TimeLockUpgrade } from "../lib/TimeLockUpgrade.sol";
3233

3334

contracts/extensions/PerpV2LeverageStrategyExtension.sol

Lines changed: 91 additions & 63 deletions
Large diffs are not rendered by default.

contracts/interfaces/IAccountBalance.sol

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,8 @@ interface IAccountBalance {
2727
function getTotalDebtValue(address trader) external view returns (uint256);
2828
function getPnlAndPendingFee(address trader) external view returns (int256,int256,uint256);
2929
function getBase(address trader, address baseToken) external view returns (int256);
30+
function getTakerPositionSize(address trader, address baseToken) external view returns (int256 takerPositionSize);
31+
function getTakerOpenNotional(address trader, address baseToken) external view returns (int256 openNotional);
3032
function getQuote(address trader, address baseToken) external view returns (int256);
3133
function getNetQuoteBalanceAndPendingFee(address trader) external view returns (int256, uint256);
3234
function getPositionSize(address trader, address baseToken) external view returns (int256);

contracts/lib/PreciseUnitMath.sol

Lines changed: 0 additions & 208 deletions
This file was deleted.

contracts/mocks/PreciseUnitMathMock.sol

Lines changed: 0 additions & 88 deletions
This file was deleted.

0 commit comments

Comments
 (0)