Add check to make sure all extensions are removed before changing manager address.

Author: bweick

contracts/manager/DelegatedManager.sol

@@ -366,6 +366,7 @@ contract DelegatedManager is Ownable {
      */
     function setManager(address _newManager) external onlyOwner {
         require(_newManager != address(0), "Zero address not valid");
+        require(extensions.length == 0, "Must remove all extensions");
         setToken.setManager(_newManager);
     }
 

test/manager/delegatedManager.spec.ts

@@ -898,7 +898,7 @@ describe("DelegatedManager", () => {
     });
   });
 
-  describe("#setManager", async () => {
+  describe.only("#setManager", async () => {
     let subjectNewManager: Address;
     let subjectCaller: Account;
 
@@ -918,6 +918,16 @@ describe("DelegatedManager", () => {
       expect(manager).to.eq(newManager.address);
     });
 
+    describe("when manager still has extension initialized", async () => {
+      beforeEach(async () => {
+        await baseExtension.initializeExtension(setToken.address, delegatedManager.address);
+      });
+
+      it("should revert", async () => {
+        await expect(subject()).to.be.revertedWith("Must remove all extensions");
+      });
+    });
+
     describe("when passed manager is the zero address", async () => {
       beforeEach(async () => {
         subjectNewManager = ADDRESS_ZERO;