Merge pull request #99 from SetProtocol/justin_chen-fix-assertion

justinkchen · web-flow · commit 55c0e6c5b0ed · 2022-01-04T02:21:24.000-05:00
Fix isNotUndefined assertion
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
     "name": "set.js",
-    "version": "0.4.7",
+    "version": "0.4.8",
     "description": "A javascript library for interacting with the Set Protocol v2",
     "keywords": [
         "set.js",
diff --git a/src/assertions/CommonAssertions.ts b/src/assertions/CommonAssertions.ts
@@ -75,7 +75,7 @@ export class CommonAssertions {
   }
 
   public isNotUndefined(value: any, errorMessage: string) {
-    if (!value) {
+    if (value === undefined) {
       throw new Error(errorMessage);
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "set.js",`
`3`		`- "version": "0.4.7",`
	`3`	`+ "version": "0.4.8",`
`4`	`4`	`"description": "A javascript library for interacting with the Set Protocol v2",`
`5`	`5`	`"keywords": [`
`6`	`6`	`"set.js",`
Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,7 @@ export class CommonAssertions {`
`75`	`75`	`}`
`76`	`76`
`77`	`77`	`public isNotUndefined(value: any, errorMessage: string) {`
`78`		`- if (!value) {`
	`78`	`+ if (value === undefined) {`
`79`	`79`	`throw new Error(errorMessage);`
`80`	`80`	`}`
`81`	`81`	`}`