Remove unused wrapper functions

Author: richardliang

src/wrappers/strategies/AssetPairManagerV2Wrapper.ts

@@ -38,42 +38,6 @@ export class AssetPairManagerV2Wrapper {
     this.contracts = new StrategyContractWrapper(this.web3);
   }
 
-  /**
-   * Calls an AssetPairManagerV2's intialPropose function. This function kicks off a propose cycle on the
-   * manager by checking that the time and price constraints have been met then logging a timestamp used later in the
-   * process to confirm the signal.
-   *
-   * @param  managerAddress               Address of the rebalancing manager contract
-   * @return                              The hash of the resulting transaction.
-   */
-  public async initialPropose(
-    managerAddress: Address,
-    txOpts?: Tx,
-  ): Promise<string> {
-    const assetPairManagerInstance = await this.contracts.loadAssetPairManagerV2ContractAsync(managerAddress);
-    const txOptions = await generateTxOpts(this.web3, txOpts);
-
-    return await assetPairManagerInstance.initialPropose.sendTransactionAsync(txOptions);
-  }
-
-  /**
-   * Calls an AssetPairManagerV2's confirmPropose function. This function again checks to make sure that
-   * price and time constraints have been satisfied. After that it generates the new allocation proposal and sends the
-   * results to the Rebalancing Set Token to kick off the official rebalance.
-   *
-   * @param  managerAddress               Address of the rebalancing manager contract
-   * @return                              The hash of the resulting transaction.
-   */
-  public async confirmPropose(
-    managerAddress: Address,
-    txOpts?: Tx,
-  ): Promise<string> {
-    const assetPairManagerInstance = await this.contracts.loadAssetPairManagerV2ContractAsync(managerAddress);
-    const txOptions = await generateTxOpts(this.web3, txOpts);
-
-    return await assetPairManagerInstance.confirmPropose.sendTransactionAsync(txOptions);
-  }
-
   /**
    * Update liquidator used by Rebalancing Set.
    *
@@ -170,32 +134,6 @@ export class AssetPairManagerV2Wrapper {
     );
   }
 
-  /**
-   * Calls an AssetPairManagerV2's canInitialPropose function. Returns whether initialPropose can be called
-   * without reverting.
-   *
-   * @param  managerAddress               Address of the rebalancing manager contract
-   * @return                              Boolean indicating whether initialPropose can be successfully called
-   */
-  public async canInitialPropose(managerAddress: Address): Promise<boolean> {
-    const assetPairManagerInstance = await this.contracts.loadAssetPairManagerV2ContractAsync(managerAddress);
-
-    return await assetPairManagerInstance.canInitialPropose.callAsync();
-  }
-
-  /**
-   * Calls an AssetPairManagerV2's canConfirmPropose function. Returns whether confirmPropose can be called
-   * without reverting.
-   *
-   * @param  managerAddress               Address of the rebalancing manager contract
-   * @return                              Boolean indicating whether confirmPropose can be successfully called
-   */
-  public async canConfirmPropose(managerAddress: Address): Promise<boolean> {
-    const assetPairManagerInstance = await this.contracts.loadAssetPairManagerV2ContractAsync(managerAddress);
-
-    return await assetPairManagerInstance.canConfirmPropose.callAsync();
-  }
-
   public async core(managerAddress: Address): Promise<Address> {
     const assetPairManagerInstance = await this.contracts.loadAssetPairManagerV2ContractAsync(managerAddress);
 

test/integration/wrappers/strategies/AssetPairManagerV2Wrapper.spec.ts

@@ -78,7 +78,6 @@ import {
   deployTimeSeriesFeedAsync,
   deployTokensSpecifyingDecimals,
   deployWhiteListContract,
-  increaseChainTimeAsync,
   initializeManagerAsync,
 } from '@test/helpers';
 import {
@@ -578,152 +577,6 @@ describe('AssetPairManagerV2Wrapper', () => {
     });
   });
 
-  describe('initialPropose', async () => {
-    let subjectManagerAddress: Address;
-
-    beforeEach(async () => {
-      subjectManagerAddress = assetPairManagerV2.address;
-
-      // Elapse the rebalance interval
-      await increaseChainTimeAsync(web3, ONE_DAY_IN_SECONDS);
-    });
-
-    async function subject(): Promise<string> {
-      return await assetPairManagerV2Wrapper.initialPropose(
-        subjectManagerAddress,
-      );
-    }
-
-    test('sets the recentInitialProposeTimestamp properly', async () => {
-      const txnHash = await subject();
-      const { blockNumber } = await web3.eth.getTransactionReceipt(txnHash);
-      const { timestamp } = await web3.eth.getBlock(blockNumber);
-
-      const lastTimestamp = await assetPairManagerV2Wrapper.recentInitialProposeTimestamp(
-        subjectManagerAddress,
-      );
-      expect(lastTimestamp).to.bignumber.equal(timestamp);
-    });
-  });
-
-  describe('confirmPropose', async () => {
-    let subjectManagerAddress: Address;
-
-    beforeEach(async () => {
-      subjectManagerAddress = assetPairManagerV2.address;
-
-      // Elapse the rebalance interval
-      await increaseChainTimeAsync(web3, ONE_DAY_IN_SECONDS);
-      await assetPairManagerV2.initialPropose.sendTransactionAsync();
-
-      // Issue currentSetToken
-      await core.issue.sendTransactionAsync(
-        initialBaseCollateral.address,
-        ether(9),
-        {from: DEFAULT_ACCOUNT },
-      );
-      await approveForTransferAsync([initialBaseCollateral], transferProxy.address);
-
-      // Use issued currentSetToken to issue rebalancingSetToken
-      await core.issue.sendTransactionAsync(
-        rebalancingSetToken.address,
-        ether(7),
-        {from: DEFAULT_ACCOUNT },
-      );
-
-      // Elapse the signal confirmation period
-      await increaseChainTimeAsync(web3, ONE_HOUR_IN_SECONDS.mul(7));
-    });
-
-    async function subject(): Promise<string> {
-      return await assetPairManagerV2Wrapper.confirmPropose(
-        subjectManagerAddress,
-      );
-    }
-
-    test('sets the rebalancing Set into rebalance period', async () => {
-      await subject();
-      const rebalanceStateEnum = new BigNumber(2);
-      const rebalancingSetState = await rebalancingSetToken.rebalanceState.callAsync();
-
-      expect(rebalancingSetState).to.bignumber.equal(rebalanceStateEnum);
-    });
-  });
-
-  describe('canInitialPropose', async () => {
-    let subjectManagerAddress: Address;
-    let subjectTimeFastForward: BigNumber;
-
-    beforeEach(async () => {
-      subjectManagerAddress = assetPairManagerV2.address;
-      subjectTimeFastForward = ONE_DAY_IN_SECONDS;
-    });
-
-    async function subject(): Promise<boolean> {
-      await increaseChainTimeAsync(web3, subjectTimeFastForward);
-      return await assetPairManagerV2Wrapper.canInitialPropose(
-        subjectManagerAddress,
-      );
-    }
-
-    test('sets the recentInitialProposeTimestamp properly', async () => {
-      const canInitialPropose = await subject();
-
-      expect(canInitialPropose).to.be.true;
-    });
-
-    describe('when initialPropose not valid', async () => {
-      beforeEach(async () => {
-        subjectTimeFastForward = ZERO;
-      });
-
-      test('returns false', async () => {
-        const canInitialPropose = await subject();
-
-        expect(canInitialPropose).to.be.false;
-      });
-    });
-  });
-
-  describe('canConfirmPropose', async () => {
-    let subjectManagerAddress: Address;
-    let subjectTimeFastForward: BigNumber;
-
-    beforeEach(async () => {
-      subjectManagerAddress = assetPairManagerV2.address;
-      subjectTimeFastForward = ONE_HOUR_IN_SECONDS.mul(7);
-
-      // Elapse the rebalance interval
-      await increaseChainTimeAsync(web3, ONE_DAY_IN_SECONDS);
-      await assetPairManagerV2.initialPropose.sendTransactionAsync();
-    });
-
-    async function subject(): Promise<boolean> {
-      await increaseChainTimeAsync(web3, subjectTimeFastForward);
-      return await assetPairManagerV2Wrapper.canConfirmPropose(
-        subjectManagerAddress,
-      );
-    }
-
-    test('sets the recentInitialProposeTimestamp properly', async () => {
-      const canInitialPropose = await subject();
-
-      expect(canInitialPropose).to.be.true;
-    });
-
-    describe('when initialPropose not valid', async () => {
-      beforeEach(async () => {
-        subjectTimeFastForward = ZERO;
-      });
-
-      test('returns false', async () => {
-        const canInitialPropose = await subject();
-
-        expect(canInitialPropose).to.be.false;
-      });
-    });
-  });
-
   describe('setLiquidator', async () => {
     let subjectNewLiquidator: Address;
     let subjectManagerAddress: Address;