Fix PHPStan errors

Author: loevgaard

src/Controller/Action/Shop/ShowFeedAction.php

@@ -68,9 +68,8 @@ public function __invoke(string $code): StreamedResponse
             }
         }
 
-        /** @var resource|false $stream */
         $stream = $filesystem->readStream((string) $feedPath);
-        if (false === $stream) {
+        if (!\is_resource($stream)) {
             throw new RuntimeException(sprintf('An error occurred trying to read the feed file %s', $feedPath));
         }
 

src/DataProvider/DataProvider.php

@@ -17,12 +17,16 @@
 use Setono\SyliusFeedPlugin\Event\QueryBuilderEvent;
 use Sylius\Component\Core\Model\ChannelInterface;
 use Sylius\Component\Locale\Model\LocaleInterface;
+use Sylius\Component\Resource\Model\ResourceInterface;
 
 class DataProvider implements DataProviderInterface
 {
     /** @var CollectionBatcherInterface[] */
     private array $batchers = [];
 
+    /**
+     * @param class-string $class
+     */
     public function __construct(
         private readonly BatcherFactoryInterface $batcherFactory,
         private readonly QueryRebuilderInterface $queryRebuilder,
@@ -53,7 +57,10 @@ public function getBatchCount(ChannelInterface $channel, LocaleInterface $locale
 
     public function getItems(BatchInterface $batch): iterable
     {
-        return $this->queryRebuilder->rebuild($batch)->getResult();
+        /** @var list<ResourceInterface> $result */
+        $result = $this->queryRebuilder->rebuild($batch)->getResult();
+
+        return $result;
     }
 
     private function getQueryBuilder(ChannelInterface $channel, LocaleInterface $locale): QueryBuilder

src/DependencyInjection/Compiler/RegisterFilesystemPass.php

@@ -33,6 +33,8 @@ public function process(ContainerBuilder $container): void
 
         foreach (self::PARAMETERS as $parameter) {
             $parameterValue = $container->getParameter($parameter);
+            Assert::string($parameterValue);
+
             if (!$container->hasDefinition($parameterValue)) {
                 throw new InvalidArgumentException(sprintf('No service definition exists with id "%s"', $parameterValue));
             }

src/DependencyInjection/Compiler/ValidateDataProvidersPass.php

@@ -7,6 +7,7 @@
 use InvalidArgumentException;
 use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
+use Webmozart\Assert\Assert;
 
 final class ValidateDataProvidersPass implements CompilerPassInterface
 {
@@ -23,12 +24,14 @@ public function process(ContainerBuilder $container): void
                 throw new InvalidArgumentException(sprintf('The service %s needs the code attribute. Something like this: <tag name="setono_sylius_feed.data_provider" code="insert code here"/>', $id));
             }
 
+            /** @var array{code?: string} $attributes */
             foreach ($tagged as $attributes) {
                 if (!isset($attributes['code'])) {
                     throw new InvalidArgumentException(sprintf('The service %s needs the code attribute. Something like this: <tag name="setono_sylius_feed.data_provider" code="insert code here"/>', $id));
                 }
 
                 $code = $attributes['code'];
+                Assert::string($code);
 
                 if (isset($seen[$code])) {
                     throw new InvalidArgumentException(sprintf('There is already a data provider with the given code, "%s"', $code));

src/DependencyInjection/SetonoSyliusFeedExtension.php

@@ -13,14 +13,24 @@
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\DependencyInjection\Extension\PrependExtensionInterface;
 use Symfony\Component\DependencyInjection\Loader\XmlFileLoader;
+use Webmozart\Assert\Assert;
 
 final class SetonoSyliusFeedExtension extends AbstractResourceExtension implements PrependExtensionInterface
 {
     public function load(array $configs, ContainerBuilder $container): void
     {
+        /**
+         * @var array{
+         *     driver: string,
+         *     storage: array{feed: string, feed_tmp: string},
+         *     resources: array
+         * } $config
+         */
         $config = $this->processConfiguration($this->getConfiguration([], $container), $configs);
         $loader = new XmlFileLoader($container, new FileLocator(__DIR__ . '/../Resources/config'));
 
+        Assert::isArray($config['storage']);
+
         $container->setParameter('setono_sylius_feed.storage.feed', $config['storage']['feed']);
         $container->setParameter('setono_sylius_feed.storage.feed_tmp', $config['storage']['feed_tmp']);
 

src/Doctrine/ORM/FeedRepository.php

@@ -13,12 +13,16 @@ class FeedRepository extends EntityRepository implements FeedRepositoryInterface
 {
     public function findOneByCode(string $code): ?FeedInterface
     {
-        return $this->createQueryBuilder('o')
+        $result = $this->createQueryBuilder('o')
             ->where('o.code = :code')
             ->setParameter('code', $code)
             ->getQuery()
             ->getOneOrNullResult()
         ;
+
+        Assert::nullOrIsInstanceOf($result, FeedInterface::class);
+
+        return $result;
     }
 
     public function findEnabled(): array

src/EventListener/MoveGeneratedFeedSubscriber.php

@@ -87,9 +87,8 @@ public function move(TransitionEvent $event): void
                 );
                 $temporaryFilesystem = $this->temporaryFilesystem;
                 $temporaryPath = TemporaryFeedPathGenerator::getBaseFile($temporaryDir);
-                /** @var resource|false $tempFile */
                 $tempFile = $temporaryFilesystem->readStream((string) $temporaryPath);
-                if (false === $tempFile) {
+                if (!\is_resource($tempFile)) {
                     throw new \RuntimeException(sprintf(
                         'The file with path "%s" could not be found',
                         $temporaryPath,

src/Exception/GenerateBatchException.php

@@ -14,8 +14,7 @@ final class GenerateBatchException extends RuntimeException implements Exception
 
     private ?int $feedId = null;
 
-    /** @var mixed */
-    private $resourceId;
+    private mixed $resourceId;
 
     private ?string $channelCode = null;
 
@@ -40,18 +39,12 @@ public function setFeedId(int $feedId): void
         $this->updateMessage();
     }
 
-    /**
-     * @return mixed
-     */
-    public function getResourceId()
+    public function getResourceId(): mixed
     {
         return $this->resourceId;
     }
 
-    /**
-     * @param mixed $resourceId
-     */
-    public function setResourceId($resourceId): void
+    public function setResourceId(mixed $resourceId): void
     {
         Assert::scalar($resourceId);
 

src/FeedType/FeedType.php

@@ -11,8 +11,12 @@
 
 final class FeedType implements FeedTypeInterface
 {
+    /** @var list<string> */
     private readonly array $validationGroups;
 
+    /**
+     * @param list<string> $validationGroups
+     */
     public function __construct(
         private readonly string $code,
         private readonly string $template,

src/FeedType/FeedTypeInterface.php

@@ -24,6 +24,8 @@ public function getItemContext(): ItemContextInterface;
 
     /**
      * The validation groups used when validating each item
+     *
+     * @return list<string>
      */
     public function getValidationGroups(): array;
 }