Fix the build

Author: loevgaard

.gitattributes

@@ -14,7 +14,5 @@
 /infection.json.dist                export-ignore
 /node_modules                       export-ignore
 /phpunit.xml.dist                   export-ignore
-/psalm-baseline.xml                 export-ignore
-/psalm.xml                          export-ignore
 /rector.php                         export-ignore
 /tests                              export-ignore

.gitignore

@@ -7,6 +7,8 @@
 
 /.phpunit.result.cache
 
+/.claude/*.local.json
+
 # Symfony CLI https://symfony.com/doc/current/setup/symfony_server.html#different-php-settings-per-project
 /.php-version
 /php.ini

composer-dependency-analyser.php

@@ -4,4 +4,9 @@
 
 return (new Configuration())
     ->addPathToExclude(__DIR__ . '/tests')
+    ->ignoreUnknownClasses([
+        League\Flysystem\FileNotFoundException::class,
+        League\Flysystem\FilesystemInterface::class,
+        League\Flysystem\RootViolationException::class,
+    ])
 ;

composer.json

@@ -18,12 +18,18 @@
         "setono/doctrine-orm-batcher": "^0.6",
         "setono/doctrine-orm-batcher-bundle": "^0.3.4",
         "spatie/enum": "^3.7",
+        "sylius/channel": "^1.0",
+        "sylius/channel-bundle": "^1.0",
+        "sylius/core": "^1.0",
+        "sylius/core-bundle": "^1.0",
+        "sylius/inventory": "^1.0",
+        "sylius/locale": "^1.0",
         "sylius/resource-bundle": "^1.6",
+        "sylius/ui-bundle": "^1.0",
         "symfony/config": "^6.4 || ^7.4",
         "symfony/console": "^6.4 || ^7.4",
         "symfony/dependency-injection": "^6.4 || ^7.4",
         "symfony/event-dispatcher": "^6.4 || ^7.4",
-        "symfony/event-dispatcher-contracts": "^1.1 || ^2.2 || ^3.0",
         "symfony/form": "^6.4 || ^7.4",
         "symfony/http-foundation": "^6.4 || ^7.4",
         "symfony/http-kernel": "^6.4 || ^7.4",

phpstan.neon

@@ -31,6 +31,8 @@ parameters:
             identifier: doctrine.associationType
         -
             identifier: doctrine.columnType
+        -
+            identifier: missingType.generics
         -
             identifier: missingType.generics
             path: src/Form

src/Command/ProcessFeedsCommand.php

@@ -14,13 +14,9 @@ final class ProcessFeedsCommand extends Command
 {
     protected static $defaultName = 'setono:sylius-feed:process';
 
-    private FeedProcessorInterface $feedProcessor;
-
-    public function __construct(FeedProcessorInterface $feedProcessor)
+    public function __construct(private readonly FeedProcessorInterface $feedProcessor)
     {
         parent::__construct();
-
-        $this->feedProcessor = $feedProcessor;
     }
 
     protected function configure(): void

src/Controller/Action/Admin/ProcessFeedAction.php

@@ -13,32 +13,14 @@
 use Symfony\Component\Routing\Generator\UrlGeneratorInterface;
 use Symfony\Contracts\Translation\TranslatorInterface;
 
-/**
- * @psalm-suppress UndefinedClass
- * @psalm-suppress MixedArgument
- * @psalm-suppress UndefinedInterfaceMethod
- * @psalm-suppress MixedAssignment
- */
 final class ProcessFeedAction
 {
-    private MessageBusInterface $commandBus;
-
-    private UrlGeneratorInterface $urlGenerator;
-
-    private FlashBagInterface|RequestStack $flashBag;
-
-    private TranslatorInterface $translator;
-
     public function __construct(
-        MessageBusInterface $commandBus,
-        UrlGeneratorInterface $urlGenerator,
-        FlashBagInterface|RequestStack $requestStackOrFlashBag,
-        TranslatorInterface $translator,
+        private readonly MessageBusInterface $commandBus,
+        private readonly UrlGeneratorInterface $urlGenerator,
+        private readonly FlashBagInterface|RequestStack $flashBag,
+        private readonly TranslatorInterface $translator,
     ) {
-        $this->commandBus = $commandBus;
-        $this->urlGenerator = $urlGenerator;
-        $this->flashBag = $requestStackOrFlashBag;
-        $this->translator = $translator;
     }
 
     public function __invoke(int $id): RedirectResponse

src/Controller/Action/Admin/SeverityCountAction.php

@@ -10,14 +10,10 @@
 
 final class SeverityCountAction
 {
-    private ViolationRepositoryInterface $violationRepository;
-
-    private Environment $twig;
-
-    public function __construct(ViolationRepositoryInterface $violationRepository, Environment $twig)
-    {
-        $this->violationRepository = $violationRepository;
-        $this->twig = $twig;
+    public function __construct(
+        private readonly ViolationRepositoryInterface $violationRepository,
+        private readonly Environment $twig,
+    ) {
     }
 
     public function __invoke(int $feed = null): Response

src/Controller/Action/Shop/ShowFeedAction.php

@@ -16,42 +16,22 @@
 use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
 use Symfony\Component\Mime\MimeTypesInterface;
 
-/**
- * @psalm-suppress UndefinedDocblockClass
- * @psalm-suppress UndefinedClass
- */
 final class ShowFeedAction
 {
-    private FeedRepositoryInterface $repository;
-
-    private ChannelContextInterface $channelContext;
-
-    private LocaleContextInterface $localeContext;
-
-    private FeedPathGeneratorInterface $feedPathGenerator;
-
     /** @var FilesystemInterface|FilesystemOperator */
     private $filesystem;
 
-    private MimeTypesInterface $mimeTypes;
-
     /**
-     * @psalm-suppress UndefinedDocblockClass
-     *
      * @param FilesystemInterface|FilesystemOperator $filesystem
      */
     public function __construct(
-        FeedRepositoryInterface $repository,
-        ChannelContextInterface $channelContext,
-        LocaleContextInterface $localeContext,
-        FeedPathGeneratorInterface $feedPathGenerator,
+        private readonly FeedRepositoryInterface $repository,
+        private readonly ChannelContextInterface $channelContext,
+        private readonly LocaleContextInterface $localeContext,
+        private readonly FeedPathGeneratorInterface $feedPathGenerator,
         $filesystem,
-        MimeTypesInterface $mimeTypes,
+        private readonly MimeTypesInterface $mimeTypes,
     ) {
-        $this->repository = $repository;
-        $this->channelContext = $channelContext;
-        $this->localeContext = $localeContext;
-        $this->feedPathGenerator = $feedPathGenerator;
         if (interface_exists(FilesystemInterface::class) && $filesystem instanceof FilesystemInterface) {
             $this->filesystem = $filesystem;
         } elseif ($filesystem instanceof FilesystemOperator) {
@@ -63,7 +43,6 @@ public function __construct(
                 FilesystemOperator::class,
             ));
         }
-        $this->mimeTypes = $mimeTypes;
     }
 
     public function __invoke(string $code): StreamedResponse

src/DTO/SeverityCount.php

@@ -6,14 +6,8 @@
 
 final class SeverityCount
 {
-    private string $severity;
-
-    private int $count;
-
-    public function __construct(string $severity, int $count)
+    public function __construct(private readonly string $severity, private readonly int $count)
     {
-        $this->severity = $severity;
-        $this->count = $count;
     }
 
     public function getSeverity(): string