Only create a review request if it does not already exist for the order

Author: loevgaard

composer.json

@@ -15,6 +15,7 @@
         "psr/event-dispatcher": "^1.0",
         "psr/log": "^1.1 || ^2.0 || ^3.0",
         "setono/composite-compiler-pass": "^1.1",
+        "setono/doctrine-orm-trait": "^1.0.1",
         "sylius/core": "^1.0",
         "sylius/core-bundle": "^1.0",
         "sylius/mailer-bundle": "^1.8 || ^2.0",

src/EventSubscriber/CreateReviewRequestSubscriber.php

@@ -5,18 +5,23 @@
 namespace Setono\SyliusReviewPlugin\EventSubscriber;
 
 use Doctrine\Persistence\ManagerRegistry;
+use Setono\Doctrine\ORMTrait;
 use Setono\SyliusReviewPlugin\Factory\ReviewRequestFactoryInterface;
+use Setono\SyliusReviewPlugin\Repository\ReviewRequestRepositoryInterface;
 use Sylius\Bundle\ResourceBundle\Event\ResourceControllerEvent;
 use Sylius\Component\Core\Model\OrderInterface;
 use Symfony\Component\EventDispatcher\EventSubscriberInterface;
 use Webmozart\Assert\Assert;
 
 final class CreateReviewRequestSubscriber implements EventSubscriberInterface
 {
+    use ORMTrait;
+
     public function __construct(
-        private readonly ManagerRegistry $managerRegistry,
+        ManagerRegistry $managerRegistry,
         private readonly ReviewRequestFactoryInterface $reviewRequestFactory,
     ) {
+        $this->managerRegistry = $managerRegistry;
     }
 
     public static function getSubscribedEvents(): array
@@ -34,6 +39,12 @@ public function create(ResourceControllerEvent $event): void
 
         $reviewRequest = $this->reviewRequestFactory->createFromOrder($order);
 
-        $this->managerRegistry->getManagerForClass($reviewRequest::class)?->persist($reviewRequest);
+        /** @var ReviewRequestRepositoryInterface $reviewRequestRepository */
+        $reviewRequestRepository = $this->getRepository($reviewRequest, ReviewRequestRepositoryInterface::class);
+        if ($reviewRequestRepository->hasExistingForOrder($order)) {
+            return;
+        }
+
+        $this->getManager($reviewRequest)->persist($reviewRequest);
     }
 }

src/Repository/ReviewRequestRepository.php

@@ -7,6 +7,7 @@
 use Doctrine\ORM\QueryBuilder;
 use Setono\SyliusReviewPlugin\Model\ReviewRequestInterface;
 use Sylius\Bundle\ResourceBundle\Doctrine\ORM\EntityRepository;
+use Sylius\Component\Core\Model\OrderInterface;
 
 class ReviewRequestRepository extends EntityRepository implements ReviewRequestRepositoryInterface
 {
@@ -41,4 +42,15 @@ public function removeCancelled(): void
             ->execute()
         ;
     }
+
+    public function hasExistingForOrder(OrderInterface $order): bool
+    {
+        return (int) $this->createQueryBuilder('o')
+            ->select('COUNT(o.id)')
+            ->andWhere('o.order = :order')
+            ->setParameter('order', $order)
+            ->getQuery()
+            ->getSingleScalarResult() > 0
+        ;
+    }
 }

src/Repository/ReviewRequestRepositoryInterface.php

@@ -5,6 +5,7 @@
 namespace Setono\SyliusReviewPlugin\Repository;
 
 use Doctrine\ORM\QueryBuilder;
+use Sylius\Component\Core\Model\OrderInterface;
 use Sylius\Component\Resource\Repository\RepositoryInterface;
 
 interface ReviewRequestRepositoryInterface extends RepositoryInterface
@@ -20,4 +21,6 @@ public function removeBefore(\DateTimeInterface $threshold): void;
      * Removes all review requests that are cancelled
      */
     public function removeCancelled(): void;
+
+    public function hasExistingForOrder(OrderInterface $order): bool;
 }