Actually fixing the issue with subdirectories that don't have a build file

Author: rjfioravanti

src/main/kotlin/com/faire/gradle/analyze/AnalyzeDependenciesPlugin.kt

@@ -16,6 +16,18 @@ class AnalyzeDependenciesPlugin : Plugin<Project> {
   override fun apply(project: Project) {
     val extension = project.extensions.create<AnalyzeDependenciesPluginExtension>("analyzeDependencies")
 
+    // If we have a directory that doesn't have a build-file, the analyze task is going to fail.
+    // Sometimes gradle thinks there is a project at a location with no build file.
+    // The situation I had was as follows
+    //    foo (no build file here)
+    //    foo/bar1 (has build file)
+    //    foo/bar2 (has build file)
+    //
+    // Running ./gradlew analyzeDependencies would fail at :foo:analyzeDependencies
+    if (!project.buildFile.exists()) {
+      return
+    }
+
     project.configurations.create("permitUnusedDeclared")
     project.configurations.create("permitTestUnusedDeclared")
 
@@ -37,3 +49,4 @@ class AnalyzeDependenciesPlugin : Plugin<Project> {
     }
   }
 }
+

src/main/kotlin/com/faire/gradle/analyze/AnalyzeDependenciesTask.kt

@@ -8,11 +8,11 @@ import org.gradle.api.tasks.CacheableTask
 import org.gradle.api.tasks.Input
 import org.gradle.api.tasks.InputFile
 import org.gradle.api.tasks.InputFiles
-import org.gradle.api.tasks.Optional
 import org.gradle.api.tasks.OutputFile
 import org.gradle.api.tasks.PathSensitive
 import org.gradle.api.tasks.PathSensitivity
 import org.gradle.api.tasks.TaskAction
+import java.io.File
 
 open class DependencyAnalysisException(message: String) : GradleException(message)
 
@@ -28,18 +28,8 @@ open class AnalyzeDependenciesTask : DefaultTask() {
 
   // Using the buildFile as an input so that if you change any dependencies we invalidate analysis cache.
   @InputFile
-  // Sometimes gradle thinks there is a project at a location with no build file. Use optional here to make sure
-  // it doesn't fail in those cases. It would probably be better to figure out why this was happening, but there's
-  // no time for that!
-  // The situation I had was as follows
-  //    foo (no build file here)
-  //    foo/bar1 (has build file)
-  //    foo/bar2 (has build file)
-  //
-  // Running ./gradlew analyzeDependencies would fail at :foo:analyzeDependencies
-  @Optional
   @PathSensitive(PathSensitivity.RELATIVE)
-  var buildFile = project.buildFile
+  var buildFile: File? = project.buildFile
 
   @Input
   var justWarn: Boolean = false

src/test/kotlin/com/faire/gradle/analyze/AnalyzeDependenciesPluginTest.kt

@@ -928,6 +928,51 @@ class AnalyzeDependenciesPluginTest {
 
     assertThat(result.output).contains("BUILD SUCCESSFUL")
   }
+
+  @Test
+  fun `Parent directory without a build file`() {
+    val parentDir = File(testProjectDir.root, "parent")
+    parentDir.mkdirs()
+    val moduleOne = File(parentDir, "moduleOne")
+    val moduleTwo = File(parentDir, "moduleTwo")
+    moduleOne.mkdirs()
+    moduleTwo.mkdirs()
+
+    val srcDirA = File(moduleOne, "src/main/java")
+    val srcDirB = File(moduleTwo, "src/main/java")
+    srcDirA.mkdirs()
+    srcDirB.mkdirs()
+    File(srcDirA, "AFoo.java").writeText(
+      """
+       package com.faire.a;
+       public class AFoo {
+       }
+     """.trimIndent()
+    )
+    createBuildFileWithDependencies(moduleOne, listOf())
+
+    File(srcDirB, "BFoo.java").writeText(
+      """
+       package com.faire.b;
+       import com.faire.a.AFoo;
+
+       public class BFoo {
+         BFoo(AFoo a) {}
+       }
+     """.trimIndent()
+    )
+    createBuildFileWithDependencies(moduleTwo, listOf(":parent:moduleOne"))
+
+    createGradleSettingsFileWithModuleIncludes(testProjectDir.root, listOf(":parent:moduleOne", ":parent:moduleTwo"))
+
+    val result = GradleRunner.create()
+      .withProjectDir(testProjectDir.root)
+      .withArguments("analyzeDependencies")
+      .withPluginClasspath()
+      .build()
+
+    assertThat(result.output).contains("BUILD SUCCESSFUL")
+  }
 }
 
 internal fun createGradleSettingsFileWithModuleIncludes(directory: File, modules: List<String>) {