Allow Serial::new instead of Serial::usartX

This requires changing I2C to a more generic implementation,
where the specific UART peripheral implementation get's dispatch
upon it's Instance trait.

The specific UART is longer hard coded into, but instead is referenced
via pointer (trait).

This also allows to reduce the usart macro implementation, so that
the code is easier to follow.

But this leads to code duplication, as code for the Write and Read
trait of embedded-hal can no longer be shared between Serial and Tx |
Rx.

Also, the underlying UART peripheral of Tx and Rx after split has to be
tracked at runtime, instead of being decoded at compile time (via macro).

In addition to all of this the Idle interrupt event was also added.

Author: Sh3Rm4n

CHANGELOG.md

@@ -19,6 +19,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 - `ld` feature, which enables the memory.x generation ([#216])
 - Implement `DelayMs` for `Milliseconds` and `DelayUs` for `Microseconds` ([#234])
 - ADC can now be `free()`'d ([#212])
+- Serial does now implement `embedded_hal::serial::{Read, Write}`.
+  No `split()` necessary. ([#232])
+- Serial can now listen for the "Transmission Complete" `Tc` interrupt event ([#232])
+- Serial can now listen for the `Idle` interrupt event ([#238])
 
 ### Changed
 
@@ -70,6 +74,7 @@ let clocks = rcc
 - Remove `stm32` module. Use `use stm32f3xx_hal::pac` instead.
   This module was a deprecated in [v0.5.0][] and is now subject for
   removal. ([#220])
+- `Serial::uart1` ... functions are renamed to `Serial::new`. ([#212])
 
 ## [v0.6.1] - 2020-12-10
 
@@ -325,6 +330,7 @@ let clocks = rcc
 [filter]: https://defmt.ferrous-systems.com/filtering.html
 
 [#234]: https://github.com/stm32-rs/stm32f3xx-hal/pull/234
+[#232]: https://github.com/stm32-rs/stm32f3xx-hal/pull/232
 [#229]: https://github.com/stm32-rs/stm32f3xx-hal/pull/229
 [#227]: https://github.com/stm32-rs/stm32f3xx-hal/pull/227
 [#220]: https://github.com/stm32-rs/stm32f3xx-hal/pull/220

examples/serial_dma.rs

@@ -29,7 +29,7 @@ fn main() -> ! {
             .pa10
             .into_af7_push_pull(&mut gpioa.moder, &mut gpioa.otyper, &mut gpioa.afrh),
     );
-    let serial = Serial::usart1(dp.USART1, pins, 9600.Bd(), clocks, &mut rcc.apb2);
+    let serial = Serial::new(dp.USART1, pins, 9600.Bd(), clocks, &mut rcc.apb2);
     let (tx, rx) = serial.split();
 
     let dma1 = dp.DMA1.split(&mut rcc.ahb);

examples/serial_echo_rtic.rs

@@ -64,13 +64,8 @@ mod app {
                 .into_af7_push_pull(&mut gpioa.moder, &mut gpioa.otyper, &mut gpioa.afrh),
         );
         pins.1.internal_pull_up(&mut gpioa.pupdr, true);
-        let mut serial: SerialType = Serial::usart1(
-            cx.device.USART1,
-            pins,
-            19200_u32.Bd(),
-            clocks,
-            &mut rcc.apb2,
-        );
+        let mut serial: SerialType =
+            Serial::new(cx.device.USART1, pins, 19200.Bd(), clocks, &mut rcc.apb2);
         serial.listen(Event::Rxne);
 
         rprintln!("post init");

src/gpio.rs

@@ -275,6 +275,9 @@ pub struct Pin<Gpio, Index, Mode> {
     _mode: PhantomData<Mode>,
 }
 
+// Make all GPIO peripheral trait extensions sealable.
+impl<Gpio, Index, Mode> crate::private::Sealed for Pin<Gpio, Index, Mode> {}
+
 /// Fully erased pin
 ///
 /// This moves the pin type information to be known

src/lib.rs

@@ -203,3 +203,9 @@ cfg_if! {
         }
     }
 }
+
+mod private {
+    /// Private sealed trait to seal all GPIO implementations
+    /// which do implement peripheral functionalities.
+    pub trait Sealed {}
+}