fix: Ban/Mute game client DC

AscensionGameDev#2787

Author: Sh4d0v

Intersect.Client.Core/Interface/Game/Admin/BanMuteBox.cs

@@ -8,7 +8,7 @@ namespace Intersect.Client.Interface.Game.Admin;
 public partial class BanMuteBox : WindowControl
 {
     private readonly TextBox _textboxReason;
-    private readonly ComboBox? _comboboxDuration;
+    private readonly ComboBox _comboboxDuration;
     private readonly LabeledCheckBox _checkboxIP;
 
     private static readonly List<(string Label, int Days)> _durationOptions = new()
@@ -24,7 +24,7 @@ public partial class BanMuteBox : WindowControl
         (Strings.BanMute.TwoMonths, 60),
         (Strings.BanMute.SixMonths, 180),
         (Strings.BanMute.OneYear, 365),
-        (Strings.BanMute.Forever, int.MaxValue),
+        (Strings.BanMute.Forever, 999999),
     };
 
     public BanMuteBox(string title, string prompt, EventHandler okayHandler) : base(
@@ -79,14 +79,14 @@ public BanMuteBox(string title, string prompt, EventHandler okayHandler) : base(
         buttonOkay.Clicked += (s, e) =>
         {
             okayHandler?.Invoke(this, EventArgs.Empty);
-            Close();
+            DelayedDelete();
         };
 
         var buttonCancel = new Button(this, "ButtonCancel")
         {
             Text = Strings.BanMute.Cancel,
         };
-        buttonCancel.Clicked += (s, e) => Close();
+        buttonCancel.Clicked += (s, e) => DelayedDelete();
 
         LoadJsonUi(UI.InGame, Graphics.Renderer?.GetResolutionString(), true);
 

Intersect.Client.Framework/Gwen/Control/Canvas.cs

@@ -262,21 +262,42 @@ public void AddDelayedDelete(Base control)
 
     private void ProcessDelayedDeletes()
     {
+        List<IDisposable> controlsToDispose;
+
         lock (_disposeQueue)
         {
-            foreach (var control in _disposeQueue)
+            if (_disposeQueue.Count == 0)
             {
+                return;
+            }
+
+            controlsToDispose = new List<IDisposable>(_disposeQueue);
+            _disposeQueue.Clear();
+
 #if DEBUG
-                if (control is Base node)
-                {
-                    _delayedDeleteStackTraces.Remove(node);
-                }
+            // Remove all the stuff from debug tracking in one go
+            _delayedDeleteStackTraces.Clear();
 #endif
+        }
 
+        // Dispose outside the lock
+        foreach (var control in controlsToDispose)
+        {
+            try
+            {
                 control.Dispose();
             }
-
-            _disposeQueue.Clear();
+            catch (ObjectDisposedException)
+            {
+                // Already disposed, ignore
+            }
+            catch (Exception ex)
+            {
+                ApplicationContext.Context.Value?.Logger.LogError(
+                    ex,
+                    "Error disposing control during ProcessDelayedDeletes"
+                );
+            }
         }
     }
 
@@ -462,4 +483,4 @@ public bool Input_MouseWheel(int val)
         return InputHandler.HoveredControl.InputMouseWheeled(val);
     }
 
-}
+}