Revise isLocalToCompilationUnit (scala#24856)

Previously, public constructors or members of private classes were not
considered local to a compilation unit. Now they are.

Author: mbovel

compiler/src/dotty/tools/dotc/core/SymDenotations.scala

@@ -1247,12 +1247,12 @@ object SymDenotations {
       || isClass
         && (!isOneOf(EffectivelyOpenFlags) || isLocalToCompilationUnit)
 
-    final def isLocalToCompilationUnitIgnoringPrivate(using Context): Boolean =
-      owner.ownersIterator.takeWhile(!_.isStaticOwner).exists(_.isTerm)
-      || accessBoundary(defn.RootClass).isProperlyContainedIn(symbol.topLevelClass)
-
+    /** Is symbol visible only in the current compilation unit? */
     final def isLocalToCompilationUnit(using Context): Boolean =
-      is(Private) || isLocalToCompilationUnitIgnoringPrivate
+      is(Private)
+      || owner.isTerm
+      || privateWithin.exists && !privateWithin.is(Package)
+      || !owner.is(Package) && owner.isLocalToCompilationUnit
 
     final def isTransparentClass(using Context): Boolean =
       is(TransparentType) || defn.isAssumedTransparent(symbol)

tests/generic-java-signatures/outer-ref-elimination.check

@@ -7,5 +7,5 @@ List(public T6$$anon$3$C6())
 List(public T7$C7$1())
 List(public T8$$anon$4$C8())
 List(public T9$C9$1(T9))
-List(public T10$C10(T10))
+List(public T10$C10())
 List(public T11$D11$C11())