minor corrections: replace -1 with symbolic value ERA_NOT_DEFINED.

Author: thsc42

src/net/sharksystem/asap/protocol/ASAP_Modem_Impl.java

@@ -32,19 +32,17 @@ public void offer(CharSequence peer, CharSequence format, CharSequence channel,
 
     @Override
     public void interest(CharSequence peer, CharSequence sourcePeer, CharSequence format,
-                         CharSequence channel, int eraFrom, int eraTo, OutputStream os, boolean signed)
+            CharSequence channel, int eraFrom, int eraTo, OutputStream os, boolean signed)
             throws IOException, ASAPException {
 
-        // TODO - should throw an exception!
-        //if(eraFrom < 0 || eraTo < 0) throw new ASAPException("era must be a non-negative value: from|to): " + eraFrom + "|" + eraTo);
         InterestPDU_Impl.sendPDU(peer, sourcePeer, format, channel, eraFrom, eraTo, os, signed);
     }
 
     @Override
     public void interest(CharSequence peer, CharSequence sourcePeer, CharSequence format,
                          CharSequence channel, OutputStream os, boolean signed) throws IOException, ASAPException {
 
-        this.interest(peer, sourcePeer, format, channel, -1, -1, os, signed);
+        this.interest(peer, sourcePeer, format, channel, ERA_NOT_DEFINED, ERA_NOT_DEFINED, os, signed);
     }
 
     @Override

src/net/sharksystem/asap/protocol/PDU_Impl.java

@@ -9,7 +9,7 @@
 
 import static net.sharksystem.asap.protocol.ASAP_1_0.ERA_NOT_DEFINED;
 
-abstract class PDU_Impl implements ASAP_PDU_1_0{
+abstract class PDU_Impl implements ASAP_PDU_1_0 {
     public static final int PEER_BIT_POSITION = 0;
     public static final int CHANNEL_BIT_POSITION = 1;
     public static final int ERA_BIT_POSITION = 2;
@@ -300,6 +300,7 @@ static void checkValidFormat(CharSequence format) throws ASAPException {
     static void checkValidEra(int era) throws ASAPException {
         if(era < -1) throw new ASAPException("era cannot be smaller than -1");
         int maxEra = Integer.MAX_VALUE;
+        // that's impossible but ... never change a running system...
         if(era > maxEra) throw new ASAPException("era exceeded max limit of " + Integer.MAX_VALUE);
     }