Unify filter wheel config: profile URI as source of truth, equipment tab editing

All filter wheel drivers now read name/offset from URI query params first,
with driver-specific fallbacks per slot (COM for ASCOM, REST API for Alpaca,
presets for Fake, InstalledFilter for Manual). Slot count always comes from
hardware/preset, not URI scanning.

- ASCOM: URI params override COM Names[]/FocusOffsets[] per slot
- Alpaca: URI params override API names/focusoffsets; add GetStringArrayAsync/
  GetIntArrayAsync to AlpacaClient; ReadFilterConfigAsync populates on connect
- Fake: per-device-ID presets (LRGB/Narrowband/Simple), max 8 slots
- Manual: reads name+offset from URI (single slot)
- EquipmentActions: add GetFilterConfig, SetFilterConfig, UpdateOTA helpers
- VkEquipmentTab: filter table (expand/collapse, name cycle, offset stepper,
  add/remove capped at 8) and OTA property editors (name, focal length,
  aperture, optical design cycle)
- PlannerActions.BuildSchedule: pass availableFilters and opticalDesign from
  active profile to ObservationScheduler

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: sebgod

TODO.md

@@ -2,8 +2,10 @@
 
 ## Next Up
 
-- [ ] Fake filter wheels should have pre-installed filters (realistic filter sets per device ID)
+- [x] Fake filter wheels should have pre-installed filters (realistic filter sets per device ID)
 - [ ] Pinned items in planner should persist to disk (`<CommonDataRoot>/Sessions/Uncommitted.json`) so they survive app restarts while not yet committed to a planned session
+- [ ] Seed focuser `MaxStep` from hardware during ZWO EAF discovery (same `seedQueryParams` pattern as EFW slot count)
+- [ ] Remember last focus position in profile URI after auto-focus (save after every auto-focus attempt, whether successful or not) so the focuser can start near the last known good position on next session
 
 ## Observation Scheduler (PLAN-SessionTests.md)
 
@@ -95,7 +97,7 @@
 
 - [ ] Query tracking rates from Alpaca when endpoint supports enumeration (`AlpacaTelescopeDriver.cs:46`)
 - [ ] Parse axis rates from Alpaca response (`AlpacaTelescopeDriver.cs:315`)
-- [ ] Implement string[] and int[] typed getters for filter names and focus offsets (`AlpacaFilterWheelDriver.cs:30`)
+- [x] Implement string[] and int[] typed getters for filter names and focus offsets (`AlpacaClient.cs`)
 - [ ] Parse string[] from Alpaca for `Offsets` (`AlpacaCameraDriver.cs:238`)
 - [ ] Parse string[] from Alpaca for `Gains` (`AlpacaCameraDriver.cs:248`)
 - [ ] Alpaca `imagearray` endpoint requires special binary handling (`AlpacaCameraDriver.cs:258`)
@@ -154,7 +156,7 @@ Learnings from PixInsight Statistical Stretch (SetiAstro, v2.3).
 - [x] Annotation overlay (object names from catalogs when plate-solved)
 - [x] Star detection overlay: `FitsDocument.DetectStarsAsync()` runs as background task,
       draws HFD-sized green circles, shows count/HFR/FWHM in status bar (S key toggle)
-- [ ] Clip star overlay circles to image viewport (currently drawn over toolbar, file list, and info panel)
+- [x] Clip star overlay circles to image viewport + fix centroid alignment (+0.5px offset)
 - [ ] Remember last opened folder and recent images across sessions
 - [ ] Continuous image advance when holding arrow keys (advance every ~1 second while pressed)
 - [ ] Display original bit depth before normalization (e.g. "16-bit" in status bar) when available from FITS header

src/TianWen.Lib/Devices/Alpaca/AlpacaClient.cs

@@ -113,6 +113,30 @@ public async Task<double> GetDoubleAsync(string baseUrl, string deviceType, int
         return result.Value;
     }
 
+    /// <summary>
+    /// GET a string array property (e.g. filterwheel/filternames).
+    /// </summary>
+    public async Task<string[]?> GetStringArrayAsync(string baseUrl, string deviceType, int deviceNumber, string endpoint, CancellationToken cancellationToken = default)
+    {
+        var url = BuildGetUrl(baseUrl, deviceType, deviceNumber, endpoint);
+        using var response = await httpClient.GetAsync(url, cancellationToken);
+        var result = await DeserializeResponseAsync(response, AlpacaJsonSerializerContext.Default.AlpacaResponseStringArray, cancellationToken);
+        ThrowOnError(result.ErrorNumber, result.ErrorMessage);
+        return result.Value;
+    }
+
+    /// <summary>
+    /// GET an integer array property (e.g. filterwheel/focusoffsets).
+    /// </summary>
+    public async Task<int[]?> GetIntArrayAsync(string baseUrl, string deviceType, int deviceNumber, string endpoint, CancellationToken cancellationToken = default)
+    {
+        var url = BuildGetUrl(baseUrl, deviceType, deviceNumber, endpoint);
+        using var response = await httpClient.GetAsync(url, cancellationToken);
+        var result = await DeserializeResponseAsync(response, AlpacaJsonSerializerContext.Default.AlpacaResponseInt32Array, cancellationToken);
+        ThrowOnError(result.ErrorNumber, result.ErrorMessage);
+        return result.Value;
+    }
+
     /// <summary>
     /// PUT (invoke a method) on an Alpaca device endpoint with form-encoded parameters.
     /// </summary>

src/TianWen.Lib/Devices/Alpaca/AlpacaFilterWheelDriver.cs

@@ -25,8 +25,44 @@ public async Task BeginMoveAsync(int position, CancellationToken cancellationTok
         }
     }
 
+    private string[]? _names;
+    private int[]? _focusOffsets;
+
     public IReadOnlyList<InstalledFilter> Filters
     {
-        get => []; // TODO: implement string[] and int[] typed getters for filter names and focus offsets
+        get
+        {
+            // Slot count is authoritative from the Alpaca API (populated on connect)
+            if (_names is not { Length: > 0 } names)
+            {
+                return [];
+            }
+
+            var query = _device.Query;
+            var offsets = _focusOffsets;
+            var filters = new List<InstalledFilter>(names.Length);
+
+            for (var i = 0; i < names.Length; i++)
+            {
+                // URI query params override API values per slot (profile is source of truth)
+                var uriName = query[DeviceQueryKeyExtensions.FilterKey(i + 1)];
+                var name = uriName ?? names[i];
+                var offset = int.TryParse(query[DeviceQueryKeyExtensions.FilterOffsetKey(i + 1)], out var o)
+                    ? o
+                    : (offsets is not null && i < offsets.Length ? offsets[i] : 0);
+                filters.Add(new InstalledFilter(name, offset));
+            }
+
+            return filters;
+        }
+    }
+
+    /// <summary>
+    /// Reads filter names and focus offsets from the Alpaca API after connecting.
+    /// </summary>
+    internal async Task ReadFilterConfigAsync(CancellationToken cancellationToken)
+    {
+        _names = await Client.GetStringArrayAsync(BaseUrl, AlpacaDeviceType, AlpacaDeviceNumber, "names", cancellationToken);
+        _focusOffsets = await Client.GetIntArrayAsync(BaseUrl, AlpacaDeviceType, AlpacaDeviceNumber, "focusoffsets", cancellationToken);
     }
 }

src/TianWen.Lib/Devices/Ascom/AscomFilterWheelDriver.cs

@@ -41,12 +41,23 @@ public IReadOnlyList<InstalledFilter> Filters
     {
         get
         {
+            var query = _device.Query;
+
+            // Determine slot count: COM driver is authoritative, URI params as fallback
             var names = Names;
             var offsets = FocusOffsets;
-            var filters = new List<InstalledFilter>(names.Length);
-            for (var i = 0; i < names.Length; i++)
+            var slotCount = names.Length;
+
+            var filters = new List<InstalledFilter>(slotCount);
+            for (var i = 0; i < slotCount; i++)
             {
-                filters.Add(new InstalledFilter(names[i], i < offsets.Length ? offsets[i] : 0));
+                // URI query params override COM values per slot (profile is source of truth)
+                var uriName = query[DeviceQueryKeyExtensions.FilterKey(i + 1)];
+                var name = uriName ?? names[i];
+                var offset = int.TryParse(query[DeviceQueryKeyExtensions.FilterOffsetKey(i + 1)], out var o)
+                    ? o
+                    : (i < offsets.Length ? offsets[i] : 0);
+                filters.Add(new InstalledFilter(name, offset));
             }
 
             return filters;

src/TianWen.Lib/Devices/Fake/FakeFilterWheelDriver.cs

@@ -1,3 +1,4 @@
+using System;
 using System.Collections.Generic;
 using System.Threading;
 using System.Threading.Tasks;
@@ -6,24 +7,44 @@ namespace TianWen.Lib.Devices.Fake;
 
 internal sealed class FakeFilterWheelDriver(FakeDevice fakeDevice, IExternal external) : FakePositionBasedDriver(fakeDevice, external), IFilterWheelDriver
 {
-    private static readonly IReadOnlyList<InstalledFilter> DefaultFilters =
+    // Per-device-ID presets (1-based ID, mod 3)
+    private static readonly IReadOnlyList<InstalledFilter> LrgbFilters =
     [
         new InstalledFilter("Luminance"),
-        new InstalledFilter("H-Alpha + OIII", +11),
         new InstalledFilter("Red", +20),
         new InstalledFilter("Green"),
-        new InstalledFilter("Blue", -15),
-        new InstalledFilter("SII", +25),
+        new InstalledFilter("Blue", -15)
+    ];
+
+    private static readonly IReadOnlyList<InstalledFilter> NarrowbandFilters =
+    [
+        new InstalledFilter("Luminance"),
         new InstalledFilter("H-Alpha", +21),
-        new InstalledFilter("OIII", -3)
+        new InstalledFilter("OIII", -3),
+        new InstalledFilter("SII", +25),
+        new InstalledFilter("Red", +20),
+        new InstalledFilter("Green"),
+        new InstalledFilter("Blue", -15)
     ];
 
+    private static readonly IReadOnlyList<InstalledFilter> SimpleFilters =
+    [
+        new InstalledFilter("Luminance"),
+        new InstalledFilter("Red", +20),
+        new InstalledFilter("Green")
+    ];
+
+    private static readonly IReadOnlyList<IReadOnlyList<InstalledFilter>> Presets = [LrgbFilters, NarrowbandFilters, SimpleFilters];
+
+    internal const int MaxSlots = 8;
+
+    internal static IReadOnlyList<InstalledFilter> GetDefaultFiltersForId(int id) => Presets[(id - 1) % Presets.Count];
+
     private IReadOnlyList<InstalledFilter>? _filters;
 
     /// <summary>
-    /// Reads filter names and focus offsets from the device URI query parameters
-    /// (filter1, offset1, filter2, offset2, ...), same as the ZWO driver.
-    /// Falls back to a default 8-slot wheel when no query params are present.
+    /// Slot count is determined by the per-device-ID preset (max 8 slots).
+    /// URI query params (filter1, offset1, ...) override names and offsets per slot.
     /// </summary>
     public IReadOnlyList<InstalledFilter> Filters
     {
@@ -35,21 +56,18 @@ public IReadOnlyList<InstalledFilter> Filters
             }
 
             var query = _fakeDevice.Query;
-            var filters = new List<InstalledFilter>();
+            var defaults = GetDefaultFiltersForId(Math.Max(1, FakeCameraDriver.ExtractId(_fakeDevice.DeviceUri)));
+            var slotCount = defaults.Count;
+            var filters = new List<InstalledFilter>(slotCount);
 
-            for (var i = 1; ; i++)
+            for (var i = 0; i < slotCount; i++)
             {
-                var name = query[DeviceQueryKeyExtensions.FilterKey(i)];
-                if (name is null)
-                {
-                    break;
-                }
-
-                var offset = int.TryParse(query[DeviceQueryKeyExtensions.FilterOffsetKey(i)], out var o) ? o : 0;
+                var name = query[DeviceQueryKeyExtensions.FilterKey(i + 1)] ?? defaults[i].Filter.Name;
+                var offset = int.TryParse(query[DeviceQueryKeyExtensions.FilterOffsetKey(i + 1)], out var o) ? o : defaults[i].Position;
                 filters.Add(new InstalledFilter(name, offset));
             }
 
-            _filters = filters.Count > 0 ? filters : DefaultFilters;
+            _filters = filters;
             return _filters;
         }
     }

src/TianWen.Lib/Devices/ManualFilterWheelDriver.cs

@@ -15,7 +15,17 @@ internal sealed class ManualFilterWheelDriver(ManualFilterWheelDevice device, IE
 {
     private bool _connected;
 
-    public IReadOnlyList<InstalledFilter> Filters => [new InstalledFilter(device.InstalledFilter)];
+    public IReadOnlyList<InstalledFilter> Filters
+    {
+        get
+        {
+            // Single slot — name and offset from URI query params (profile is source of truth)
+            var query = device.Query;
+            var name = query[DeviceQueryKeyExtensions.FilterKey(1)] ?? device.InstalledFilter.Name;
+            var offset = int.TryParse(query[DeviceQueryKeyExtensions.FilterOffsetKey(1)], out var o) ? o : 0;
+            return [new InstalledFilter(name, offset)];
+        }
+    }
 
     public ValueTask<int> GetPositionAsync(CancellationToken cancellationToken = default)
         => ValueTask.FromResult(0);

src/TianWen.UI.Abstractions/EquipmentActions.cs

@@ -1,4 +1,5 @@
 using System;
+using System.Collections.Generic;
 using System.Collections.Immutable;
 using System.Globalization;
 using System.Threading;
@@ -202,6 +203,124 @@ public static string DeviceLabel(Uri? uri, IDeviceUriRegistry? registry)
         return path.Length > 0 ? path : uri.ToString();
     }
 
+    /// <summary>
+    /// Reads filter config from a filter wheel URI's query params.
+    /// Returns the list of installed filters (may be empty if no filter{N} params present).
+    /// </summary>
+    public static IReadOnlyList<InstalledFilter> GetFilterConfig(ProfileData data, int otaIndex)
+    {
+        if (otaIndex < 0 || otaIndex >= data.OTAs.Length)
+        {
+            return [];
+        }
+
+        var fwUri = data.OTAs[otaIndex].FilterWheel;
+        if (fwUri is null || fwUri == NoneDevice.Instance.DeviceUri)
+        {
+            return [];
+        }
+
+        var query = HttpUtility.ParseQueryString(fwUri.Query);
+        var filters = new List<InstalledFilter>();
+
+        for (var i = 1; ; i++)
+        {
+            var name = query[DeviceQueryKeyExtensions.FilterKey(i)];
+            if (name is null)
+            {
+                break;
+            }
+
+            var offset = int.TryParse(query[DeviceQueryKeyExtensions.FilterOffsetKey(i)], out var o) ? o : 0;
+            filters.Add(new InstalledFilter(name, offset));
+        }
+
+        return filters;
+    }
+
+    /// <summary>
+    /// Returns new ProfileData with the filter wheel URI's query params updated to reflect the given filters.
+    /// Preserves other query params on the URI.
+    /// </summary>
+    public static ProfileData SetFilterConfig(ProfileData data, int otaIndex, IReadOnlyList<InstalledFilter> filters)
+    {
+        if (otaIndex < 0 || otaIndex >= data.OTAs.Length)
+        {
+            return data;
+        }
+
+        var ota = data.OTAs[otaIndex];
+        var fwUri = ota.FilterWheel;
+        if (fwUri is null || fwUri == NoneDevice.Instance.DeviceUri)
+        {
+            return data;
+        }
+
+        var query = HttpUtility.ParseQueryString(fwUri.Query);
+
+        // Remove existing filter/offset params
+        for (var i = 1; ; i++)
+        {
+            var key = DeviceQueryKeyExtensions.FilterKey(i);
+            if (query[key] is null)
+            {
+                break;
+            }
+            query.Remove(key);
+            query.Remove(DeviceQueryKeyExtensions.FilterOffsetKey(i));
+        }
+
+        // Write new filter/offset params
+        for (var i = 0; i < filters.Count; i++)
+        {
+            query[DeviceQueryKeyExtensions.FilterKey(i + 1)] = filters[i].Filter.Name;
+            query[DeviceQueryKeyExtensions.FilterOffsetKey(i + 1)] = filters[i].Position.ToString(CultureInfo.InvariantCulture);
+        }
+
+        var builder = new UriBuilder(fwUri) { Query = query.ToString() };
+        var updatedOta = ota with { FilterWheel = builder.Uri };
+        return data with { OTAs = data.OTAs.SetItem(otaIndex, updatedOta) };
+    }
+
+    /// <summary>
+    /// Returns new ProfileData with the OTA at the given index updated with the provided properties.
+    /// Only non-null parameters are applied.
+    /// </summary>
+    public static ProfileData UpdateOTA(
+        ProfileData data,
+        int otaIndex,
+        string? name = null,
+        int? focalLength = null,
+        int? aperture = null,
+        OpticalDesign? opticalDesign = null)
+    {
+        if (otaIndex < 0 || otaIndex >= data.OTAs.Length)
+        {
+            return data;
+        }
+
+        var ota = data.OTAs[otaIndex];
+
+        if (name is not null)
+        {
+            ota = ota with { Name = name };
+        }
+        if (focalLength is not null)
+        {
+            ota = ota with { FocalLength = focalLength.Value };
+        }
+        if (aperture is not null)
+        {
+            ota = ota with { Aperture = aperture.Value > 0 ? aperture.Value : null };
+        }
+        if (opticalDesign is not null)
+        {
+            ota = ota with { OpticalDesign = opticalDesign.Value };
+        }
+
+        return data with { OTAs = data.OTAs.SetItem(otaIndex, ota) };
+    }
+
     /// <summary>
     /// Extracts site coordinates from a mount URI, if present.
     /// </summary>

src/TianWen.UI.Abstractions/PlannerActions.cs

@@ -916,7 +916,9 @@ public static void BuildSchedule(
         int defaultGain,
         int defaultOffset,
         TimeSpan defaultSubExposure,
-        TimeSpan defaultObservationTime)
+        TimeSpan defaultObservationTime,
+        IReadOnlyList<InstalledFilter>? availableFilters = null,
+        OpticalDesign opticalDesign = OpticalDesign.Unknown)
     {
         if (state.Proposals.Count == 0)
         {
@@ -934,7 +936,9 @@ public static void BuildSchedule(
             defaultGain,
             defaultOffset,
             defaultSubExposure,
-            defaultObservationTime);
+            defaultObservationTime,
+            availableFilters: availableFilters,
+            opticalDesign: opticalDesign);
 
         state.NeedsRedraw = true;
     }