Wire SignalBus for text input activation (Phase 1)

Replace OnActivateTextInput callback and PendingCustomActivation hack
with ActivateTextInputSignal/DeactivateTextInputSignal posted via the
signal bus. Signals are delivered in OnPostFrame, after event handling
completes — no more timing conflicts with HandleMouseDown.

- Create SignalBus in Program.cs, pass through VkGuiRenderer to all tabs
- Subscribe ActivateTextInput/DeactivateTextInput handlers in Program.cs
- Add bus.ProcessPending(tracker) to OnPostFrame
- Delete OnActivateTextInput callback from VkEquipmentTab
- Delete PendingCustomActivation from EquipmentTabState
- Remove previousActiveTextInput hack from GuiEventHandlers
- Bump DIR.Lib to 1.3.71

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: sebgod

nupkgs/DIR.Lib.1.3.71.nupkg

@@ -40,7 +40,7 @@
     <PackageVersion Include="Pastel" Version="7.0.1" />
     <PackageVersion Include="System.CommandLine" Version="2.0.5" />
     <!-- SDL3 + Vulkan packages -->
-    <PackageVersion Include="DIR.Lib" Version="1.3.70" />
+    <PackageVersion Include="DIR.Lib" Version="1.3.71" />
     <PackageVersion Include="Console.Lib" Version="1.4.93" />
     <PackageVersion Include="SdlVulkan.Renderer" Version="1.1.67" />
     <PackageVersion Include="SDL3-CS" Version="3.5.0-preview.20260213-150035" />

src/Directory.Packages.props

@@ -67,8 +67,6 @@ public void StopEditingFilters()
     public int CustomFilterSlotIndex { get; set; } = -1;
     public TextInputState CustomFilterNameInput { get; } = new() { Placeholder = "Filter name..." };
 
-    /// <summary>When true, the next render frame should activate the custom filter name input.</summary>
-    public bool PendingCustomActivation { get; set; }
 
     // OTA property editing: which OTA is being edited (-1 = none)
     public int EditingOtaIndex { get; set; } = -1;

src/TianWen.UI.Gui/EquipmentTabState.cs

@@ -344,12 +344,6 @@ public GuiEventHandlers(
                 }
             };
 
-            guiRenderer.EquipmentTab.OnActivateTextInput = (textInput) =>
-            {
-                appState.ActiveTextInput = textInput;
-                StartTextInput(sdlWindowHandle);
-            };
-
             // ---------------------------------------------------------------
             // Local helpers captured by closures above
             // ---------------------------------------------------------------
@@ -410,9 +404,6 @@ public bool HandleMouseDown(float px, float py, byte clicks = 1)
                 return true;
             }
 
-            // Remember active text input before dispatch — callbacks may activate a new one
-            var previousActiveTextInput = _appState.ActiveTextInput;
-
             // If chrome didn't handle it, try the active tab
             if (hit is null)
             {
@@ -438,16 +429,8 @@ public bool HandleMouseDown(float px, float py, byte clicks = 1)
                 return true;
             }
 
-            // If a callback activated a new text input during dispatch, ensure SDL focus
-            if (_appState.ActiveTextInput is { IsActive: true } newInput
-                && newInput != previousActiveTextInput)
-            {
-                StartTextInput(_sdlWindowHandle);
-            }
-            // Clicking outside text input → deactivate (unless a callback just activated a new one)
-            else if (_appState.ActiveTextInput is { IsActive: true } activeInput
-                && activeInput == previousActiveTextInput
-                && hit is not HitResult.TextInputHit)
+            // Clicking outside text input → deactivate
+            if (_appState.ActiveTextInput is { IsActive: true } && hit is not HitResult.TextInputHit)
             {
                 DeactivateTextInput();
             }

src/TianWen.UI.Gui/GuiEventHandlers.cs

@@ -2,6 +2,7 @@
 using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.Logging;
 using SdlVulkan.Renderer;
+using static SDL3.SDL;
 using TianWen.Lib.Devices;
 using TianWen.Lib.Extensions;
 using TianWen.Lib.Sequencing;
@@ -65,7 +66,8 @@
 var ctx = VulkanContext.Create(sdlWindow.Instance, sdlWindow.Surface, (uint)pixW, (uint)pixH);
 var renderer = new VkRenderer(ctx, (uint)pixW, (uint)pixH);
 
-var guiRenderer = new VkGuiRenderer(renderer, (uint)pixW, (uint)pixH)
+var bus = new SignalBus();
+var guiRenderer = new VkGuiRenderer(renderer, (uint)pixW, (uint)pixH, bus)
 {
     DpiScale = sdlWindow.DisplayScale
 };
@@ -74,6 +76,30 @@
 var cts = new CancellationTokenSource();
 var tracker = new BackgroundTaskTracker();
 var handlers = new GuiEventHandlers(sp, appState, plannerState, guiRenderer, sdlWindow.Handle, cts, external, tracker);
+
+// Signal subscriptions — text input activation/deactivation via SDL
+bus.Subscribe<ActivateTextInputSignal>(sig =>
+{
+    if (appState.ActiveTextInput is { } prev && prev != sig.Input)
+    {
+        prev.Deactivate();
+    }
+    sig.Input.Activate();
+    appState.ActiveTextInput = sig.Input;
+    StartTextInput(sdlWindow.Handle);
+    appState.NeedsRedraw = true;
+});
+
+bus.Subscribe<DeactivateTextInputSignal>(_ =>
+{
+    if (appState.ActiveTextInput is { IsActive: true } active)
+    {
+        active.Deactivate();
+        appState.ActiveTextInput = null;
+        StopTextInput(sdlWindow.Handle);
+        appState.NeedsRedraw = true;
+    }
+});
 Task? plannerTask = null;
 
 // Wire tab callbacks that need DI/profile access
@@ -239,6 +265,7 @@ await PlannerActions.ComputeTonightsBestAsync(
 
     OnPostFrame = () =>
     {
+        bus.ProcessPending(tracker);
         tracker.ProcessCompletions(logger);
         appState.NeedsRedraw = false;
         plannerState.NeedsRedraw = false;

src/TianWen.UI.Gui/Program.cs

@@ -77,8 +77,7 @@ public sealed class VkEquipmentTab : VkTabBase
         /// <summary>Callback for updating profile data (filter config, OTA props). Set by the host.</summary>
         public Func<ProfileData, Task>? OnUpdateProfile { get; set; }
 
-        /// <summary>Callback to activate a text input with SDL focus. Set by the host.</summary>
-        public Action<TextInputState>? OnActivateTextInput { get; set; }
+        // OnActivateTextInput removed — use PostSignal(new ActivateTextInputSignal(...)) instead
 
         public VkEquipmentTab(VkRenderer renderer) : base(renderer)
         {
@@ -834,13 +833,6 @@ private float RenderFilterTable(
                 if (State.CustomFilterSlotIndex == f)
                 {
                     RenderTextInput(State.CustomFilterNameInput, (int)nameCellX, (int)cursor, (int)nameColW, (int)rowH, fontPath, fontSize * 0.8f);
-                    // Deferred activation — happens on the first render frame after Custom... was clicked
-                    if (State.PendingCustomActivation)
-                    {
-                        State.PendingCustomActivation = false;
-                        State.CustomFilterNameInput.Activate();
-                        OnActivateTextInput?.Invoke(State.CustomFilterNameInput);
-                    }
                 }
                 else
                 {
@@ -867,8 +859,8 @@ private float RenderFilterTable(
                                 var preservedName = capturedF < filters.Count && filters[capturedF].CustomName is { } cn ? cn : "";
                                 State.CustomFilterNameInput.Text = preservedName;
                                 State.CustomFilterNameInput.CursorPos = preservedName.Length;
-                                // Defer activation to next render frame to avoid HandleMouseDown interference
-                                State.PendingCustomActivation = true;
+                                // Signal deferred text input activation (processed in OnPostFrame)
+                                PostSignal(new ActivateTextInputSignal(State.CustomFilterNameInput));
                             },
                             customEntryLabel: existingCustom is { Length: > 0 } ? $"Custom: {existingCustom}" : null);
                     });

src/TianWen.UI.Gui/VkEquipmentTab.cs

@@ -72,14 +72,15 @@ private static readonly (string Icon, GuiTab Tab)[] SidebarTabs =
         private static readonly RGBAColor32 ContentBg     = new RGBAColor32(0x16, 0x16, 0x1e, 0xff);
         private static readonly RGBAColor32 PlaceholderText = new RGBAColor32(0x55, 0x55, 0x66, 0xff);
 
-        public VkGuiRenderer(VkRenderer renderer, uint width, uint height) : base(renderer)
+        public VkGuiRenderer(VkRenderer renderer, uint width, uint height, SignalBus? bus = null) : base(renderer)
         {
+            Bus = bus;
             _renderer = renderer;
             _width = width;
             _height = height;
-            _plannerTab = new VkPlannerTab(renderer);
-            _equipmentTab = new VkEquipmentTab(renderer);
-            _sessionTab = new VkSessionTab(renderer);
+            _plannerTab = new VkPlannerTab(renderer) { Bus = bus };
+            _equipmentTab = new VkEquipmentTab(renderer) { Bus = bus };
+            _sessionTab = new VkSessionTab(renderer) { Bus = bus };
             ResolveFontPath();
         }