Skip to content

Commit 26e9a38

Browse files
committed
Update outdated comments
1 parent 994cbc0 commit 26e9a38

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

KillTrack.lua

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -278,7 +278,7 @@ function KT.Events.COMBAT_LOG_EVENT_UNFILTERED(self)
278278
local _, event, _, s_guid, _, _, _, d_guid, d_name, _, _ = CombatLogGetCurrentEventInfo()
279279
if combat_log_damage_events[event] then
280280
if FirstDamage[d_guid] == nil then
281-
-- s_name is (probably) the player who first damaged this mob and probably has the tag
281+
-- s_guid is (probably) the player who first damaged this mob and probably has the tag
282282
FirstDamage[d_guid] = s_guid
283283
end
284284

@@ -313,8 +313,7 @@ function KT.Events.COMBAT_LOG_EVENT_UNFILTERED(self)
313313
local lastByPlayer = lastDamage == self.PlayerGUID or lastDamage == UnitGUID("pet")
314314
local pass
315315

316-
-- All checks after DamageValid should be safe to remove
317-
-- The checks after DamageValid are also not 100% failsafe
316+
-- The checks after DamageValid are not 100% failsafe
318317
-- Scenario: You deal the killing blow to an already tapped mob <- Would count as kill with current code
319318

320319
-- if DamageValid[guid] is set, it can be used to decide if the kill was valid with 100% certainty

0 commit comments

Comments
 (0)