Skip to content

Toggle js_errors key via env var JS_ERRORS#11

Open
dave-miles wants to merge 1 commit intoShashikant86:masterfrom
dave-miles:feature/js_errors
Open

Toggle js_errors key via env var JS_ERRORS#11
dave-miles wants to merge 1 commit intoShashikant86:masterfrom
dave-miles:feature/js_errors

Conversation

@dave-miles
Copy link

@dave-miles dave-miles commented Nov 17, 2017

Done to get green on the poltergeist example.

To enable set the poltergeist key in cucumber.yml to:

poltergeist : DRIVER=poltergeist JS_ERRORS=false

Without the toggle I was getting:

Using the poltergeist and html profiles...
Feature: Google Search to explore BDDfire

  Scenario: View home page                     # features/bddfire.feature:4
    Given I am on "http://www.google.com"      # bddfire-2.0.8/lib/bddfire/web/web_steps.rb:2
      One or more errors were raised in the Javascript code on the page. If you don't care about these errors, you can ignore them by setting js_erro
rs: false in your Poltergeist configuration (see documentation for details).
      
      TypeError: undefined is not an object (evaluating 'google.jsc.x')
      TypeError: undefined is not an object (evaluating 'google.jsc.x')
          at http://www.google.co.uk/?gfe_rd=cr&dcr=0&ei=NQMPWtTUDsKN8QfHxpjYDw:44 (Capybara::Poltergeist::JavascriptError)
      features/bddfire.feature:5:in `Given I am on "http://www.google.com"'
    When I fill in "q" with the text "bddfire" # bddfire-2.0.8/lib/bddfire/web/web_steps.rb:6
    Then I should see "Sign in"                # bddfire-2.0.8/lib/bddfire/web/web_steps.rb:10

Failing Scenarios:
cucumber -p poltergeist -p html features/bddfire.feature:4 # Scenario: View home page

1 scenario (1 failed)
3 steps (1 failed, 2 skipped)
0m1.632s

@dave-miles
Toggle js_errors key via env var JS_ERRORS
c735b9a 
Done to get green on the poltergeist example. To enable set
the poltergeist key in cucumber.yml to:

  poltergeist : DRIVER=poltergeist JS_ERRORS=false
@dave-miles
Copy link
Author

dave-miles commented Nov 17, 2017

Travis failing on bundle install. Time to up the ruby version and versions within gem files?

@Shashikant86
Copy link
Owner

Shashikant86 commented Mar 1, 2018

Thanks for pull request. Yes it’s been while I haven’t looked at this project but I will find some time to check this out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dave-miles @Shashikant86