Skip to content

Commit bca95d1

Browse files
authored
Disable shared builds for tests failing on Windows (llvm#182249)
PR llvm#181720 introduced shared builds for LLDB API tests to improve test efficiency. But several data formatter tests requiring PDB debug info are failing on Windows x64 and AArch64 platforms. This patch disables shared builds for these tests by setting SHARED_BUILD_TESTCASE = False The shared build optimization breaks these tests because they reuse build artifacts between test methods The test runs may could use multiple methods with different debug formats or compiler flags. When a test runs first it builds with one set of flags, but then it runs again but **make** sees the source unchanged so it skips rebuilding and reuses the same old binary instead of rebuilding with correct flags.
1 parent 6a78d37 commit bca95d1

File tree

11 files changed

+11
-0
lines changed

11 files changed

+11
-0
lines changed

lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/optional/TestDataFormatterGenericOptional.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66

77
class GenericOptionalDataFormatterTestCase(TestBase):
88
TEST_WITH_PDB_DEBUG_INFO = True
9+
SHARED_BUILD_TESTCASE = False
910

1011
def do_test_with_run_command(self):
1112
"""Test that that file and class static variables display correctly."""

lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/shared_ptr/TestDataFormatterStdSharedPtr.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010

1111
class TestCase(TestBase):
1212
TEST_WITH_PDB_DEBUG_INFO = True
13+
SHARED_BUILD_TESTCASE = False
1314

1415
def do_test(self):
1516
"""Test `frame variable` output for `std::shared_ptr` types."""

lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/span/TestDataFormatterStdSpan.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010

1111
class StdSpanDataFormatterTestCase(TestBase):
1212
TEST_WITH_PDB_DEBUG_INFO = True
13+
SHARED_BUILD_TESTCASE = False
1314

1415
def findVariable(self, name):
1516
var = self.frame().FindVariable(name)

lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/string_view/TestDataFormatterStdStringView.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212

1313
class StdStringViewDataFormatterTestCase(TestBase):
1414
TEST_WITH_PDB_DEBUG_INFO = True
15+
SHARED_BUILD_TESTCASE = False
1516

1617
def setUp(self):
1718
# Call super's setUp().

lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/u8string/TestDataFormatterStdU8String.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212

1313
class StdU8StringDataFormatterTestCase(TestBase):
1414
TEST_WITH_PDB_DEBUG_INFO = True
15+
SHARED_BUILD_TESTCASE = False
1516

1617
def do_test(self):
1718
lldbutil.run_to_source_breakpoint(

lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/u8string_view/TestDataFormatterStdU8StringView.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212

1313
class StdU8StringViewDataFormatterTestCase(TestBase):
1414
TEST_WITH_PDB_DEBUG_INFO = True
15+
SHARED_BUILD_TESTCASE = False
1516

1617
def do_test(self):
1718
lldbutil.run_to_source_breakpoint(

lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/unique_ptr/TestDataFormatterStdUniquePtr.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010

1111
class TestCase(TestBase):
1212
TEST_WITH_PDB_DEBUG_INFO = True
13+
SHARED_BUILD_TESTCASE = False
1314

1415
def do_test(self):
1516
"""Test `frame variable` output for `std::unique_ptr` types."""

lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/unordered/TestDataFormatterGenericUnordered.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55

66
class GenericUnorderedDataFormatterTestCase(TestBase):
77
TEST_WITH_PDB_DEBUG_INFO = True
8+
SHARED_BUILD_TESTCASE = False
89

910
def setUp(self):
1011
TestBase.setUp(self)

lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/variant/TestDataFormatterStdVariant.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010

1111
class StdVariantDataFormatterTestCase(TestBase):
1212
TEST_WITH_PDB_DEBUG_INFO = True
13+
SHARED_BUILD_TESTCASE = False
1314

1415
def do_test(self):
1516
"""Test that that file and class static variables display correctly."""

lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/vector/TestDataFormatterStdVector.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010

1111
class StdVectorDataFormatterTestCase(TestBase):
1212
TEST_WITH_PDB_DEBUG_INFO = True
13+
SHARED_BUILD_TESTCASE = False
1314

1415
def check_numbers(self, var_name, show_ptr=False):
1516
patterns = []

0 commit comments

Comments
 (0)