Increment version to 2.5.1 and add temporal type validation

Author: ShawnStrasser

pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "traffic_anomaly"
-version = "2.5.0"
+version = "2.5.1"
 authors = [
   { name="Shawn Strasser", email="shawn.strasser@odot.oregon.gov" },
 ]

src/traffic_anomaly/__init__.py

@@ -5,4 +5,4 @@
 
 __all__ = ['decompose', 'anomaly', 'changepoint']
 
-__version__ = '2.5.0'
+__version__ = '2.5.1'

src/traffic_anomaly/anomaly.py

@@ -21,6 +21,9 @@ def _validate_columns(table: ibis.Expr, datetime_column: str, value_column: str,
     if missing_columns:
         raise ValueError(f"Missing required columns: {missing_columns}")
 
+    if not table[datetime_column].type().is_temporal():
+        raise TypeError(f"Column '{datetime_column}' must be a temporal type (e.g., timestamp or date), but is {table[datetime_column].type()}")
+
 
 def anomaly(
     decomposed_data: Union[ibis.Expr, Any],  # ibis.Expr or pandas.DataFrame

src/traffic_anomaly/changepoint.py

@@ -25,6 +25,9 @@ def _validate_columns(table: ibis.Expr, datetime_column: str, value_column: str,
     if missing_columns:
         raise ValueError(f"Missing required columns: {missing_columns}")
 
+    if not table[datetime_column].type().is_temporal():
+        raise TypeError(f"Column '{datetime_column}' must be a temporal type (e.g., timestamp or date), but is {table[datetime_column].type()}")
+
 
 def _calculate_changepoints_core(
     table: ibis.Expr,

src/traffic_anomaly/decompose.py

@@ -21,6 +21,9 @@ def _validate_columns(table: ibis.Expr, datetime_column: str, value_column: str,
     if missing_columns:
         raise ValueError(f"Missing required columns: {missing_columns}")
 
+    if not table[datetime_column].type().is_temporal():
+        raise TypeError(f"Column '{datetime_column}' must be a temporal type (e.g., timestamp or date), but is {table[datetime_column].type()}")
+
 
 def decompose(
     data: Union[ibis.Expr, Any],  # ibis.Expr or pandas.DataFrame

tests/test_traffic_anomaly.py

@@ -885,6 +885,43 @@ def test_decompose_invalid_data_type(self):
                 entity_grouping_columns=['id']
             )
 
+    def test_invalid_timestamp_type(self):
+        """Test that providing a string timestamp raises a TypeError"""
+        df_string_ts = pd.DataFrame({
+            'timestamp': ['2023-01-01 00:00:00'],
+            'value': [10],
+            'id': ['A'],
+            'prediction': [10],
+            'resid': [0]
+        })
+
+        # Test decompose
+        with pytest.raises(TypeError, match="must be a temporal type"):
+            traffic_anomaly.decompose(
+                data=df_string_ts,
+                datetime_column='timestamp',
+                value_column='value',
+                entity_grouping_columns=['id']
+            )
+
+        # Test anomaly
+        with pytest.raises(TypeError, match="must be a temporal type"):
+            traffic_anomaly.anomaly(
+                decomposed_data=df_string_ts,
+                datetime_column='timestamp',
+                value_column='value',
+                entity_grouping_columns=['id']
+            )
+
+        # Test changepoint
+        with pytest.raises(TypeError, match="must be a temporal type"):
+            traffic_anomaly.changepoint(
+                data=df_string_ts,
+                datetime_column='timestamp',
+                value_column='value',
+                entity_grouping_column='id'
+            )
+
     def test_anomaly_missing_columns(self):
         """Test anomaly detection with missing required columns"""
         # Test missing datetime column