Skip to content

Conversation

@giuunit
Copy link

@giuunit giuunit commented Sep 26, 2016

Multiple commits due to error in the name of the commit at first attempt.

@Shazwazza
Copy link
Owner

Thanks for the PR!

This will be a little more complex than this unfortunately. The method you are calling in to to render the Js is this one: https://github.com/Shazwazza/ClientDependency/blob/master/ClientDependency.Mvc/HtmlHelperExtensions.cs#L267

Which isn't used to render a bundle, that is used to render any dependencies registered for that file type based on a defined provider (renderer). The code you've applied essentially makes the whole page dependent on a bundle and then tries to render out html tags based on a specific provider.

Instead it needs to just render out the tags for the particular bundle, not adding any dependencies, etc... I haven't looked into this codebase for quite a while, i can get back to you soon with some info on how to generate these URLs

@giuunit
Copy link
Author

giuunit commented Sep 28, 2016

Oh, my bad

I will have a look on my side me too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants