Skip to content

Commit 59538ee

Browse files
Extract SheetOption interface
Have WritingOptions and Table2SheetOpts inherit. Fixes TS error setting sheet name when using table_to_book and other table_to functions.
1 parent 0ddeba4 commit 59538ee

File tree

1 file changed

+10
-8
lines changed

1 file changed

+10
-8
lines changed

types/index.d.ts

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -205,8 +205,16 @@ export interface ParsingOptions extends CommonOptions {
205205
dense?: boolean;
206206
}
207207

208+
export interface SheetOption {
209+
/**
210+
* Name of Worksheet (for single-sheet formats)
211+
* @default ''
212+
*/
213+
sheet?: string;
214+
}
215+
208216
/** Options for write and writeFile */
209-
export interface WritingOptions extends CommonOptions {
217+
export interface WritingOptions extends CommonOptions, SheetOption {
210218
/** Output data encoding */
211219
type?: 'base64' | 'binary' | 'buffer' | 'file' | 'array' | 'string';
212220

@@ -222,12 +230,6 @@ export interface WritingOptions extends CommonOptions {
222230
*/
223231
bookType?: BookType;
224232

225-
/**
226-
* Name of Worksheet (for single-sheet formats)
227-
* @default ''
228-
*/
229-
sheet?: string;
230-
231233
/**
232234
* Use ZIP compression for ZIP-based formats
233235
* @default false
@@ -702,7 +704,7 @@ export interface JSON2SheetOpts extends CommonOptions, DateNFOption {
702704

703705
export interface SheetJSONOpts extends JSON2SheetOpts, OriginOption {}
704706

705-
export interface Table2SheetOpts extends CommonOptions, DateNFOption, OriginOption {
707+
export interface Table2SheetOpts extends CommonOptions, DateNFOption, OriginOption, SheetOption {
706708
/** If true, plaintext parsing will not parse values */
707709
raw?: boolean;
708710

0 commit comments

Comments
 (0)