Skip to content

Commit af72272

Browse files
committed
The daemon now uses the log crate
1 parent 9fc5ea4 commit af72272

File tree

4 files changed

+24
-12
lines changed

4 files changed

+24
-12
lines changed

backlightd/Cargo.toml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@ version = "0.1.0"
44
edition = "2021"
55

66
[dependencies]
7+
log = "0.4.22"
8+
pretty_env_logger = "0.5.0"
79
ddc-hi = "0.4.1"
810
backlight_ipc = { path = "../backlight_ipc" }
911
anyhow = "1.0.93"

backlightd/src/auto.rs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ use std::{
77
use anyhow::anyhow;
88
use backlight_ipc::BacklightMode;
99
use chrono::{DateTime, Datelike, Local, NaiveTime};
10+
use log::{error, info};
1011
use sunrise::sunrise_sunset;
1112

1213
use crate::{location::find_location, monitors};
@@ -32,14 +33,14 @@ pub fn auto_adjust(auto_adjust_receiver: Receiver<BacklightMode>) -> ! {
3233
};
3334

3435
if let Err(err) = result {
35-
eprintln!("Unable to set brightness: {err}");
36+
error!("Unable to set brightness: {err}");
3637
}
3738
}
3839

3940
match auto_adjust_receiver.recv_timeout(AUTO_ADJUST_INTERVAL) {
4041
Ok(new_mode) => {
4142
if new_mode != current_mode {
42-
println!("Set backlightd mode to {new_mode:?}");
43+
info!("Set backlightd mode to {new_mode:?}");
4344
}
4445
last_time_mode_was_changed = Instant::now();
4546
current_mode = new_mode;

backlightd/src/main.rs

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ use std::{
1010

1111
use auto::auto_adjust;
1212
use backlight_ipc::{BacklightCommand, BacklightMode, DEFAULT_UNIX_SOCKET_PATH};
13+
use log::error;
1314
use monitors::auto_refresh_monitors_list;
1415

1516
mod acpi;
@@ -53,19 +54,24 @@ fn handle_commands(
5354
auto_adjust_sender
5455
.send(backlight_mode)
5556
.unwrap_or_else(|err| {
56-
eprintln!("Failed to send mode to auto adjust channel: {err}")
57+
error!("Failed to send mode to auto adjust channel: {err}")
5758
});
5859
Ok(())
5960
}
6061
};
6162

6263
if let Err(err) = result {
63-
eprintln!("Command handling failed: {err}");
64+
error!("Command handling failed: {err}");
6465
}
6566
}
6667
}
6768

6869
fn main() {
70+
pretty_env_logger::formatted_builder()
71+
.filter_level(log::LevelFilter::Info)
72+
.parse_env("BACKLIGHTD_LOG_LEVEL")
73+
.init();
74+
6975
let args: Vec<String> = env::args().collect();
7076

7177
if args.len() != 1 && args.len() != 3 {
@@ -84,15 +90,15 @@ fn main() {
8490

8591
if let Err(err) = remove_file(unix_socket_path) {
8692
if !matches!(err.kind(), io::ErrorKind::NotFound) {
87-
eprintln!("{unix_socket_path}: {err}");
93+
error!("{unix_socket_path}: {err}");
8894
exit(1);
8995
}
9096
}
9197

9298
let listener = match UnixListener::bind(unix_socket_path) {
9399
Ok(listener) => listener,
94100
Err(err) => {
95-
eprintln!("{unix_socket_path}: {err}");
101+
error!("{unix_socket_path}: {err}");
96102
exit(1);
97103
}
98104
};
@@ -120,7 +126,7 @@ fn main() {
120126
let stream = match stream {
121127
Ok(stream) => stream,
122128
Err(err) => {
123-
eprintln!("A client tried to connect but something wrong happened: {err}");
129+
error!("A client tried to connect but something wrong happened: {err}");
124130
continue;
125131
}
126132
};
@@ -130,7 +136,7 @@ fn main() {
130136
cmd_sender.send(command).unwrap();
131137
}
132138
Err(err) => {
133-
eprintln!("Unable to deserialize command: {err}");
139+
error!("Unable to deserialize command: {err}");
134140
}
135141
}
136142
}

backlightd/src/monitors.rs

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@ use std::{
55
time::{Duration, Instant},
66
};
77

8+
use log::{error, info};
9+
810
use crate::acpi::{BacklightAcpiDevice, ACPI_DEVICES_PATH};
911
use crate::ddc::BacklightDdcDevice;
1012

@@ -52,7 +54,7 @@ pub(crate) fn refresh_monitors_list() {
5254
for ddc_device in ddc_hi::Display::enumerate() {
5355
match BacklightDdcDevice::new(ddc_device) {
5456
Ok(monitor) => new_monitors.push(Box::new(monitor)),
55-
Err(err) => eprintln!("Failed to retrieve DDC backlight monitor: {err}"),
57+
Err(err) => error!("Failed to retrieve DDC backlight monitor: {err}"),
5658
}
5759
}
5860

@@ -62,16 +64,16 @@ pub(crate) fn refresh_monitors_list() {
6264
match entry {
6365
Ok(file) => match BacklightAcpiDevice::new(file.path()) {
6466
Ok(monitor) => new_monitors.push(Box::new(monitor)),
65-
Err(err) => println!("Failed to retrieve ACPI backlight monitor: {err}"),
67+
Err(err) => error!("Failed to retrieve ACPI backlight monitor: {err}"),
6668
},
6769
Err(err) => {
68-
eprintln!("Unable to read entry from {ACPI_DEVICES_PATH}: {err}");
70+
error!("Unable to read entry from {ACPI_DEVICES_PATH}: {err}");
6971
}
7072
}
7173
}
7274
}
7375
Err(err) => {
74-
eprintln!("{ACPI_DEVICES_PATH}: {err}");
76+
error!("{ACPI_DEVICES_PATH}: {err}");
7577
// fallthrough
7678
}
7779
}
@@ -89,6 +91,7 @@ pub(crate) fn set_brightness_percent(percent: u8) -> anyhow::Result<()> {
8991
for monitor in MONITORS.lock().unwrap().iter_mut() {
9092
monitor.set_brightness(percent)?;
9193
}
94+
info!("Brightness of all monitors has been set to {percent}%");
9295
Ok(())
9396
}
9497

0 commit comments

Comments
 (0)