This repository was archived by the owner on Oct 26, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Translation Epic - Handle Server Translated Messages #326
Copy link
Copy link
Open
Labels
featureNew feature or change that directly affects usersNew feature or change that directly affects users
Milestone
Description
Desired Use Case
The client should not try to translate server-translated messages.
Actual/Current Behavior
Currently, the client tries to translate all messages passed through to the NotificationService. When given a translated string from the server, the service falls back to serving the message as is, but the translation library, transloco, logs a missing translation key error.
Steps to Implement This Feature
- Add a
isServerTranslatedflag with default value of false to theNotificationServicemethods. - Only try translating the message when
isServerTranslatedis true. - Pass the true value from the server error statements in the
handleError()semaphore.
Testing Steps
If you are not a member of this project, skip this step
How do the users test this change?
- Cause a server side error (logging in with the wrong credentials is an easy test).
- Confirm that the error toast shows correctly.
- Confirm that no error about missing keys appears in the console.
- Try again in other languages.
- Confirm that no error about missing keys appears in the console.
- Trigger a client side message (adding or deleting a user, agency, or agent, resending activation email, and resetting user passwords all show client side messages).
- Confirm that the success message shows correctly.
- Try again in other languages.
- Confirm that the success message shows correctly.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
featureNew feature or change that directly affects usersNew feature or change that directly affects users