Skip to content

Commit 797957e

Browse files
authored
Migration to Compose 2024.09.02 (#316)
1 parent d4b1f8d commit 797957e

File tree

53 files changed

+176
-164
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

53 files changed

+176
-164
lines changed

build-logic/convention/src/main/kotlin/com/shifthackz/aisdv1/buildlogic/Compose.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ internal fun Project.configureCompose(
3737
add("implementation", libs.findLibrary("androidx.paging.compose").get())
3838
add("implementation", libs.findLibrary("androidx.lifecycle.viewmodel").get())
3939
add("implementation", libs.findLibrary("androidx.lifecycle.compose").get())
40-
add("implementation", libs.findLibrary("google.accompanist.systemuicontroller").get())
4140
add("implementation", libs.findLibrary("rx.java").get())
4241
add("implementation", libs.findLibrary("shifthackz.mvi").get())
4342
add("implementation", libs.findLibrary("kotlinx.serialization.json").get())

core/ui/src/main/java/com/shifthackz/aisdv1/core/ui/MviComponent.kt

Lines changed: 0 additions & 49 deletions
This file was deleted.

data/src/main/java/com/shifthackz/aisdv1/data/preference/PreferenceManagerImpl.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ class PreferenceManagerImpl(
9696

9797
override var monitorConnectivity: Boolean
9898
get() = if (!source.featureTags.contains(FeatureTag.OwnServer)) false
99-
else preferences.getBoolean(KEY_MONITOR_CONNECTIVITY, true)
99+
else preferences.getBoolean(KEY_MONITOR_CONNECTIVITY, false)
100100
set(value) = preferences.edit()
101101
.putBoolean(KEY_MONITOR_CONNECTIVITY, value)
102102
.apply()
@@ -321,7 +321,7 @@ class PreferenceManagerImpl(
321321
const val KEY_MEDIA_PIPE_CUSTOM_MODEL_PATH = "key_mediapipe_custom_model_path"
322322
const val KEY_ALLOW_LOCAL_DIFFUSION_CANCEL = "key_allow_local_diffusion_cancel"
323323
const val KEY_LOCAL_DIFFUSION_SCHEDULER_THREAD = "key_local_diffusion_scheduler_thread"
324-
const val KEY_MONITOR_CONNECTIVITY = "key_monitor_connectivity"
324+
const val KEY_MONITOR_CONNECTIVITY = "key_monitor_connection"
325325
const val KEY_AI_AUTO_SAVE = "key_ai_auto_save"
326326
const val KEY_SAVE_TO_MEDIA_STORE = "key_save_to_media_store"
327327
const val KEY_FORM_ALWAYS_SHOW_ADVANCED_OPTIONS = "key_always_show_advanced_options"

gradle/libs.versions.toml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,15 +9,14 @@ kotlin = "2.0.20"
99
ksp = "2.0.20-1.0.25"
1010
appcompat = "1.7.0"
1111
composeCompiler = "1.5.7"
12-
composeBom = "2024.08.00"
12+
composeBom = "2024.09.02"
1313
composeActivity = "1.9.2"
1414
composeJunit = "1.7.2"
1515
lifecycleViewModel = "2.8.6"
1616
navigation = "2.8.1"
1717
paging = "3.1.1"
1818
pagingCompose = "1.0.0-alpha18"
1919
gson = "2.11.0"
20-
accompanistSystemUi = "0.36.0"
2120
retrofit = "2.11.0"
2221
okhttp = "5.0.0-alpha.14"
2322
koin = "4.0.0"
@@ -79,7 +78,6 @@ androidx-room-rx = { group = "androidx.room", name = "room-rxjava3", version.ref
7978
androidx-work-runtime = { group = "androidx.work", name = "work-runtime", version.ref = "workManager" }
8079
google-gson = { group = "com.google.code.gson", name = "gson", version.ref = "gson" }
8180
google-material = { group = "com.google.android.material", name = "material", version.ref = "material" }
82-
google-accompanist-systemuicontroller = { group = "com.google.accompanist", name = "accompanist-systemuicontroller", version.ref = "accompanistSystemUi" }
8381
google-mediapipe-image-generator = { group = "com.google.mediapipe", name = "tasks-vision-image-generator", version.ref = "mediaPipeGenerator" }
8482
retrofit-core = { group = "com.squareup.retrofit2", name = "retrofit", version.ref = "retrofit" }
8583
retrofit-converter-gson = { group = "com.squareup.retrofit2", name = "converter-gson", version.ref = "retrofit" }

presentation/build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ android {
1919
}
2020

2121
dependencies {
22-
api(project(":core:ui"))
22+
implementation(project(":core:ui"))
2323
implementation(project(":core:common"))
2424
implementation(project(":core:imageprocessing"))
2525
implementation(project(":core:localization"))

presentation/src/main/java/com/shifthackz/aisdv1/presentation/activity/AiStableDiffusionActivity.kt

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import android.os.Bundle
55
import android.view.View
66
import androidx.activity.compose.BackHandler
77
import androidx.activity.compose.setContent
8+
import androidx.activity.enableEdgeToEdge
89
import androidx.activity.result.contract.ActivityResultContracts
910
import androidx.appcompat.app.AppCompatActivity
1011
import androidx.compose.material3.DrawerValue
@@ -22,14 +23,14 @@ import androidx.navigation.compose.NavHost
2223
import androidx.navigation.compose.currentBackStackEntryAsState
2324
import androidx.navigation.compose.rememberNavController
2425
import com.shifthackz.aisdv1.core.common.log.debugLog
25-
import com.shifthackz.aisdv1.core.ui.MviComponent
2626
import com.shifthackz.aisdv1.presentation.extensions.navigatePopUpToCurrent
2727
import com.shifthackz.aisdv1.presentation.navigation.NavigationEffect
2828
import com.shifthackz.aisdv1.presentation.navigation.NavigationRoute
2929
import com.shifthackz.aisdv1.presentation.navigation.graph.mainNavGraph
3030
import com.shifthackz.aisdv1.presentation.screen.drawer.DrawerScreen
3131
import com.shifthackz.aisdv1.presentation.theme.global.AiSdAppTheme
3232
import com.shifthackz.aisdv1.presentation.utils.PermissionUtil
33+
import com.shifthackz.android.core.mvi.MviComponent
3334
import kotlinx.coroutines.launch
3435
import org.koin.androidx.viewmodel.ext.android.viewModel
3536

@@ -54,6 +55,7 @@ class AiStableDiffusionActivity : AppCompatActivity() {
5455

5556
override fun onCreate(savedInstanceState: Bundle?) {
5657
val splashScreen = installSplashScreen()
58+
enableEdgeToEdge()
5759
super.onCreate(savedInstanceState)
5860
actionBar?.hide()
5961
splashScreen.setKeepOnScreenCondition { viewModel.state.value.isShowSplash }
@@ -125,9 +127,8 @@ class AiStableDiffusionActivity : AppCompatActivity() {
125127
homeRouteEntry = effect.navRoute
126128
}
127129
}
128-
},
129-
applySystemUiColors = false,
130-
) { state, _ ->
130+
}
131+
) { state ->
131132
DrawerScreen(
132133
drawerState = drawerState,
133134
backStackEntry = backStackEntry,

presentation/src/main/java/com/shifthackz/aisdv1/presentation/modal/ModalRenderer.kt

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ package com.shifthackz.aisdv1.presentation.modal
44

55
import androidx.compose.foundation.layout.fillMaxWidth
66
import androidx.compose.material3.ExperimentalMaterial3Api
7+
import androidx.compose.material3.MaterialTheme
78
import androidx.compose.material3.ModalBottomSheet
89
import androidx.compose.runtime.Composable
910
import androidx.compose.runtime.getValue
@@ -120,6 +121,7 @@ fun ModalRenderer(
120121
is Modal.Image.Batch -> ModalBottomSheet(
121122
onDismissRequest = dismiss,
122123
shape = RectangleShape,
124+
containerColor = MaterialTheme.colorScheme.background,
123125
) {
124126
GenerationImageBatchResultModal(
125127
screenModal.results,
@@ -136,6 +138,7 @@ fun ModalRenderer(
136138
is Modal.PromptBottomSheet -> ModalBottomSheet(
137139
onDismissRequest = dismiss,
138140
shape = RectangleShape,
141+
containerColor = MaterialTheme.colorScheme.background,
139142
) {
140143
InputHistoryScreen(
141144
onGenerationSelected = { ai ->
@@ -266,6 +269,7 @@ fun ModalRenderer(
266269
Modal.Language -> ModalBottomSheet(
267270
onDismissRequest = dismiss,
268271
shape = RectangleShape,
272+
containerColor = MaterialTheme.colorScheme.background,
269273
) {
270274
LanguageBottomSheet(onDismissRequest = dismiss)
271275
}
@@ -333,6 +337,7 @@ fun ModalRenderer(
333337
is Modal.GalleryGrid -> ModalBottomSheet(
334338
onDismissRequest = dismiss,
335339
shape = RectangleShape,
340+
containerColor = MaterialTheme.colorScheme.background,
336341
) {
337342
GridBottomSheet(
338343
currentGrid = screenModal.grid,
@@ -346,6 +351,7 @@ fun ModalRenderer(
346351
is Modal.LDScheduler -> ModalBottomSheet(
347352
onDismissRequest = dismiss,
348353
shape = RectangleShape,
354+
containerColor = MaterialTheme.colorScheme.background,
349355
) {
350356
LDSchedulerBottomSheet(
351357
currentScheduler = screenModal.scheduler,

presentation/src/main/java/com/shifthackz/aisdv1/presentation/modal/embedding/EmbeddingScreen.kt

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ import androidx.compose.foundation.lazy.LazyColumn
1919
import androidx.compose.foundation.shape.RoundedCornerShape
2020
import androidx.compose.material.icons.Icons
2121
import androidx.compose.material.icons.filled.Check
22-
import androidx.compose.material3.AlertDialogDefaults
2322
import androidx.compose.material3.Button
2423
import androidx.compose.material3.Icon
2524
import androidx.compose.material3.LocalContentColor
@@ -46,7 +45,7 @@ import androidx.compose.ui.unit.sp
4645
import androidx.compose.ui.window.Dialog
4746
import androidx.compose.ui.window.DialogProperties
4847
import com.shifthackz.aisdv1.core.extensions.shimmer
49-
import com.shifthackz.aisdv1.core.ui.MviComponent
48+
import com.shifthackz.android.core.mvi.MviComponent
5049
import com.shifthackz.aisdv1.domain.entity.ServerSource
5150
import com.shifthackz.aisdv1.presentation.modal.extras.ExtrasEffect
5251
import com.shifthackz.aisdv1.presentation.model.ErrorState
@@ -102,7 +101,7 @@ private fun ScreenContent(
102101
Surface(
103102
modifier = modifier.fillMaxHeight(0.7f),
104103
shape = RoundedCornerShape(16.dp),
105-
color = AlertDialogDefaults.containerColor,
104+
color = MaterialTheme.colorScheme.background,
106105
) {
107106
Scaffold(
108107
bottomBar = {

presentation/src/main/java/com/shifthackz/aisdv1/presentation/modal/extras/ExtrasScreen.kt

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ import androidx.compose.foundation.shape.RoundedCornerShape
2222
import androidx.compose.material.icons.Icons
2323
import androidx.compose.material.icons.filled.Check
2424
import androidx.compose.material.icons.filled.DataExploration
25-
import androidx.compose.material3.AlertDialogDefaults
2625
import androidx.compose.material3.Button
2726
import androidx.compose.material3.Icon
2827
import androidx.compose.material3.LocalContentColor
@@ -43,7 +42,7 @@ import androidx.compose.ui.unit.sp
4342
import androidx.compose.ui.window.Dialog
4443
import androidx.compose.ui.window.DialogProperties
4544
import com.shifthackz.aisdv1.core.extensions.shimmer
46-
import com.shifthackz.aisdv1.core.ui.MviComponent
45+
import com.shifthackz.android.core.mvi.MviComponent
4746
import com.shifthackz.aisdv1.domain.entity.ServerSource
4847
import com.shifthackz.aisdv1.presentation.model.ErrorState
4948
import com.shifthackz.aisdv1.presentation.model.ExtraType
@@ -99,7 +98,7 @@ private fun ScreenContent(
9998
Surface(
10099
modifier = modifier.fillMaxHeight(0.7f),
101100
shape = RoundedCornerShape(16.dp),
102-
color = AlertDialogDefaults.containerColor,
101+
color = MaterialTheme.colorScheme.background,
103102
) {
104103
Scaffold(
105104
bottomBar = {

presentation/src/main/java/com/shifthackz/aisdv1/presentation/modal/history/InputHistoryScreen.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ import androidx.compose.ui.unit.dp
3939
import androidx.paging.PagingData
4040
import androidx.paging.compose.collectAsLazyPagingItems
4141
import androidx.paging.compose.items
42-
import com.shifthackz.aisdv1.core.ui.MviComponent
42+
import com.shifthackz.android.core.mvi.MviComponent
4343
import com.shifthackz.aisdv1.domain.entity.AiGenerationResult
4444
import kotlinx.coroutines.flow.Flow
4545
import org.koin.androidx.compose.koinViewModel
@@ -50,7 +50,7 @@ fun InputHistoryScreen(
5050
onGenerationSelected: (AiGenerationResult) -> Unit = {},
5151
) {
5252
val viewModel = koinViewModel<InputHistoryViewModel>()
53-
MviComponent(viewModel = viewModel, applySystemUiColors = false) { _, _ ->
53+
MviComponent(viewModel = viewModel) { _, _ ->
5454
ScreenContent(
5555
modifier = Modifier.fillMaxSize(),
5656
pagingFlow = viewModel.pagingFlow,
@@ -107,7 +107,7 @@ private fun InputHistoryItem(
107107
modifier = modifier
108108
.fillMaxWidth()
109109
.clip(RoundedCornerShape(16.dp))
110-
.background(color = MaterialTheme.colorScheme.background)
110+
.background(color = MaterialTheme.colorScheme.surface)
111111
.defaultMinSize(minHeight = 50.dp)
112112
.clickable { onClick(item) },
113113
) {

0 commit comments

Comments
 (0)