Improve GalleryDetailViewModel delete method

ShiftHackZ · ShiftHackZ · commit e947e47da1e2 · 2024-08-03T16:43:38.000+03:00
diff --git a/presentation/src/main/java/com/shifthackz/aisdv1/presentation/screen/gallery/detail/GalleryDetailViewModel.kt b/presentation/src/main/java/com/shifthackz/aisdv1/presentation/screen/gallery/detail/GalleryDetailViewModel.kt
@@ -97,8 +97,8 @@ class GalleryDetailViewModel(
     }
 
     private fun delete() {
-        if (currentState !is GalleryDetailState.Content) return
-        !deleteGalleryItemUseCase((currentState as GalleryDetailState.Content).id)
+        val state = currentState as? GalleryDetailState.Content ?: return
+        !deleteGalleryItemUseCase(state.id)
             .subscribeOnMainThread(schedulersProvider)
             .subscribeBy(::errorLog) { mainRouter.navigateBack() }
     }

Original file line number	Diff line number	Diff line change
`@@ -97,8 +97,8 @@ class GalleryDetailViewModel(`
`97`	`97`	`}`
`98`	`98`
`99`	`99`	`private fun delete() {`
`100`		`- if (currentState !is GalleryDetailState.Content) return`
`101`		`- !deleteGalleryItemUseCase((currentState as GalleryDetailState.Content).id)`
	`100`	`+ val state = currentState as? GalleryDetailState.Content ?: return`
	`101`	`+ !deleteGalleryItemUseCase(state.id)`
`102`	`102`	`.subscribeOnMainThread(schedulersProvider)`
`103`	`103`	`.subscribeBy(::errorLog) { mainRouter.navigateBack() }`
`104`	`104`	`}`