Create tests that detect failing builds (Buildalyzer#308)

Author: Corniel

src/Buildalyzer.Logger/BuildalyzerLogger.cs

@@ -13,7 +13,7 @@ public class BuildalyzerLogger : PipeLogger
     public override void Initialize(IEventSource eventSource)
     {
         // Parse the parameters
-        string[] parameters = Parameters.Split(';').Select(x => x.Trim()).ToArray();
+        string[] parameters = [..(Parameters?.Split(';').Select(x => x.Trim())).OfType<string>()];
         if (parameters.Length != 2)
         {
             throw new LoggerException("Unexpected number of parameters");

tests/Buildalyzer.Tests/Integration/Failing_builds.cs

@@ -0,0 +1,32 @@
+using Buildalyzer.Environment;
+using Buildalyzer.TestTools;
+using FluentAssertions;
+
+namespace Failing_builds;
+
+public class Analyzer_Build
+{
+    [Test]
+    public void Detects_failing_build_on_single_target()
+    {
+        using var ctx = Context.ForProject(@"BuildWithError\BuildWithError.csproj");
+        var results = ctx.Analyzer.Build(new EnvironmentOptions() { DesignTime = false });
+
+        Console.WriteLine(ctx.Log);
+
+        results.OverallSuccess.Should().BeFalse();
+        results.Should().AllSatisfy(r => r.Succeeded.Should().BeFalse());
+    }
+
+    [Test]
+    public void Detects_failing_build_on_multi_targets()
+    {
+        using var ctx = Context.ForProject(@"BuildWithError\BuildWithError.MultiTarget.csproj");
+        var results = ctx.Analyzer.Build(new EnvironmentOptions() { DesignTime = false });
+
+        Console.WriteLine(ctx.Log);
+
+        results.OverallSuccess.Should().BeFalse();
+        results.Should().AllSatisfy(r => r.Succeeded.Should().BeFalse());
+    }
+}

tests/Buildalyzer.Workspaces.Tests/Failing_builds.cs

@@ -0,0 +1,17 @@
+using Buildalyzer.TestTools;
+using Buildalyzer.Workspaces;
+using FluentAssertions;
+using NUnit.Framework;
+
+namespace Failing_builds;
+
+public class Analyzer_Build
+{
+    [Test]
+    public void Detects_failing_build()
+    {
+        using var ctx = Context.ForProject(@"BuildWithError\BuildWithError.csproj");
+
+        ctx.Invoking(c => ctx.Analyzer.GetWorkspace()).Should().NotThrow();
+    }
+}

tests/projects/BuildWithError/BuildWithError.MultiTarget.csproj

@@ -0,0 +1,7 @@
+<Project Sdk="Microsoft.NET.Sdk">
+
+    <PropertyGroup>
+        <TargetFrameworks>net6.0;net8.0</TargetFrameworks>
+    </PropertyGroup>
+
+</Project>

tests/projects/BuildWithError/BuildWithError.csproj

@@ -0,0 +1,7 @@
+<Project Sdk="Microsoft.NET.Sdk">
+
+    <PropertyGroup>
+        <TargetFramework>net8.0</TargetFramework>
+    </PropertyGroup>
+
+</Project>

tests/projects/BuildWithError/MissingSemiColon.cs

@@ -0,0 +1,6 @@
+namespace BuildWithError;
+
+public class MissingSemiColon
+{
+    public string Name { get; set }
+}

tests/projects/BuildWithError/UnclosedClass.cs

@@ -0,0 +1,3 @@
+namespace BuildWithError;
+
+public class UnclosedClass