Introduction for test context to test solution files (Buildalyzer#316)

Author: Corniel

src/Buildalyzer/IO/IOPath.cs

@@ -21,8 +21,8 @@ namespace Buildalyzer.IO;
 
     private IOPath(string path) => _path = path;
 
-    /// <summary>Indicates that the path has been set.</summary>
-    public bool HasValue => _path is not null;
+    /// <summary>Returns true if the path is not empty.</summary>
+    public bool HasValue => _path is { Length: > 0 };
 
     /// <summary>Creates a <see cref="DirectoryInfo"/> based on the path.</summary>
     [Pure]

tests/Buildalyzer.Tests/Integration/SimpleProjectsFixture.cs

@@ -443,74 +443,6 @@ public void LegacyFrameworkProjectWithProjectReferenceGetsReferences()
         references.ShouldContain(x => x.EndsWith("LegacyFrameworkProjectWithPackageReference.csproj"), log.ToString());
     }
 
-    [Test]
-    public void GetsProjectsInSolution()
-    {
-        // Given
-        StringWriter log = new StringWriter();
-
-        // When
-        AnalyzerManager manager = new AnalyzerManager(
-            GetProjectPath("TestProjects.sln"),
-            new AnalyzerManagerOptions
-            {
-                LogWriter = log
-            });
-
-        // Then
-        ProjectFiles.Select(x => GetProjectPath(x)).ShouldBeSubsetOf(manager.Projects.Keys, log.ToString());
-    }
-
-    [Test]
-    public void FiltersProjectsInSolution()
-    {
-        // Given
-        StringWriter log = new StringWriter();
-
-        // When
-        AnalyzerManager manager = new AnalyzerManager(
-            GetProjectPath("TestProjects.sln"),
-            new AnalyzerManagerOptions
-            {
-                LogWriter = log,
-                ProjectFilter = x => x.AbsolutePath.Contains("Core")
-            });
-
-        // Then
-        ProjectFiles.Select(x => GetProjectPath(x)).Where(x => x.Contains("Core")).ShouldBe(manager.Projects.Keys, true, log.ToString());
-    }
-
-    [Test]
-    public void IgnoreSolutionItemsThatAreNotProjects()
-    {
-        // Given / When
-        AnalyzerManager manager = new AnalyzerManager(GetProjectPath("TestProjects.sln"));
-
-        // Then
-        manager.Projects.Any(x => x.Value.ProjectFile.Path.Contains("TestEmptySolutionFolder")).ShouldBeFalse();
-    }
-
-    [Test]
-    public void GetsProjectGuidFromSolution([ValueSource(nameof(Preferences))] EnvironmentPreference preference)
-    {
-        // Given
-        AnalyzerManager manager = new AnalyzerManager(
-            GetProjectPath("TestProjects.sln"));
-        IProjectAnalyzer analyzer = manager.Projects.First(x => x.Key.EndsWith("SdkNetStandardProject.csproj")).Value;
-        EnvironmentOptions options = new EnvironmentOptions
-        {
-            Preference = preference
-        };
-
-        // When
-        DeleteProjectDirectory(analyzer.ProjectFile.Path, "obj");
-        DeleteProjectDirectory(analyzer.ProjectFile.Path, "bin");
-        IAnalyzerResults results = analyzer.Build(options);
-
-        // Then
-        results.First().ProjectGuid.ToString().ShouldBe("016713d9-b665-4272-9980-148801a9b88f");
-    }
-
     [Test]
     public void GetsProjectGuidFromProject([ValueSource(nameof(Preferences))] EnvironmentPreference preference)
     {
@@ -604,29 +536,6 @@ public void BuildsVisualBasicProject()
         result.References.ShouldContain(x => x.Contains("BouncyCastle.Crypto.dll"));
     }
 
-    [Test]
-    public void BuildsLotsOfProjects()
-    {
-        // Given
-        StringWriter log = new StringWriter();
-        AnalyzerManager manager = new AnalyzerManager(
-            GetProjectPath(@"LotsOfProjects\LotsOfProjects.sln"),
-            new AnalyzerManagerOptions
-            {
-                LogWriter = log
-            });
-        List<IProjectAnalyzer> projects = [.. manager.Projects.Values];
-
-        // When
-        List<IAnalyzerResults> analyzerResults = projects
-            .AsParallel()
-            .Select(x => x.Build())
-            .ToList();
-
-        // Then
-        analyzerResults.Count.ShouldBe(50);
-    }
-
     // To produce different versions, create a global.json and then run `dotnet clean` and `dotnet build -bl:SdkNetCore31Project-vX.binlog` from the source project folder
     [TestCase("SdkNetCore31Project-v9.binlog", 9)]
     [TestCase("SdkNetCore31Project-v14.binlog", 14)]
@@ -677,47 +586,6 @@ public void GetsSourceFilesFromBinLogFile(string path, int expectedVersion)
         }.ShouldBeSubsetOf(sourceFiles.Select(x => Path.GetFileName(x).Split('.').TakeLast(2).First()), log.ToString());
     }
 
-    [Test]
-    public static void DuplicateProjectReferences()
-    {
-        // Given
-        StringWriter log = new StringWriter();
-        AnalyzerManager manager = new AnalyzerManager(
-            GetProjectPath(@"DuplicateProjectReferences\MainProject\MainProject.sln"),
-            new AnalyzerManagerOptions
-            {
-                LogWriter = log
-            });
-        List<IProjectAnalyzer> projects = [.. manager.Projects.Values];
-
-        // When
-        List<IAnalyzerResults> analyzerResults = projects
-            .AsParallel()
-            .Select(x => x.Build())
-            .ToList();
-
-        // Then
-        analyzerResults.ForEach(v =>
-        {
-            IAnalyzerResult result = v.Results.FirstOrDefault();
-            result.ProjectReferences.Count().ShouldBeLessThanOrEqualTo(1);
-        });
-    }
-
-    [Test]
-    public void Resolves_additional_files_for_Razor_project()
-    {
-        // Given
-        StringWriter log = new StringWriter();
-        IProjectAnalyzer analyzer = GetProjectAnalyzer(@"RazorClassLibraryTest\RazorClassLibraryTest.csproj", log);
-
-        // When + then
-        analyzer.Build().First().AdditionalFiles.Select(Path.GetFileName)
-            .Should().BeEquivalentTo(
-            "_Imports.razor",
-            "Component1.razor");
-    }
-
     [Test]
     public void Resolves_additional_files()
     {
@@ -772,4 +640,4 @@ private static void DeleteProjectDirectory(string projectFile, string directory)
             Directory.Delete(path, true);
         }
     }
-}
+}

tests/Buildalyzer.Tests/Integration/Solution_specs.cs

@@ -0,0 +1,86 @@
+using Buildalyzer.Environment;
+using Buildalyzer.TestTools;
+
+namespace Solution_specs;
+
+public class Resolves
+{
+    [Test]
+    public void Project_GUID_from_SLN([ValueSource(nameof(Preferences))] EnvironmentPreference preference)
+    {
+        using var ctx = Context.ForSolution("TestProjects.sln");
+
+        ctx.Manager.Projects.Should().HaveCount(30);
+
+        var analyzer = ctx.Manager.Projects.First(x => x.Key.EndsWith("SdkNetStandardProject.csproj")).Value;
+
+        var results = analyzer.Build(new EnvironmentOptions { Preference = preference });
+
+        results.Single().ProjectGuid.Should().Be("016713d9-b665-4272-9980-148801a9b88f");
+    }
+
+    /// <remarks>
+    /// Builds a lot of projects that should all succeed.
+    /// </remarks>
+    [Test]
+    public void Project_builds()
+    {
+        using var ctx = Context.ForSolution("LotsOfProjects/LotsOfProjects.sln");
+
+        var builds = ctx.Manager.Projects.Values
+            .AsParallel()
+            .Select(x => x.Build())
+            .ToArray();
+
+        builds.Should().HaveCount(50);
+        builds.Should().AllSatisfy(b => b.OverallSuccess.Should().BeTrue());
+    }
+
+    private static readonly EnvironmentPreference[] Preferences =
+    [
+#if Is_Windows
+       EnvironmentPreference.Framework,
+#endif
+        EnvironmentPreference.Core
+    ];
+}
+
+public class Filters
+{
+    [Test]
+    public void Projects()
+    {
+        using var ctx = Context.ForSolution(
+            "TestProjects.sln",
+            o => o.ProjectFilter = x => x.AbsolutePath.Contains("Core"));
+
+        ctx.Manager.Projects.Should().HaveCount(6);
+    }
+}
+
+public class Handles
+{
+
+    [Test]
+    public static void Duplicate_project_references()
+    {
+        using var ctx = Context.ForSolution("DuplicateProjectReferences/MainProject/MainProject.sln");
+
+        var results = ctx.Manager.Projects.Values
+            .AsParallel()
+            .Select(x => x.Build().Single())
+            .ToList();
+
+        results.Should().AllSatisfy(
+            res => res.ProjectReferences.Should().HaveCountLessThanOrEqualTo(1));
+    }
+
+    [Test]
+    public void Project_files_only()
+    {
+        using var ctx = Context.ForSolution("TestProjects.sln");
+
+        ctx.Manager.Projects.Keys.Should().AllSatisfy(
+            path => path.Should().NotContain("TestEmptySolutionFolder"));
+    }
+}