Fix problem with dangling reader/writer threads blocked on sockets that won't let the process to exit

Author: xoofx

src/MsBuildPipeLogger.Logger/PipeWriter.cs

@@ -28,7 +28,7 @@ protected PipeWriter(PipeStream pipeStream)
             _binaryWriter = new BinaryWriter(_memoryStream);
             _argsWriter = new BuildEventArgsWriter(_binaryWriter);
 
-            new Thread(() =>
+            Thread writerThread = new Thread(() =>
             {
                 BuildEventArgs eventArgs;
                 while ((eventArgs = TakeEventArgs()) != null)
@@ -46,7 +46,11 @@ protected PipeWriter(PipeStream pipeStream)
                     _pipeStream.Flush();
                 }
                 _doneProcessing.Set();
-            }).Start();
+            })
+            {
+                IsBackground = true,
+            };
+            writerThread.Start();
         }
 
         private BuildEventArgs TakeEventArgs()

src/MsBuildPipeLogger.Server/PipeLoggerServer.cs

@@ -46,7 +46,7 @@ protected PipeLoggerServer(TPipeStream pipeStream, CancellationToken cancellatio
             _buildEventArgsReader = new BuildEventArgsReaderProxy(_binaryReader);
             CancellationToken = cancellationToken;
 
-            new Thread(() =>
+            Thread readerThread = new Thread(() =>
             {
                 try
                 {
@@ -68,7 +68,12 @@ protected PipeLoggerServer(TPipeStream pipeStream, CancellationToken cancellatio
                 Buffer.Write(new byte[1] { 0 }, 0, 1);
 
                 Buffer.CompleteAdding();
-            }).Start();
+            })
+            {
+                IsBackground = true
+            };
+
+            readerThread.Start();
         }
 
         protected abstract void Connect();