Add the offset and offsetEnd fields to all nodes

Author: johannescoetzee

schema/src/main/scala/io/shiftleft/codepropertygraph/schema/Ast.scala

@@ -81,10 +81,14 @@ object Ast extends SchemaBase {
                     |start column number of the code represented by the node.
                     |For machine-code-based and bytecode-based frontends, `LINE_NUMBER` contains
                     |the address at which the code starts while `COLUMN_NUMBER` is undefined.
+                    |
+                    |The optional `OFFSET` and `OFFSET_END` specify the start
+                    |and exclusive end position of the code belonging to a node within the corresponding
+                    |`FILE` nodes `CONTENT` property.
                     |""".stripMargin
       )
       .addProperties(order, code)
-      .addProperties(lineNumber, columnNumber)
+      .addProperties(lineNumber, columnNumber, offset, offsetEnd)
 
     // The following nodes from other schemas are AST nodes
 

schema/src/main/scala/io/shiftleft/codepropertygraph/schema/Method.scala

@@ -61,10 +61,6 @@ object Method extends SchemaBase {
             |the name of the source file is specified in `FILENAME`. An optional hash value
             |MAY be calculated over the function contents and included in the `HASH` field.
             |
-            |The optional `OFFSET` and `OFFSET_END` specify the start
-            |and exclusive end position of the code belonging to a method within the corresponding
-            |`FILE` nodes `CONTENT` property.
-            |
             |Finally, the fully qualified name of the program constructs that the method
             |is immediately contained in is stored in the `AST_PARENT_FULL_NAME` field
             |and its type is indicated in the `AST_PARENT_TYPE` field to be one of
@@ -74,7 +70,6 @@ object Method extends SchemaBase {
       .protoId(ProtoIds.Method)
       .addProperties(fullName, isExternal, signature, lineNumberEnd, columnNumberEnd, filename, hash)
       .addProperties(astParentType, astParentFullName)
-      .addProperties(offset, offsetEnd)
       .extendz(declaration)
       .primaryKey(name)
 

schema/src/main/scala/io/shiftleft/codepropertygraph/schema/Type.scala

@@ -97,10 +97,6 @@ object Type extends SchemaBase {
             |known to be an alias of another type (as for example introduced via the C
             |`typedef` statement), the name of the alias is stored in `ALIAS_TYPE_FULL_NAME`.
             |
-            |The optional `OFFSET` and `OFFSET_END` specify the start
-            |and exclusive end position of the code belonging to a `TYPE_DECL` within the corresponding
-            |`FILE` nodes `CONTENT` property.
-            |
             |Finally, the fully qualified name of the program constructs that the type declaration
             |is immediately contained in is stored in the `AST_PARENT_FULL_NAME` field
             |and its type is indicated in the `AST_PARENT_TYPE` field to be one of
@@ -111,7 +107,6 @@ object Type extends SchemaBase {
       .protoId(ProtoIds.TypeDecl)
       .addProperties(name, fullName, isExternal, inheritsFromTypeFullName, aliasTypeFullName, filename)
       .addProperties(astParentType, astParentFullName)
-      .addProperties(offset, offsetEnd)
       .primaryKey(name)
 
     val typeParameter: NodeType = builder