Skip to content

Commit 98b172a

Browse files
committed
gitlab-ci: Don't hardcode release version
Thanks to Jan Tojnar who found a work-around: https://gitlab.gnome.org/GNOME/calls/-/merge_requests/770 This uses the artifacts:reports:dotenv feature to pass environment variables to the deploy stage: https://docs.gitlab.com/ci/variables/#pass-an-environment-variable-to-another-job I didn't test the change with the sandbox yet.
1 parent e7584e9 commit 98b172a

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

.gitlab-ci.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ include:
22
- component: "gitlab.gnome.org/GNOME/citemplates/release-service@master"
33
inputs:
44
dist-job-name: "dist"
5-
tarball-artifact-path: "libxml2-dist/libxml2-2.14.0.tar.xz"
5+
tarball-artifact-path: "${TARBALL_ARTIFACT_PATH}"
66

77
.test:
88
image: registry.gitlab.gnome.org/gnome/libxml2
@@ -300,9 +300,12 @@ dist:
300300
image: registry.gitlab.gnome.org/gnome/libxml2
301301
script:
302302
- sh .gitlab-ci/dist.sh
303+
- echo "TARBALL_ARTIFACT_PATH=$(ls libxml2-dist/*.tar.xz)" >> build.env
303304
artifacts:
304305
paths:
305306
- libxml2-dist/*.tar.xz
307+
reports:
308+
dotenv: build.env
306309

307310
pages:
308311
script:

MAINTAINERS.md

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,9 +52,6 @@ You can get started by running
5252

5353
Update the version number in `VERSION` if you haven't done so already.
5454

55-
IMPORTANT: Update the version number of `tarball-artifact-path` in
56-
`.gitlab-ci.yml`. This must be done manually for now.
57-
5855
### Commit and verify tarball
5956

6057
Release tarballs are generated with a CI job and the `.gitlab-ci/dist.sh`

0 commit comments

Comments
 (0)