Skip to content

Commit 903660b

Browse files
authored
Fix graph to always update after all filter changes (dotnet#13524)
1 parent 58c3d27 commit 903660b

File tree

1 file changed

+16
-12
lines changed

1 file changed

+16
-12
lines changed

src/Aspire.Dashboard/Components/Pages/Resources.razor.cs

Lines changed: 16 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -159,22 +159,24 @@ private bool Filter(ResourceViewModel resource)
159159

160160
private async Task OnAllFilterVisibilityCheckedChangedAsync()
161161
{
162-
await ClearSelectedResourceAsync();
163-
await _dataGrid.SafeRefreshDataAsync();
162+
await VisibleResourcesChangedAsync();
164163
UpdateMenuButtons();
165164
await this.AfterViewModelChangedAsync(_contentLayout, waitToApplyMobileChange: false);
166165
}
167166

168167
private async Task OnResourceFilterVisibilityChangedAsync(string resourceType, bool isVisible)
169168
{
170-
await UpdateResourceGraphResourcesAsync();
171-
await ClearSelectedResourceAsync();
172-
await _dataGrid.SafeRefreshDataAsync();
169+
await VisibleResourcesChangedAsync();
173170
UpdateMenuButtons();
174171
await this.AfterViewModelChangedAsync(_contentLayout, waitToApplyMobileChange: false);
175172
}
176173

177174
private async Task HandleSearchFilterChangedAsync()
175+
{
176+
await VisibleResourcesChangedAsync();
177+
}
178+
179+
private async Task VisibleResourcesChangedAsync()
178180
{
179181
await UpdateResourceGraphResourcesAsync();
180182
await ClearSelectedResourceAsync();
@@ -524,13 +526,15 @@ private void UpdateMenuButtons()
524526
_showHiddenResources,
525527
_resourceByName.Values,
526528
SessionStorage,
527-
EventCallback.Factory.Create<bool>(this,
528-
async value =>
529-
{
530-
_showHiddenResources = value;
531-
UpdateMenuButtons();
532-
await _dataGrid.SafeRefreshDataAsync();
533-
}));
529+
EventCallback.Factory.Create<bool>(
530+
this,
531+
async value =>
532+
{
533+
_showHiddenResources = value;
534+
UpdateMenuButtons();
535+
536+
await VisibleResourcesChangedAsync();
537+
}));
534538
}
535539

536540
private bool HasCollapsedResources()

0 commit comments

Comments
 (0)