Merge pull request #30 from ShipEngine/KaseyCantu/chore/update-solargraph

chore: Update solargraph, fix lint, add lint back into CI

Author: KaseyCantu

.github/workflows/CI.yaml

@@ -23,8 +23,8 @@ jobs:
         with:
           bundler-cache: true
 
-#      - name: Lint
-#        run: bundle exec rake lint
+      - name: Lint
+        run: bundle exec rake lint
 
       - name: Test
         run: bundle exec rake test

.pryrc

@@ -1,13 +1,14 @@
 # rubocop:disable
 
 # frozen_string_literal: true
+
 # === EDITOR ===
-Pry.editor = "vi"
+Pry.editor = 'vi'
 
 # === COLORS ===
-unless ENV["PRY_BW"]
+unless ENV['PRY_BW']
   Pry.color = true
-  Pry.config.theme = "railscasts"
+  Pry.config.theme = 'railscasts'
 end
 
 # === Listing config ===
@@ -25,7 +26,7 @@ Pry.config.ls.private_method_color = :bright_black
 # awesome_print gem: great syntax colorized printing
 # look at ~/.aprc for more settings for awesome_print
 begin
-  require "awesome_print"
+  require 'awesome_print'
   # The following line enables awesome_print for all pry output,
   # and it also enables paging
   Pry.config.print = proc { |output, value| Pry::Helpers::BaseHelpers.stagger_output("=> #{value.ai}", output) }
@@ -35,7 +36,7 @@ begin
     Formatter.prepend(Module.new do
       def awesome_self(object, type)
         if type == :string && @options[:string_limit] && object.inspect.to_s.length > @options[:string_limit]
-          colorize(object.inspect.to_s[0..@options[:string_limit]] + "...", type)
+          colorize("#{object.inspect.to_s[0..@options[:string_limit]]}...", type)
         else
           super(object, type)
         end
@@ -46,11 +47,11 @@ begin
   AwesomePrint.defaults = {
     string_limit: 80,
     indent: 2,
-    multiline: true,
+    multiline: true
   }
   AwesomePrint.pry!
 rescue err
-  puts "gem install awesome_print  # <-- highly recommended"
+  puts 'gem install awesome_print  # <-- highly recommended'
 end
 
 # rubocop:enable

.rubocop.yml

@@ -1,11 +1,12 @@
 AllCops:
   NewCops: enable # https://docs.rubocop.org/rubocop/1.11/versioning.html#pending-cops
   SuggestExtensions: false
-  TargetRubyVersion: 2.6
+  TargetRubyVersion: 3.2.2
   Exclude:
     - bin/**/*
     - tmp/**/*
     - vendor/**/*
+    - test/**/*
     - lib/shipengine/utils/base58.rb
     - !ruby/regexp /(foo|bar|baz)\.rb/
 

CHANGELOG.md

@@ -1,11 +0,0 @@
-# Changelog
-
-## 1.0.0 (2023-06-15)
-
-
-### Bug Fixes
-
-* [SE-119] Get SDK build working and First Gem published :truck: ([dbba243](https://github.com/ShipEngine/shipengine-ruby/commit/dbba243460e85fbe5b644078a933ca36c5f2c57d))
-* fixup CD ([fcb16ad](https://github.com/ShipEngine/shipengine-ruby/commit/fcb16ada4628dbb330f3c33f0f5ba58bcfe4d8ed))
-
-## Changelog

Gemfile

@@ -1,35 +1,35 @@
 # frozen_string_literal: true
 
-source "https://rubygems.org"
+source 'https://rubygems.org'
 
 group :development do
-  gem "guard"
-  gem "guard-minitest"
-  gem "pry"
-  gem "solargraph", require: false
-  gem "yard"
-  gem "ruby-debug-ide", require: false
-  gem "rubocop-shopify", require: false
-  gem "awesome_print"
-  gem "overcommit"
+  gem 'awesome_print'
+  gem 'guard'
+  gem 'guard-minitest'
+  gem 'overcommit'
+  gem 'pry'
+  gem 'rubocop-shopify', require: false
+  gem 'ruby-debug-ide', require: false
+  gem 'solargraph', require: false
+  gem 'yard'
 end
 
 group :test do
-  gem "minitest"
-  gem "minitest-fail-fast"
-  gem "minitest-focus"
-  gem "minitest-hooks"
-  gem "minitest-line"
-  gem "minitest-tagz"
-  gem "minitest-reporters"
-  gem "simplecov", require: false
-  gem "webmock"
-  gem "spy"
+  gem 'minitest'
+  gem 'minitest-fail-fast'
+  gem 'minitest-focus'
+  gem 'minitest-hooks'
+  gem 'minitest-line'
+  gem 'minitest-reporters'
+  gem 'minitest-tagz'
+  gem 'simplecov', require: false
+  gem 'spy'
+  gem 'webmock'
 end
 
 group :test, :development do
-  gem "rake"
-  gem "rubocop", require: false
+  gem 'rake'
+  gem 'rubocop', require: false
 end
 
 gemspec

Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    shipengine_sdk (1.0.0)
+    shipengine_sdk (0.0.0)
       faraday (>= 1.4)
       faraday_middleware (>= 1.0)
       hashie (>= 3.4)
@@ -15,13 +15,13 @@ GEM
     ast (2.4.2)
     awesome_print (1.9.2)
     backport (1.2.0)
-    benchmark (0.1.1)
+    benchmark (0.2.1)
     builder (3.2.4)
     childprocess (4.1.0)
     coderay (1.1.3)
     crack (0.4.5)
       rexml
-    diff-lcs (1.4.4)
+    diff-lcs (1.5.0)
     docile (1.4.0)
     e2mmap (0.1.0)
     faraday (1.5.1)
@@ -61,9 +61,9 @@ GEM
     hashdiff (1.0.1)
     hashie (3.6.0)
     iniparse (1.5.0)
-    jaro_winkler (1.5.4)
+    jaro_winkler (1.5.6)
     json (2.6.3)
-    kramdown (2.3.1)
+    kramdown (2.4.0)
       rexml
     kramdown-parser-gfm (1.1.0)
       kramdown (~> 2.0)
@@ -72,7 +72,7 @@ GEM
       rb-inotify (~> 0.9, >= 0.9.10)
     lumberjack (1.2.8)
     method_source (1.0.0)
-    mini_portile2 (2.5.3)
+    mini_portile2 (2.8.2)
     minitest (5.14.4)
     minitest-fail-fast (0.1.0)
       minitest (~> 5)
@@ -91,8 +91,8 @@ GEM
       minitest (~> 5)
     multipart-post (2.1.1)
     nenv (0.3.0)
-    nokogiri (1.11.7)
-      mini_portile2 (~> 2.5.0)
+    nokogiri (1.15.2)
+      mini_portile2 (~> 2.8.2)
       racc (~> 1.4)
     notiffany (0.1.3)
       nenv (~> 0.1)
@@ -115,8 +115,9 @@ GEM
     rb-fsevent (0.11.0)
     rb-inotify (0.10.1)
       ffi (~> 1.0)
+    rbs (2.8.4)
     regexp_parser (2.8.1)
-    reverse_markdown (2.0.0)
+    reverse_markdown (2.1.1)
       nokogiri
     rexml (3.2.5)
     rubocop (1.52.1)
@@ -131,8 +132,8 @@ GEM
       unicode-display_width (>= 2.4.0, < 3.0)
     rubocop-ast (1.29.0)
       parser (>= 3.2.1.0)
-    rubocop-shopify (2.2.0)
-      rubocop (~> 1.18)
+    rubocop-shopify (2.14.0)
+      rubocop (~> 1.51)
     ruby-debug-ide (0.7.2)
       rake (>= 0.8.1)
     ruby-progressbar (1.13.0)
@@ -144,30 +145,31 @@ GEM
       simplecov_json_formatter (~> 0.1)
     simplecov-html (0.12.3)
     simplecov_json_formatter (0.1.3)
-    solargraph (0.42.4)
+    solargraph (0.49.0)
       backport (~> 1.2)
       benchmark
-      bundler (>= 2.4.14)
+      bundler (~> 2.0)
       diff-lcs (~> 1.4)
       e2mmap
       jaro_winkler (~> 1.5)
       kramdown (~> 2.3)
       kramdown-parser-gfm (~> 1.1)
       parser (~> 3.0)
-      reverse_markdown (>= 1.0.5, < 3)
-      rubocop (>= 0.52)
+      rbs (~> 2.0)
+      reverse_markdown (~> 2.0)
+      rubocop (~> 1.38)
       thor (~> 1.0)
       tilt (~> 2.0)
       yard (~> 0.9, >= 0.9.24)
     spy (1.0.1)
-    thor (1.1.0)
-    tilt (2.0.10)
+    thor (1.2.2)
+    tilt (2.2.0)
     unicode-display_width (2.4.2)
     webmock (3.13.0)
       addressable (>= 2.3.6)
       crack (>= 0.3.2)
       hashdiff (>= 0.4.0, < 2.0.0)
-    yard (0.9.26)
+    yard (0.9.34)
 
 PLATFORMS
   ruby

Guardfile

@@ -2,12 +2,12 @@
 
 # More info at https://github.com/guard/guard#readme
 guard :minitest do
-  watch(%r{^lib/(.*)\.rb$}) { "test" } # run all tests if code is modified
+  watch(%r{^lib/(.*)\.rb$}) { 'test' } # run all tests if code is modified
   watch(%r{^test/(.*)_test\.rb$}) # only run specific test file if test is modified
 
   # configuration
-  watch(%r{^test/test_helper\.rb$}) { "test" }
-  watch(%r{^test/test_utility/(.*)\.rb$}) { "test" }
+  watch(%r{^test/test_helper\.rb$}) { 'test' }
+  watch(%r{^test/test_utility/(.*)\.rb$}) { 'test' }
 end
 
 # https://stackoverflow.com/questions/23571163/clear-previous-tests-in-rspec-while-running-new-tests-using-guard

Rakefile

@@ -1,32 +1,32 @@
 # frozen_string_literal: true
 
 begin
-  require "bundler/setup"
+  require 'bundler/setup'
 rescue LoadError
-  puts "You must `gem install bundler` and `bundle install` to run rake tasks"
+  puts 'You must `gem install bundler` and `bundle install` to run rake tasks'
 end
 
-require "rubocop/rake_task"
-require "bundler/gem_tasks"
-require "rake/testtask"
+require 'rubocop/rake_task'
+require 'bundler/gem_tasks'
+require 'rake/testtask'
 
 Rake::TestTask.new(:test) do |t|
-  t.libs << "test"
-  t.libs << "lib"
+  t.libs << 'test'
+  t.libs << 'lib'
   t.verbose = true
   t.warning = false
-  t.pattern = "test/**/*_test.rb"
+  t.pattern = 'test/**/*_test.rb'
 end
 
 RuboCop::RakeTask.new(:lint) do |t|
-  t.options = ["--display-cop-names"]
+  t.options = ['--display-cop-names']
 end
 
 RuboCop::RakeTask.new(:fix) do |t|
-  t.options = ["--auto-correct-all"]
+  t.options = ['--auto-correct-all']
 end
 
 task :default do
-  Rake::Task["test"].execute
-  Rake::Task["lint"].execute
+  Rake::Task['test'].execute
+  Rake::Task['lint'].execute
 end