Skip to content

Commit 590c28f

Browse files
authored
Merge pull request #25 from ShipEngine/KaseyCantu/fix/SE-119-get-sdk-working-and-first-gem-published
fix: [SE-119] Get SDK build working and First Gem published 🚚
2 parents f90615b + cd0b931 commit 590c28f

File tree

7 files changed

+40
-42
lines changed

7 files changed

+40
-42
lines changed

.github/workflows/CD.yaml

Lines changed: 21 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: CD
1+
name: Continuous Deployment
22

33
on:
44
push:
@@ -9,37 +9,39 @@ jobs:
99
release-please:
1010
runs-on: ubuntu-latest
1111
steps:
12-
- uses: GoogleCloudPlatform/release-please-action@v2
12+
- name: Release Please
1313
id: release
14+
uses: GoogleCloudPlatform/release-please-action@v2
1415
with:
1516
release-type: ruby
1617
package-name: shipengine
1718
bump-minor-pre-major: true
18-
version-file: "lib/release/please/demo/version.rb"
19+
version-file: lib/shipengine/version.rb
1920

20-
# Checkout code if release was created
21-
- uses: actions/checkout@v2
21+
- name: Checkout Repository
22+
uses: actions/checkout@v3
23+
with:
24+
fetch-depth: 0
2225
if: ${{ steps.release.outputs.release_created }}
2326

24-
# Setup ruby if a release was created
25-
- uses: ruby/setup-ruby@v1
26-
with:
27-
ruby-version: 3.0.0
27+
- name: Setup Ruby
28+
uses: ruby/setup-ruby@v1
2829
if: ${{ steps.release.outputs.release_created }}
2930

30-
# Bundle install
31-
- run: bundle install
31+
- name: Install project dependencies
32+
run: bundle install
3233
if: ${{ steps.release.outputs.release_created }}
3334

34-
# Publish
35-
- name: publish gem
35+
- name: Publish ShipEngine Gem
36+
if: ${{ steps.release.outputs.release_created }}
3637
run: |
3738
mkdir -p $HOME/.gem
3839
touch $HOME/.gem/credentials
3940
chmod 0600 $HOME/.gem/credentials
40-
printf -- "---\n:rubygems_api_key: ${GEM_HOST_API_KEY}\n" > $HOME/.gem/credentials
41-
gem build *.gemspec
42-
gem push *.gem
43-
env:
44-
GEM_HOST_API_KEY: "${{secrets.RUBYGEMS_API_KEY}}"
45-
if: ${{ steps.release.outputs.release_created }}
41+
42+
cat <<EOF >$HOME/.gem/credentials
43+
---
44+
:rubygems_api_key: ${{ secrets.RUBYGEMS_API_KEY }}
45+
EOF
46+
47+
rake release

.github/workflows/CI.yaml

Lines changed: 9 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: CI
1+
name: Continuous Integration
22

33
on:
44
push:
@@ -12,22 +12,19 @@ on:
1212

1313
jobs:
1414
ci:
15-
strategy:
16-
fail-fast: false
17-
matrix:
18-
os: [ ubuntu-latest ]
19-
# Due to https://github.com/actions/runner/issues/849, we have to use quotes for '3.0'
20-
ruby: [ 2.6, 2.7, "3.0" ]
21-
name: Build / Test
22-
runs-on: ${{ matrix.os }}
15+
name: Build, Lint, and Test
16+
runs-on: ubuntu-latest
2317
steps:
24-
- uses: actions/checkout@v2
18+
- name: Checkout Repository
19+
uses: actions/checkout@v3
20+
2521
- name: Set up Ruby and Build
2622
uses: ruby/setup-ruby@v1
2723
with:
28-
ruby-version: ${{ matrix.ruby }}
29-
bundler-cache: true # runs 'bundle install' and caches installed gems automatically
24+
bundler-cache: true
25+
3026
- name: Lint
3127
run: bundle exec rake lint
28+
3229
- name: Test
3330
run: bundle exec rake test

.ruby-version

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
2.6.6
1+
3.2.2

Gemfile.lock

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
PATH
22
remote: .
33
specs:
4-
shipengine (0.1.0)
5-
faraday (~> 1.4)
6-
faraday_middleware (~> 1.0)
7-
hashie (~> 3.4)
4+
shipengine (0.0.0)
5+
faraday (>= 1.4)
6+
faraday_middleware (>= 1.0)
7+
hashie (>= 3.4)
88

99
GEM
1010
remote: https://rubygems.org/

lib/shipengine/domain/carriers.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
require "hashie"
44
require_relative "carriers/list_carriers"
55
require "shipengine/constants"
6-
require "pry"
76

87
module ShipEngine
98
module Domain

lib/shipengine/version.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# frozen_string_literal: true
22

33
module ShipEngine
4-
VERSION = "0.1.0"
4+
VERSION = "0.0.0"
55
end

shipengine.gemspec

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,9 @@ Gem::Specification.new do |spec|
1111
spec.license = "Apache-2.0"
1212
spec.files = Dir["*.{md,txt}", "{lib}/**/*"]
1313
spec.require_paths = ["lib"]
14-
spec.required_ruby_version = ">= 2.6"
14+
spec.required_ruby_version = ">= 3.2.2"
1515

16-
spec.add_runtime_dependency("hashie", "~> 3.4")
17-
spec.add_runtime_dependency("faraday", "~> 1.4")
18-
spec.add_runtime_dependency("faraday_middleware", "~> 1.0")
16+
spec.add_runtime_dependency("hashie", ">= 3.4")
17+
spec.add_runtime_dependency("faraday", ">= 1.4")
18+
spec.add_runtime_dependency("faraday_middleware", ">= 1.0")
1919
end

0 commit comments

Comments
 (0)