Skip to content

Minor derp in dummy_dt functionΒ #27

@GeoZac

Description

@GeoZac

When generating dummy dt, the PRODUCT_MANUFACTURER variable get sets with a minor derp

printf "\nPRODUCT_MANUFACTURER := "$BRAND"" >> "$DT_DIR"/lineage_"$DEVICE".mk

For instance, in the case of Xiaomi devices, it gets written as
PRODUCT_MANUFACTURER := xiaomi [1]
instead of
PRODUCT_MANUFACTURER := Xiaomi [2]

  1. https://github.com/AndroidBlobs/device_xiaomi_surya/blob/46efa22aa8274a6d919961fa2843f831c71c0cce/lineage_surya.mk#L13
  2. https://github.com/LineageOS/android_device_xiaomi_surya/blob/4f03c8bd9cd3b51e67b815ea4eaafd8a032e811d/lineage_surya.mk#L31

on other OEMs, incorrect values gets written, eg. OnePlus

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions