refactor: improve tests with side effects of setup checks

Author: kieran-osgood-shopify

modules/@shopify/checkout-sheet-kit/android/src/main/java/com/shopify/reactnative/checkoutsheetkit/RCTCheckoutWebView.java

@@ -128,7 +128,7 @@ public void setAuth(String authToken) {
     scheduleSetupIfNeeded();
   }
 
-  private void scheduleSetupIfNeeded() {
+  void scheduleSetupIfNeeded() {
     if (pendingSetup) {
       return;
     }
@@ -205,7 +205,7 @@ private CheckoutWebViewEventProcessor getCheckoutWebViewEventProcessor() {
     );
   }
 
-  private void removeCheckout() {
+  void removeCheckout() {
     Log.d(TAG, "removeCheckout: Called, webview exists: " + (checkoutWebView != null));
     if (checkoutWebView != null) {
       Log.d(TAG, "removeCheckout: Destroying webview");

modules/@shopify/checkout-sheet-kit/android/src/test/java/com/shopify/reactnative/checkoutsheetkit/RCTCheckoutWebViewTest.java

@@ -136,7 +136,10 @@ public void testSetCheckoutUrl_withSameUrl_doesNotScheduleSetup() throws Excepti
         Handler mockHandler = mock(Handler.class);
         when(mockHandler.post(any(Runnable.class))).thenReturn(true);
         setPrivateField(webView, "mainHandler", mockHandler);
-        setPrivateField(webView, "checkoutUrl", "https://shopify.com/checkout");
+
+        webView.setCheckoutUrl("https://shopify.com/checkout");
+        reset(mockHandler);
+        when(mockHandler.post(any(Runnable.class))).thenReturn(true);
 
         webView.setCheckoutUrl("https://shopify.com/checkout");
 
@@ -145,12 +148,15 @@ public void testSetCheckoutUrl_withSameUrl_doesNotScheduleSetup() throws Excepti
 
     @Test
     public void testSetCheckoutUrl_withNull_clearsUrlAndLastConfiguration() throws Exception {
-        setPrivateField(webView, "checkoutUrl", "https://shopify.com/checkout");
+        RCTCheckoutWebView spyWebView = spy(new RCTCheckoutWebView(mockContext));
+        doNothing().when(spyWebView).scheduleSetupIfNeeded();
+        doNothing().when(spyWebView).removeCheckout();
 
-        webView.setCheckoutUrl(null);
+        spyWebView.setCheckoutUrl("https://shopify.com/checkout");
+        spyWebView.setCheckoutUrl(null);
 
-        assertThat(getPrivateField(webView, "checkoutUrl")).isNull();
-        assertThat(getPrivateField(webView, "lastConfiguration")).isNull();
+        assertThat(getPrivateField(spyWebView, "checkoutUrl")).isNull();
+        assertThat(getPrivateField(spyWebView, "lastConfiguration")).isNull();
     }
 
     @Test
@@ -169,7 +175,10 @@ public void testSetAuth_withSameToken_doesNotScheduleSetup() throws Exception {
         Handler mockHandler = mock(Handler.class);
         when(mockHandler.post(any(Runnable.class))).thenReturn(true);
         setPrivateField(webView, "mainHandler", mockHandler);
-        setPrivateField(webView, "auth", "existing-token");
+
+        webView.setAuth("existing-token");
+        reset(mockHandler);
+        when(mockHandler.post(any(Runnable.class))).thenReturn(true);
 
         webView.setAuth("existing-token");
 
@@ -322,6 +331,50 @@ public void testSetup_alwaysResetsPendingSetupFlag() throws Exception {
         assertThat(getPrivateField(webView, "pendingSetup")).isEqualTo(false);
     }
 
+    @Test
+    public void testSetCheckoutUrl_withNonNullUrl_callsScheduleSetupIfNeeded() {
+        RCTCheckoutWebView spyWebView = spy(new RCTCheckoutWebView(mockContext));
+        doNothing().when(spyWebView).scheduleSetupIfNeeded();
+
+        spyWebView.setCheckoutUrl("https://shopify.com/checkout");
+
+        verify(spyWebView).scheduleSetupIfNeeded();
+    }
+
+    @Test
+    public void testSetCheckoutUrl_withNullUrl_callsRemoveCheckout() {
+        RCTCheckoutWebView spyWebView = spy(new RCTCheckoutWebView(mockContext));
+        doNothing().when(spyWebView).scheduleSetupIfNeeded();
+        doNothing().when(spyWebView).removeCheckout();
+
+        spyWebView.setCheckoutUrl("https://shopify.com/checkout");
+        spyWebView.setCheckoutUrl(null);
+
+        verify(spyWebView).removeCheckout();
+    }
+
+    @Test
+    public void testSetAuth_callsScheduleSetupIfNeeded() {
+        RCTCheckoutWebView spyWebView = spy(new RCTCheckoutWebView(mockContext));
+        doNothing().when(spyWebView).scheduleSetupIfNeeded();
+
+        spyWebView.setAuth("auth-token");
+
+        verify(spyWebView).scheduleSetupIfNeeded();
+    }
+
+    @Test
+    public void testSetCheckoutUrlAndAuth_batchesToSingleSetup() throws Exception {
+        Handler mockHandler = mock(Handler.class);
+        when(mockHandler.post(any(Runnable.class))).thenReturn(true);
+        setPrivateField(webView, "mainHandler", mockHandler);
+
+        webView.setCheckoutUrl("https://shopify.com/checkout");
+        webView.setAuth("auth-token");
+
+        verify(mockHandler, times(1)).post(any(Runnable.class));
+    }
+
     private void setPrivateField(Object object, String fieldName, Object value) throws Exception {
         Field field = object.getClass().getDeclaredField(fieldName);
         field.setAccessible(true);