Skip to content

Commit 49376bb

Browse files
Fix pod install failing on expo54 (#334)
fix:ios pod install failing on expo54
1 parent 7741b8e commit 49376bb

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed

modules/@shopify/checkout-sheet-kit/RNShopifyCheckoutSheetKit.podspec

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,17 @@ Pod::Spec.new do |s|
2424
s.dependency "ShopifyCheckoutSheetKit/AcceleratedCheckouts", "~> 3.4.0-rc.6"
2525

2626
if fabric_enabled
27-
install_modules_dependencies(s)
27+
# Use React Native's helper if available, otherwise add dependencies directly
28+
if defined?(install_modules_dependencies)
29+
install_modules_dependencies(s)
30+
else
31+
# Fallback: manually specify dependencies for New Architecture
32+
s.dependency "React-Codegen"
33+
s.dependency "RCT-Folly", :modular_headers => true
34+
s.dependency "RCTRequired"
35+
s.dependency "RCTTypeSafety"
36+
s.dependency "ReactCommon/turbomodule/core"
37+
end
2838

2939
s.compiler_flags = folly_compiler_flags + " -DRCT_NEW_ARCH_ENABLED=1"
3040

@@ -33,11 +43,5 @@ Pod::Spec.new do |s|
3343
"OTHER_CPLUSPLUSFLAGS" => "-DFOLLY_NO_CONFIG -DFOLLY_MOBILE=1 -DFOLLY_USE_LIBCPP=1",
3444
"CLANG_CXX_LANGUAGE_STANDARD" => "c++17"
3545
}
36-
37-
s.dependency "React-Codegen"
38-
s.dependency "RCT-Folly"
39-
s.dependency "RCTRequired"
40-
s.dependency "RCTTypeSafety"
41-
s.dependency "ReactCommon/turbomodule/core"
4246
end
4347
end

sample/ios/Podfile.lock

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@ PODS:
4747
- React-RCTText (= 0.80.2)
4848
- React-RCTVibration (= 0.80.2)
4949
- React-callinvoker (0.80.2)
50-
- React-Codegen (0.1.0)
5150
- React-Core (0.80.2):
5251
- boost
5352
- DoubleConversion
@@ -2496,7 +2495,6 @@ PODS:
24962495
- RCT-Folly/Fabric
24972496
- RCTRequired
24982497
- RCTTypeSafety
2499-
- React-Codegen
25002498
- React-Core
25012499
- React-debug
25022500
- React-Fabric
@@ -2640,7 +2638,6 @@ DEPENDENCIES:
26402638

26412639
SPEC REPOS:
26422640
trunk:
2643-
- React-Codegen
26442641
- ShopifyCheckoutSheetKit
26452642
- SocketRocket
26462643

@@ -2821,7 +2818,6 @@ SPEC CHECKSUMS:
28212818
RCTTypeSafety: cb974efcdc6695deedf7bf1eb942f2a0603a063f
28222819
React: e7a4655b09d0e17e54be188cc34c2f3e2087318a
28232820
React-callinvoker: 62192daaa2f30c3321fc531e4f776f7b09cf892b
2824-
React-Codegen: 4b8b4817cea7a54b83851d4c1f91f79aa73de30a
28252821
React-Core: b23cdaaa9d76389d958c06af3c57aa6ad611c542
28262822
React-CoreModules: 8e0f562e5695991e455abbebe1e968af71d52553
28272823
React-cxxreact: 6ccbe0cc2c652b29409b14b23cfb3cd74e084691
@@ -2886,7 +2882,7 @@ SPEC CHECKSUMS:
28862882
RNGestureHandler: fabb15d507aebf871bf391ec1cdded706c58688b
28872883
RNReanimated: 288616f9c66ff4b0911f3862ffcf4104482a2adc
28882884
RNScreens: 26bb60cdb2ef2ca06fd87feefc495072f25982a7
2889-
RNShopifyCheckoutSheetKit: 1c83a5e93cd76358d40a5ecdeaff7075772d35d8
2885+
RNShopifyCheckoutSheetKit: 5f795d995c1dce7393436edb3d4b2cdab86e5c2a
28902886
RNVectorIcons: be4d047a76ad307ffe54732208fb0498fcb8477f
28912887
ShopifyCheckoutSheetKit: 17677d042e5bae7cf330abc6ea09c165a37526e7
28922888
SocketRocket: d4aabe649be1e368d1318fdf28a022d714d65748

0 commit comments

Comments
 (0)