@@ -145,15 +145,15 @@ if ! "$cygwin" && ! "$darwin" && ! "$nonstop" ; then
145145 case $MAX_FD in # (
146146 max* )
147147 # In POSIX sh, ulimit -H is undefined. That's why the result is checked to see if it worked.
148- # shellcheck disable=SC3045
148+ # shellcheck disable=SC2039, SC3045
149149 MAX_FD=$( ulimit -H -n ) ||
150150 warn " Could not query maximum file descriptor limit"
151151 esac
152152 case $MAX_FD in # (
153153 ' ' | soft) : ;; # (
154154 * )
155155 # In POSIX sh, ulimit -n is undefined. That's why the result is checked to see if it worked.
156- # shellcheck disable=SC3045
156+ # shellcheck disable=SC2039, SC3045
157157 ulimit -n " $MAX_FD " ||
158158 warn " Could not set maximum file descriptor limit to $MAX_FD "
159159 esac
@@ -201,11 +201,11 @@ if "$cygwin" || "$msys" ; then
201201 done
202202fi
203203
204- # Collect all arguments for the java command;
205- # * $ DEFAULT_JVM_OPTS, $ JAVA_OPTS, and $GRADLE_OPTS can contain fragments of
206- # shell script including quotes and variable substitutions, so put them in
207- # double quotes to make sure that they get re- expanded; and
208- # * put everything else in single quotes, so that it's not re-expanded .
204+ # Collect all arguments for the java command:
205+ # * DEFAULT_JVM_OPTS, JAVA_OPTS, JAVA_OPTS, and optsEnvironmentVar are not allowed to contain shell fragments,
206+ # and any embedded shellness will be escaped.
207+ # * For example: A user cannot expect ${Hostname} to be expanded, as it is an environment variable and will be
208+ # treated as '${Hostname}' itself on the command line .
209209
210210set -- \
211211 " -Dorg.gradle.appname=$APP_BASE_NAME " \
0 commit comments