Improve linting (#243)

* Improve linting

* Update copy_license script to ignore identation

* Revert internal identifier

Author: markmur

.github/workflows/ci.yml

@@ -24,7 +24,7 @@ jobs:
     steps:
       - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
 
-      - run: ./scripts/copy_license && git diff --name-only --exit-code
+      - run: ./scripts/copy_license --check
 
   check-packed-files:
     name: Check package files

.swiftformat

@@ -0,0 +1,11 @@
+--indent 4
+--linebreaks lf
+--wraparguments before-first
+--wrapcollections before-first
+--commas inline
+--allman false
+--semicolons inline
+--trimwhitespace always
+--disable redundantReturn,hoistAwait,preferKeyPath,redundantInternal,redundantPublic
+--swiftversion 5.7.1
+--extensionacl on-declarations

…hopify/checkout-sheet-kit/.swiftlint.yml .swiftlint.ymlmodules/@shopify/checkout-sheet-kit/.swiftlint.yml renamed to .swiftlint.yml modules/@shopify/checkout-sheet-kit/.swiftlint.yml renamed to .swiftlint.yml

@@ -1,9 +1,13 @@
 disabled_rules:
   - line_length
-  - redundant_void_return
-  - todo
-  - switch_case_alignment
+  - file_length
+  - non_optional_string_data_conversion
+  - type_body_length
+  - type_name
+  - identifier_name
+  - opening_brace
   - function_body_length
+  - trailing_comma
 
 opt_in_rules:
   - array_init
@@ -22,6 +26,10 @@ opt_in_rules:
   - modifier_order
   - overridden_super_call
   - toggle_bool
+  - switch_case_alignment:
+    indented_cases: false
+  - fallthrough
+  - explicit_acl
 
 nesting:
   type_level:

dev.yml

@@ -26,6 +26,9 @@ up:
 packages:
   - xcode
 
+check:
+  lint: ./scripts/lint_swift
+
 commands:
 
   server:
@@ -47,3 +50,8 @@ commands:
       yarn module clean
       yarn sample clean
       echo "✅ Cleaned root, module and sample workspaces"
+
+  fix:
+    desc: Fix linting
+    run: |
+      ./scripts/lint_swift fix