Skip to content

Conversation

@markmur
Copy link
Contributor

@markmur markmur commented Nov 4, 2024

What changes are you making?

Adds consumer proguard rules to prevent minifcation.

Fixes #124


PR Checklist

Important

@markmur markmur requested a review from kiftio November 4, 2024 09:25
@markmur markmur self-assigned this Nov 4, 2024
@markmur markmur requested a review from a team as a code owner November 4, 2024 09:25
@markmur markmur force-pushed the markmur/consumer-proguard-rules branch from dd24027 to b9da393 Compare November 4, 2024 09:26
Copy link

@xseignard xseignard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for giving a shot

@markmur markmur force-pushed the markmur/consumer-proguard-rules branch 2 times, most recently from 464b51d to 505f4bc Compare November 15, 2024 09:27
<key>com.apple.developer.associated-domains</key>
<array>
<string>webcredentials:myshopify.com</string>
<string>applinks:myshopify.com</string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this related?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not but it's fine to leave in. Will be improving on this soon

@markmur markmur force-pushed the markmur/consumer-proguard-rules branch from 505f4bc to 3881232 Compare November 15, 2024 10:10
@markmur markmur force-pushed the markmur/consumer-proguard-rules branch from e2c1785 to b52bcee Compare November 15, 2024 10:22
@markmur markmur merged commit 4e4b31e into main Nov 15, 2024
8 checks passed
@markmur markmur deleted the markmur/consumer-proguard-rules branch November 15, 2024 10:49
@markmur
Copy link
Contributor Author

markmur commented Nov 15, 2024

@shopify/[email protected] has been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

completed event is not caught on Android on release builds

3 participants