feat: support new Cart respondWith instead of CartInput #409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report
|
markmur
reviewed
Dec 16, 2025
Comment on lines
-49
to
-61
| /** | ||
| * Converts a JSON string to a dictionary. | ||
| */ | ||
| static func stringToJSON(from value: String?) -> [String: Any]? { | ||
| guard let data = value?.data(using: .utf8, allowLossyConversion: false) else { return [:] } | ||
| do { | ||
| return try JSONSerialization.jsonObject(with: data, options: .mutableContainers) as? [String: Any] | ||
| } catch { | ||
| print("Failed to convert string to JSON: \(error)", value ?? "nil") | ||
| return [:] | ||
| } | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
This no longer referenced anywhere?
Contributor
Author
There was a problem hiding this comment.
Yeah we were never using it
markmur
approved these changes
Dec 16, 2025
Contributor
markmur
left a comment
markmur
left a comment
There was a problem hiding this comment.
Looks good bar the __typenames
Contributor
Author
Sweet - I'm going to merge as is then do separate PR's for the revert of __typename |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are you making?
Adds support for the new cart responses:
PR Checklist
Important
Releasing a new version of the kit?
package.jsonfile.Tip
See the Contributing documentation for instructions on how to publish a new version of the library.