Skip to content

Commit 87b7fe9

Browse files
committed
We can't rely on DISABLE_SHARED:
- When Ruby 3.1.7 gets picked up as the runtime ruby for creating fat gems, it will have the `ENABLE_SHARED=no`. That's because the ruby/ruby-builder repository didn't enable the `--enable-shared` flag during compilation. The issue is that because its set to "no", then we don't rewrite Makefiles, which causes issues because other Rubies that are getting compiled have the flag enabled.
1 parent 8c7bb03 commit 87b7fe9

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

lib/easy_compile/compilation_tasks.rb

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ def define_task(path)
7979
ext.cross_compile = true
8080
end
8181

82-
disable_shared if darwin? && shared_enabled?
82+
disable_shared if darwin?
8383
ensure
8484
self.binary_name = nil
8585
end
@@ -95,10 +95,6 @@ def darwin?
9595
Gem::Platform.local.os == "darwin"
9696
end
9797

98-
def shared_enabled?
99-
RbConfig::CONFIG["ENABLE_SHARED"] == "yes"
100-
end
101-
10298
def disable_shared
10399
makefile_tasks = Rake::Task.tasks.select { |task| task.name =~ /Makefile/ }
104100

0 commit comments

Comments
 (0)