Merge pull request #6572 from Shopify/11-04-fix_loader_error_for_local_mode

Fix loader error for local mode

Author: isaacroldan

packages/app/src/cli/models/app/loader.test.ts

@@ -527,6 +527,66 @@ redirect_urls = [ "https://example.com/api/auth" ]
     expect(app.errors).toBeUndefined()
   })
 
+  test('throws error for duplicated handles when mode is local', async () => {
+    // Given
+    await writeConfig(appConfiguration)
+
+    const blockConfiguration = `
+      api_version = "2022-07"
+
+      [[extensions]]
+      type = "checkout_post_purchase"
+      name = "my_extension_1"
+      handle = "handle-1"
+      description = "custom description"
+
+      [[extensions]]
+      type = "flow_action"
+      handle = "handle-1"
+      name = "my_extension_1_flow"
+      description = "custom description"
+      runtime_url = "https://example.com"
+      `
+    await writeBlockConfig({
+      blockConfiguration,
+      name: 'my_extension_1',
+    })
+    await writeFile(joinPath(blockPath('my_extension_1'), 'index.js'), '')
+
+    // When/Then
+    await expect(loadTestingApp({mode: 'local'})).rejects.toThrow(/Duplicated handle/)
+  })
+
+  test('does not throw error for duplicated handles when mode is report', async () => {
+    // Given
+    await writeConfig(appConfiguration)
+
+    const blockConfiguration = `
+      api_version = "2022-07"
+
+      [[extensions]]
+      type = "checkout_post_purchase"
+      name = "my_extension_1"
+      handle = "handle-1"
+      description = "custom description"
+
+      [[extensions]]
+      type = "flow_action"
+      handle = "handle-1"
+      name = "my_extension_1_flow"
+      description = "custom description"
+      runtime_url = "https://example.com"
+      `
+    await writeBlockConfig({
+      blockConfiguration,
+      name: 'my_extension_1',
+    })
+    await writeFile(joinPath(blockPath('my_extension_1'), 'index.js'), '')
+
+    // When/Then
+    await expect(loadTestingApp({mode: 'report'})).resolves.not.toThrow()
+  })
+
   test('throws if 2 or more extensions have the same handle', async () => {
     // Given
     await writeConfig(appConfiguration)

packages/app/src/cli/models/app/loader.ts

@@ -739,11 +739,13 @@ class AppLoader<TConfig extends AppConfiguration, TModuleSpec extends ExtensionS
   }
 
   private abortOrReport<T>(errorMessage: OutputMessage, fallback: T, configurationPath: string): T {
-    if (this.mode === 'strict') {
-      throw new AbortError(errorMessage)
-    } else {
-      this.errors.addError(configurationPath, errorMessage)
-      return fallback
+    switch (this.mode) {
+      case 'strict':
+      case 'local':
+        throw new AbortError(errorMessage)
+      case 'report':
+        this.errors.addError(configurationPath, errorMessage)
+        return fallback
     }
   }