Add a build manifest build step

Author: alfonso-noriega

packages/app/src/cli/models/extensions/extension-instance.ts

@@ -348,19 +348,14 @@ export class ExtensionInstance<TConfiguration extends BaseConfigType = BaseConfi
       extension: this,
       options,
       stepResults: new Map(),
-      signal: options.signal,
     }
 
-    const steps = buildConfig.mode === 'none' ? [] : buildConfig.steps
+    const steps = buildConfig.steps ?? []
 
     for (const step of steps) {
       // eslint-disable-next-line no-await-in-loop
       const result = await executeStep(step, context)
       context.stepResults.set(step.id, result)
-
-      if (!result.success && !step.continueOnError) {
-        throw new Error(`Build step "${step.displayName}" failed: ${result.error?.message}`)
-      }
     }
   }
 

packages/app/src/cli/services/build/build-steps.integration.test.ts

@@ -9,12 +9,12 @@ import {Writable} from 'stream'
 function buildOptions(): ExtensionBuildOptions {
   return {
     stdout: new Writable({
-      write(chunk, encoding, callback) {
+      write(_chunk, _encoding, callback) {
         callback()
       },
     }),
     stderr: new Writable({
-      write(chunk, encoding, callback) {
+      write(_chunk, _encoding, callback) {
         callback()
       },
     }),

packages/app/src/cli/services/build/build-steps.ts

@@ -25,6 +25,7 @@ export interface BuildStep {
   /** Step type (determines which executor handles it) */
   readonly type:
     | 'copy_files'
+    | 'build_manifest'
     | 'build_theme'
     | 'bundle_theme'
     | 'bundle_ui'
@@ -60,15 +61,12 @@ export interface BuildContext {
 
   /** Results from previous steps (for step dependencies) */
   readonly stepResults: Map<string, StepResult>
-
-  /** Custom data that steps can write to (extensible) */
-  [key: string]: unknown
 }
 
 /**
  * Result of a step execution
  */
-interface StepResult {
+export interface StepResult {
   readonly stepId: string
   readonly displayName: string
   readonly success: boolean