Merge pull request #6556 from Shopify/sd.refactor-function-info-command

Refactoring function info command logic into service

Author: gonzaloriestra

packages/app/src/cli/commands/app/function/info.ts

@@ -1,11 +1,12 @@
 import {chooseFunction, functionFlags, getOrGenerateSchemaPath} from '../../../services/function/common.js'
 import {functionRunnerBinary, downloadBinary} from '../../../services/function/binaries.js'
+import {functionInfo} from '../../../services/function/info.js'
 import {localAppContext} from '../../../services/app-context.js'
 import {appFlags} from '../../../flags.js'
 import AppUnlinkedCommand, {AppUnlinkedCommandOutput} from '../../../utilities/app-unlinked-command.js'
 import {globalFlags, jsonFlag} from '@shopify/cli-kit/node/cli'
-import {outputContent, outputResult, outputToken} from '@shopify/cli-kit/node/output'
-import {InlineToken, renderInfo} from '@shopify/cli-kit/node/ui'
+import {outputResult} from '@shopify/cli-kit/node/output'
+import {AlertCustomSection, renderInfo} from '@shopify/cli-kit/node/ui'
 
 export default class FunctionInfo extends AppUnlinkedCommand {
   static summary = 'Print basic information about your function.'
@@ -41,16 +42,6 @@ export default class FunctionInfo extends AppUnlinkedCommand {
     const functionRunner = functionRunnerBinary()
     await downloadBinary(functionRunner)
 
-    const targeting: {[key: string]: {inputQueryPath?: string; export?: string}} = {}
-    ourFunction?.configuration.targeting?.forEach((target) => {
-      if (target.target) {
-        targeting[target.target] = {
-          ...(target.input_query && {inputQueryPath: `${ourFunction.directory}/${target.input_query}`}),
-          ...(target.export && {export: target.export}),
-        }
-      }
-    })
-
     const schemaPath = await getOrGenerateSchemaPath(
       ourFunction,
       flags.path,
@@ -59,81 +50,17 @@ export default class FunctionInfo extends AppUnlinkedCommand {
       flags.config,
     )
 
+    const result = functionInfo(ourFunction, {
+      format: flags.json ? 'json' : 'text',
+      functionRunnerPath: functionRunner.path,
+      schemaPath,
+    })
+
     if (flags.json) {
-      outputResult(
-        JSON.stringify(
-          {
-            handle: ourFunction.configuration.handle,
-            name: ourFunction.name,
-            apiVersion: ourFunction.configuration.api_version,
-            targeting,
-            schemaPath,
-            wasmPath: ourFunction.outputPath,
-            functionRunnerPath: functionRunner.path,
-          },
-          null,
-          2,
-        ),
-      )
+      outputResult(result as string)
     } else {
-      const configData: InlineToken[][] = [
-        ['Handle', ourFunction.configuration.handle ?? 'N/A'],
-        ['Name', ourFunction.name ?? 'N/A'],
-        ['API Version', ourFunction.configuration.api_version ?? 'N/A'],
-      ]
-
-      const sections: {title: string; body: {tabularData: InlineToken[][]; firstColumnSubdued?: boolean}}[] = [
-        {
-          title: 'CONFIGURATION\n',
-          body: {
-            tabularData: configData,
-            firstColumnSubdued: true,
-          },
-        },
-      ]
-
-      if (Object.keys(targeting).length > 0) {
-        const targetingData: InlineToken[][] = []
-        Object.entries(targeting).forEach(([target, config]) => {
-          targetingData.push([outputContent`${outputToken.cyan(target)}`.value, ''])
-          if (config.inputQueryPath) {
-            targetingData.push([{subdued: '  Input Query Path'}, {filePath: config.inputQueryPath}])
-          }
-          if (config.export) {
-            targetingData.push([{subdued: '  Export'}, config.export])
-          }
-        })
-
-        sections.push({
-          title: '\nTARGETING\n',
-          body: {
-            tabularData: targetingData,
-          },
-        })
-      }
-
-      sections.push(
-        {
-          title: '\nBUILD\n',
-          body: {
-            tabularData: [
-              ['Schema Path', {filePath: schemaPath ?? 'N/A'}],
-              ['Wasm Path', {filePath: ourFunction.outputPath}],
-            ],
-            firstColumnSubdued: true,
-          },
-        },
-        {
-          title: '\nFUNCTION RUNNER\n',
-          body: {
-            tabularData: [['Path', {filePath: functionRunner.path}]],
-            firstColumnSubdued: true,
-          },
-        },
-      )
-
       renderInfo({
-        customSections: sections,
+        customSections: result as AlertCustomSection[],
       })
     }