Skip to content

Commit 1e1b0eb

Browse files
committed
Update tests
1 parent 11aa646 commit 1e1b0eb

File tree

2 files changed

+7
-20
lines changed

2 files changed

+7
-20
lines changed

packages/app/src/cli/models/app/app.test.ts

Lines changed: 6 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -473,15 +473,6 @@ describe('allExtensions', () => {
473473
})
474474
})
475475

476-
describe('patchManifestWithDevURLs', () => {
477-
test('patches the manifest with the development URLs', () => {
478-
const app = testApp({})
479-
480-
const manifest = app.manifest()
481-
expect(manifest).toContain(app.devApplicationURLs?.applicationUrl)
482-
})
483-
})
484-
485476
describe('manifest', () => {
486477
test('generates a manifest with basic app information and modules', async () => {
487478
// Given
@@ -590,14 +581,7 @@ describe('manifest', () => {
590581

591582
test('does not patch URLs when devApplicationURLs is not available', async () => {
592583
// Given
593-
const appHome = await testUIExtension({
594-
type: 'app_home',
595-
configuration: {
596-
name: 'App Home',
597-
type: 'app_home',
598-
handle: 'app-home',
599-
},
600-
})
584+
const appHome = await testAppHomeConfigExtension()
601585

602586
const app = await testApp({
603587
name: 'my-app',
@@ -618,12 +602,15 @@ describe('manifest', () => {
618602
handle: '',
619603
modules: [
620604
{
621-
type: 'app_home',
605+
type: 'app_home_external',
622606
handle: 'app-home',
623607
uid: appHome.uid,
624608
assets: appHome.uid,
625609
target: appHome.contextValue,
626-
config: {},
610+
config: {
611+
app_url: 'https://example.com',
612+
embedded: true,
613+
},
627614
},
628615
],
629616
})

packages/app/src/cli/models/app/app.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -495,7 +495,7 @@ export class App<
495495
/**
496496
* Patches the manifest with the development URLs.
497497
* @param modules - All App modules
498-
* @returns All app moduels with patches applied.
498+
* @returns All app modules with patches applied.
499499
*/
500500
private patchManifestWithDevURLs(modules: {type: string; config: JsonMapType}[]) {
501501
if (!this.devApplicationURLs) return modules

0 commit comments

Comments
 (0)