Merge pull request #6377 from Shopify/better-errors-on-acceptance-tests

Improve logs for acceptance tests

Author: isaacroldan

packages/features/lib/system.ts

@@ -22,21 +22,21 @@ export function exec(command: string, args: string[] = [], options?: ExecOptions
 
   const _options = {
     ...options,
-    stdout: undefined,
-    stderr: undefined,
     env: {...process.env, ...(options?.env ?? {}), SHOPIFY_RUN_AS_USER: '0'},
   }
   const shortCommand = command.split('/').slice(-1).pop() || ''
   const commandProcess = execa(command, args, _options)
-  commandProcess.stdout?.on('data', (data: string) => {
-    if (isDebug) {
-      console.log(colors.gray(`${colors.bold(shortCommand)}: ${data}`))
-    }
-  })
-  commandProcess.stderr?.on('data', (data: string) => {
-    if (isDebug) {
-      console.log(colors.gray(`${colors.bold(shortCommand)}: ${data}`))
-    }
-  })
+
+  if (isDebug && commandProcess.stdout) {
+    commandProcess.stdout.on('data', (data: Buffer) => {
+      console.log(colors.gray(`${colors.bold(shortCommand)}: ${data.toString()}`))
+    })
+  }
+  if (isDebug && commandProcess.stderr) {
+    commandProcess.stderr.on('data', (data: Buffer) => {
+      console.log(colors.gray(`${colors.bold(shortCommand)}: ${data.toString()}`))
+    })
+  }
+
   return commandProcess
 }

packages/features/steps/app.steps.ts

@@ -123,8 +123,8 @@ async function generateExtension({name, type, directory, extraArgs, env}: Genera
       ],
       {env},
     )
-    // eslint-disable-next-line no-catch-all/no-catch-all
-  } catch {
-    assert.ok(true)
+  } catch (error) {
+    console.error(`Failed to generate extension: ${name} of type ${type}`, error)
+    throw error
   }
 }